ICEfaces
  1. ICEfaces
  2. ICE-7691

Provide a CSS styleClass for customizing the ajax submit "Busy" indicator

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 3.0
    • Fix Version/s: 3.1
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      ICEfaces 3.0 RC2
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      When ICEfaces is waiting on a server response, it adds a style="cursor: wait;" to the body element. It would be better to add a class to the body instead. This would provide more flexibility.

        Activity

        Evgheni Sadovoi created issue -
        Evgheni Sadovoi made changes -
        Field Original Value New Value
        Salesforce Case [5007000000KFCMG]
        Evgheni Sadovoi made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Summary Loading indicator Provide a CSS styleClass for customizing the ajax submit "Busy" indicator
        Component/s Bridge [ 10011 ]
        Component/s Framework [ 10013 ]
        Fix Version/s 3.1 [ 10312 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Assignee Priority P2
        Affects Version/s 3.0 [ 10241 ]
        Affects Version/s 3.0.RC2 [ 10313 ]
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Evgheni Sadovoi made changes -
        Salesforce Case [5007000000KFCMG] [5007000000KFCMG, 5007000000LHkLb]
        Hide
        Ken Fyten added a comment -

        Keep in mind that for backwards compatibility, the default styling via the style-class should set the hourglass cursor.

        Show
        Ken Fyten added a comment - Keep in mind that for backwards compatibility, the default styling via the style-class should set the hourglass cursor.
        Ken Fyten made changes -
        Assignee Priority P2 P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28795 Mon Apr 23 18:21:19 MDT 2012 mircea.toma ICE-7691 Added 'busyIndicator' class that can be used to custom style the busy state of the page.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/status.js
        Hide
        Mircea Toma added a comment -

        Added 'busyIndicator' class that can be used to custom style the busy state of the page.

        Show
        Mircea Toma added a comment - Added 'busyIndicator' class that can be used to custom style the busy state of the page.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Should change the class name to "ice-busyIndicator" to namespace this.

        Show
        Ken Fyten added a comment - Should change the class name to "ice-busyIndicator" to namespace this.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28806 Tue Apr 24 16:24:57 MDT 2012 mircea.toma ICE-7691 Namespace style class.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/status.js
        Hide
        Mircea Toma added a comment -

        Namespaced style class.

        Show
        Mircea Toma added a comment - Namespaced style class.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28823 Thu Apr 26 09:41:46 MDT 2012 mircea.toma ICE-7691 Add busy indicator test case.
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/build.xml
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java/org/icefaces/demo/busyIndicator
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/test-without-status-component.xhtml
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java/org
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/WEB-INF/faces-config.xml
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/resources
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/index.html
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/WEB-INF
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/WEB-INF/web.xml
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java/org/icefaces/demo
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java/org/icefaces
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/java/org/icefaces/demo/busyIndicator/SleepBean.java
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src
        Commit graph ADD /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/test-with-status-component.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28836 Thu Apr 26 13:57:59 MDT 2012 mircea.toma ICE-7691 Fix link in index page. Tweak style for the status component.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/index.html
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/core/test/busyIndicator/src/main/webapp/test-with-status-component.xhtml
        Hide
        Ken Fyten added a comment -

        This changed seems to have broken the hourglass / busyIndicator functionality.

        Test results using the new icefaces/samples/tests/busyIndicator test:

        EE 3.0.0.GA:

        • IE 7 works
        • IE 8 works
        • IE 9 works
        • FF 13 works
        • Safari 5 no works
        • Chrome 18 no works

        3.1 (rvn #28834):
        IE 7 no works
        IE 8 no works
        IE 9 no works
        FF 13 works
        Safari 5 no works
        Chrome 18 no works

        Show
        Ken Fyten added a comment - This changed seems to have broken the hourglass / busyIndicator functionality. Test results using the new icefaces/samples/tests/busyIndicator test: EE 3.0.0.GA: IE 7 works IE 8 works IE 9 works FF 13 works Safari 5 no works Chrome 18 no works 3.1 (rvn #28834): IE 7 no works IE 8 no works IE 9 no works FF 13 works Safari 5 no works Chrome 18 no works
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Priority P1 P2
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28840 Thu Apr 26 15:05:10 MDT 2012 mircea.toma ICE-7691 Reverted back to the strategy where only the cursor is changed programmaticaly (as opposed to using a style class).
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/status.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28841 Thu Apr 26 15:14:56 MDT 2012 mircea.toma ICE-7691 Enable 'wait' cursor for Webkit based browsers.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/status.js
        Hide
        Mircea Toma added a comment -

        Reverted back to the strategy where only the cursor is changed programmatically (as opposed to using a style class).

        Show
        Mircea Toma added a comment - Reverted back to the strategy where only the cursor is changed programmatically (as opposed to using a style class).
        Hide
        Mircea Toma added a comment -

        Enabled 'wait' cursor for Webkit based browsers.

        Show
        Mircea Toma added a comment - Enabled 'wait' cursor for Webkit based browsers.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ken Fyten added a comment -

        Won't be proceeding with this change as using a dynamic style class results in additional complexity and fragility on some browsers with little perceived gain.

        Show
        Ken Fyten added a comment - Won't be proceeding with this change as using a dynamic style class results in additional complexity and fragility on some browsers with little perceived gain.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Won't Fix [ 2 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Evgheni Sadovoi
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: