ICEfaces
  1. ICEfaces
  2. ICE-7610

showcase - ace:dialog - resizing of the dialog box is not accurate

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0.RC2
          • Fix Version/s: 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Code Rev: 3.0.0.RC2 build 9
            Browser: all major browsers
            Server: Tomcat7
          • Assignee Priority:
            P2

            Description

            On ace:dialog - > Effect & Size page, resizing of the dialog box is not quite accurate, as example selecting 600 px for both width and height, and both effects='bounce' displays a dialog box as in screenshot attached (dialogBoxResize.png), where it is visible that width is much smaller than height.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              yip.ng added a comment - - edited

              Dropdown lists in demo are for minimum width and height, not actual width and height. Min. height is set correctly. See screenshot-2.png. (Lots of calculations and cross-browser logic involved in jquery-ui, not just a simple setting.) However, somehow min. width is not set correctly.

              Show
              yip.ng added a comment - - edited Dropdown lists in demo are for minimum width and height, not actual width and height. Min. height is set correctly. See screenshot-2.png. (Lots of calculations and cross-browser logic involved in jquery-ui, not just a simple setting.) However, somehow min. width is not set correctly.
              Hide
              Permalink
              yip.ng added a comment - - edited

              Caused by allowing "auto" width in ICE-7341. In jquery-ui there is such code as this:

              if (options.minWidth > options.width) {

              i.e., if (600 > "auto") {

              There is some type coercion going on. "The rules are complicated and unmemorable. The lack of transitivity is alarming." ( – Douglas Crockford, "JavaScript: The Good Parts.")

              Show
              yip.ng added a comment - - edited Caused by allowing "auto" width in ICE-7341 . In jquery-ui there is such code as this: if (options.minWidth > options.width) { i.e., if (600 > "auto") { There is some type coercion going on. "The rules are complicated and unmemorable. The lack of transitivity is alarming." ( – Douglas Crockford, "JavaScript: The Good Parts.")
              Hide
              Permalink
              yip.ng added a comment - - edited

              Fixed by setting min. width regardless. Min. width overrides "auto" width if actual width is smaller. Note that "auto" width or height has some unpredictable side effects. See ICE-7341.

              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\jquery\ui\jquery-ui.js
              Completed: At revision: 27079

              Show
              yip.ng added a comment - - edited Fixed by setting min. width regardless. Min. width overrides "auto" width if actual width is smaller. Note that "auto" width or height has some unpredictable side effects. See ICE-7341 . Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\jquery\ui\jquery-ui.js Completed: At revision: 27079
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified the fix with code revision #27107, on browsers: Internet Explorer *, Firefox 3.6, Chrome15.

              Show
              Carmen Cristurean added a comment - Verified the fix with code revision #27107, on browsers: Internet Explorer *, Firefox 3.6, Chrome15.

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Carmen Cristurean
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: