ICEfaces
  1. ICEfaces
  2. ICE-7584

ACE components triggering double-submits when used with nested ace:ajax

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.RC1
    • Fix Version/s: 3.0.RC2, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF 3, ACE components
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      The following components have their ace:ajax behaviour handling written such that it makes the non ace:ajax-style component request, followed by an extraneous request to trigger the ace:ajax execute/render and listener, when one would expect those render/execute targets to be the targets of the previous request and the ace:ajax listener to be activated during the same lifecycle as the previous request.

      This behaviour was originally specced this way, but subsequent investigation has shown this to be incorrect. The expected behaviour is that the ace:ajax submit will take precedence in cases where the same event would trigger both an event listener attribute on the component and a defined event ace:ajax tag. This is consistent with standard f:ajax tag behaviour as well.

      Thus, the following components need changes so that the defined ace:ajax behaviour submits the params that the component request normally does.

      ace:accordion
      ace:droppable
      ace:progressBar
      ace:resizable
      ace:tooltip

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26908 Thu Dec 15 15:44:14 MST 2011 nils.lundquist ICE-7584 - Fixing accordion ace:ajax double submit.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/accordion/accordion.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26909 Thu Dec 15 15:52:42 MST 2011 nils.lundquist ICE-7584 - Fixing draggable & progressBar ace:ajax double submit.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/progressbar/progressbar.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dnd/dragdrop.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26910 Thu Dec 15 16:02:23 MST 2011 nils.lundquist ICE-7584 - Fixing tooltip & resizable ace:ajax double submit.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/resizable/resizable.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26911 Thu Dec 15 16:04:43 MST 2011 nils.lundquist ICE-7584 - Fixing tooltip ace:ajax double submit fix typo.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
        Nils Lundquist created issue -
        Nils Lundquist made changes -
        Field Original Value New Value
        Assignee Ken Fyten [ ken.fyten ]
        Nils Lundquist made changes -
        Salesforce Case []
        Description The following components have their ace:ajax behaviour handling written such that it makes the non ace:ajax-style component request, followed by an extraneous request to trigger the ace:ajax update/render and listener, when one would expect those render/update targets to be the targets of the previous request and the ace:ajax listener to be activated during the same lifecycle as the previous request. The components need changes so that the defined ace:ajax behaviour submits the params that the component request normally does.

        ace:accordion
        ace:droppable
        ace:progressBar
        ace:resizable
        ace:tooltip
        The following components have their ace:ajax behaviour handling written such that it makes the non ace:ajax-style component request, followed by an extraneous request to trigger the ace:ajax execute/render and listener, when one would expect those render/execute targets to be the targets of the previous request and the ace:ajax listener to be activated during the same lifecycle as the previous request. The components need changes so that the defined ace:ajax behaviour submits the params that the component request normally does.

        ace:accordion
        ace:droppable
        ace:progressBar
        ace:resizable
        ace:tooltip
        Ken Fyten made changes -
        Summary ace:ajax JS implemented to make unnecessary double submits ACE components triggering double-submits when used with nested ace:ajax
        Environment IF 3 IF 3, ACE components
        Salesforce Case []
        Component/s ACE-Components [ 10050 ]
        Fix Version/s 3.0 [ 10241 ]
        Assignee Priority P1
        Description The following components have their ace:ajax behaviour handling written such that it makes the non ace:ajax-style component request, followed by an extraneous request to trigger the ace:ajax execute/render and listener, when one would expect those render/execute targets to be the targets of the previous request and the ace:ajax listener to be activated during the same lifecycle as the previous request. The components need changes so that the defined ace:ajax behaviour submits the params that the component request normally does.

        ace:accordion
        ace:droppable
        ace:progressBar
        ace:resizable
        ace:tooltip
        The following components have their ace:ajax behaviour handling written such that it makes the non ace:ajax-style component request, followed by an extraneous request to trigger the ace:ajax execute/render and listener, when one would expect those render/execute targets to be the targets of the previous request and the ace:ajax listener to be activated during the same lifecycle as the previous request.

        This behaviour was originally specced this way, but subsequent investigation has shown this to be incorrect. The expected behaviour is that the ace:ajax submit will take precedence in cases where the same event would trigger both an event listener attribute on the component and a defined event ace:ajax tag. This is consistent with standard f:ajax tag behaviour as well.

        Thus, the following components need changes so that the defined ace:ajax behaviour submits the params that the component request normally does.

        ace:accordion
        ace:droppable
        ace:progressBar
        ace:resizable
        ace:tooltip
        Ken Fyten made changes -
        Salesforce Case []
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Assignee Ken Fyten [ ken.fyten ] Nils Lundquist [ nils.lundquist ]
        Hide
        Nils Lundquist added a comment -

        All fixes made and briefly tested on showcase. More rigorous testing could be done, but I don't have access to existing tests to base them off of, and the change should be uniformly safe, testing would serve only to catch possible typos.

        Show
        Nils Lundquist added a comment - All fixes made and briefly tested on showcase. More rigorous testing could be done, but I don't have access to existing tests to base them off of, and the change should be uniformly safe, testing would serve only to catch possible typos.
        Nils Lundquist made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Nils Lundquist added a comment - - edited

        Changes made in r26911, r26910, r26909 and r26908

        Show
        Nils Lundquist added a comment - - edited Changes made in r26911, r26910, r26909 and r26908
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26922 Fri Dec 16 10:16:52 MST 2011 nils.lundquist ICE-7584 - Fixing tooltip ace:ajax double submit fix typo.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26924 Fri Dec 16 11:29:47 MST 2011 nils.lundquist ICE-7584 - Fixing linkbutton & pushbutton ace:ajax double submit.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/linkbutton.js
        Hide
        Nils Lundquist added a comment -

        Issue extends to more components than originally stated.

        Fixed linkbutton and pushbutton in r26924

        Show
        Nils Lundquist added a comment - Issue extends to more components than originally stated. Fixed linkbutton and pushbutton in r26924
        Nils Lundquist made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Nils Lundquist added a comment -

        Can't find any other effected usages.

        Show
        Nils Lundquist added a comment - Can't find any other effected usages.
        Nils Lundquist made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 3.0.RC2 [ 10313 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26970 Tue Dec 20 08:28:38 MST 2011 nils.lundquist ICE-7584 - Fixed parameter passing to behaviours.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/accordion/accordion.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/progressbar/progressbar.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dnd/dragdrop.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/resizable/resizable.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27005 Wed Dec 21 09:31:47 MST 2011 ken.fyten ICE-7584 - Fixed parameter passing to behaviours.
        Files Changed
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0.RC2/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0.RC2/icefaces/ace/component/resources/icefaces.ace/resizable/resizable.js
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0.RC2/icefaces/ace/component/resources/icefaces.ace/accordion/accordion.js
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0.RC2/icefaces/ace/component/resources/icefaces.ace/progressbar/progressbar.js
        Commit graph MODIFY /icefaces3/tags/icefaces-3.0.0.RC2/icefaces/ace/component/resources/icefaces.ace/dnd/dragdrop.js
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Nils Lundquist
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: