ICEfaces
  1. ICEfaces
  2. ICE-7509

Remove PushRenderer.getPortableRenderer(FacesContext)

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.1-Beta2
          • Fix Version/s: 3.0.RC1, 3.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            N/A
          • Affects:
            Compatibility/Configuration

            Description

            Remove PushRenderer.getPortableRenderer(FacesContext) as only the PushRenderer.getPortableRenderer() should be used on a JSF thread, which in fact invoked the method to be removed using FacesContext.currentInstance(). We need to avoid illegal usage of PushRenderer.getPortableRenderer(FacesContext) in case it gets invoked with a cashed FacesContext either on a non-JSF thread or using a cached FacesContext other than the FacesContext on the current JSF thread.

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Jack Van Ooststroom made changes -
              Salesforce Case []
              Fix Version/s 3.0.RC1 [ 10300 ]
              Affects [Compatibility/Configuration]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26601 Fri Nov 25 18:38:35 MST 2011 jack.van.ooststroom Fixed JIRA ICE-7509 : Remove PushRenderer.getPortableRenderer(FacesContext)
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/progress/LongTaskManager.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/core/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/async/render/SessionRenderer.java
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending icefaces/compat/core/src/main/java/com/icesoft/faces/async/render/SessionRenderer.java
              Sending icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java
              Sending icefaces/samples/core/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java
              Sending icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/progress/LongTaskManager.java
              Transmitting file data ....
              Committed revision 26601.

              Show
              Jack Van Ooststroom added a comment - Sending icefaces/compat/core/src/main/java/com/icesoft/faces/async/render/SessionRenderer.java Sending icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java Sending icefaces/samples/core/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java Sending icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/compat/progress/LongTaskManager.java Transmitting file data .... Committed revision 26601.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The method has been removed and references in the sample application have been updated to utilize the no-args method instead. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The method has been removed and references in the sample application have been updated to utilize the no-args method instead. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 3.0 [ 10241 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: