ICEfaces
  1. ICEfaces
  2. ICE-7445

actions not triggered when dataPaginator immediate=true

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P03, 2.1-Beta2
    • Fix Version/s: 3.0.RC1, 3.0, EE-1.8.2.GA_P04
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      -
    • Assignee Priority:
      P1

      Description

      If immediate is true and you have done 1 pagination beyond the first page, the addMessage action event will no longer be called. If you remove the immediate attribute from the paginator, the action fires but then validation is not bypassed:

      <ice:commandButton value="add faces message" action="#{page1BackingBean.addMessage}"/>

      <ice:dataPaginator for="partResults" immediate="true">
      ........

      <ice:dataTable id="partResults">
      <ice:column>
      <ice:panelGroup>
      <ice:inputText value="#{column}">
      </ice:inputText>
      </ice:panelGroup>
      </ice:column>
      </ice:dataTable>

      Test case attached.

        Activity

        Tyler Johnson created issue -
        Hide
        Tyler Johnson added a comment -

        Mark commented:

        It sounds like the dataPaginator is not clearing out that it has changed to page 2, and so subsequently keeps thinking it's changing to page 2, and that doesn't look different to the rest of our framework, since nothing is changing, but it would involve the immediate processing that skips the rest of the lifecycle. It might be due to a lack of clearing out a hidden input field, or something wrong in the decoding.

        Show
        Tyler Johnson added a comment - Mark commented: It sounds like the dataPaginator is not clearing out that it has changed to page 2, and so subsequently keeps thinking it's changing to page 2, and that doesn't look different to the rest of our framework, since nothing is changing, but it would involve the immediate processing that skips the rest of the lifecycle. It might be due to a lack of clearing out a hidden input field, or something wrong in the decoding.
        Tyler Johnson made changes -
        Field Original Value New Value
        Salesforce Case [5007000000JLqc4]
        Tyler Johnson made changes -
        Description If immediate is true and you have done 1 pagination beyond the first page, the addMessage action event will no longer be called. If you remove the immediate attribute from the paginator, the action fires but then validation is not bypassed:

        <ice:commandButton value="add faces message" action="#{page1BackingBean.addMessage}"/>

        <ice:dataPaginator for="partResults" immediate="true">
        ........

        <ice:dataTable id="partResults">
        <ice:column>
        <ice:panelGroup>
        <ice:inputText value="#{column}">
                               <f:validateRegex pattern="^[1-9]$"/>
        </ice:inputText>
        </ice:panelGroup>
        </ice:column>
        </ice:dataTable>

        Test case attached.
        If immediate is true and you have done 1 pagination beyond the first page, the addMessage action event will no longer be called. If you remove the immediate attribute from the paginator, the action fires but then validation is not bypassed:

        <ice:commandButton value="add faces message" action="#{page1BackingBean.addMessage}"/>

        <ice:dataPaginator for="partResults" immediate="true">
        ........

        <ice:dataTable id="partResults">
        <ice:column>
        <ice:panelGroup>
        <ice:inputText value="#{column}">
        <f:validateRegex pattern="^[1-9]$"/>
        </ice:inputText>
        </ice:panelGroup>
        </ice:column>
        </ice:dataTable>

        Test case attached.
        Tyler Johnson made changes -
        Description If immediate is true and you have done 1 pagination beyond the first page, the addMessage action event will no longer be called. If you remove the immediate attribute from the paginator, the action fires but then validation is not bypassed:

        <ice:commandButton value="add faces message" action="#{page1BackingBean.addMessage}"/>

        <ice:dataPaginator for="partResults" immediate="true">
        ........

        <ice:dataTable id="partResults">
        <ice:column>
        <ice:panelGroup>
        <ice:inputText value="#{column}">
        <f:validateRegex pattern="^[1-9]$"/>
        </ice:inputText>
        </ice:panelGroup>
        </ice:column>
        </ice:dataTable>

        Test case attached.
        If immediate is true and you have done 1 pagination beyond the first page, the addMessage action event will no longer be called. If you remove the immediate attribute from the paginator, the action fires but then validation is not bypassed:

        <ice:commandButton value="add faces message" action="#{page1BackingBean.addMessage}"/>

        <ice:dataPaginator for="partResults" immediate="true">
        ........

        <ice:dataTable id="partResults">
        <ice:column>
        <ice:panelGroup>
        <ice:inputText value="#{column}">
        </ice:inputText>
        </ice:panelGroup>
        </ice:column>
        </ice:dataTable>

        Test case attached.
        Hide
        Tyler Johnson added a comment -

        Steps to reproduce using attached test:

        1. Navigate from page 1 to any other page.
        2. Try to click the commandbutton but nothing happens. The method should generate a facesMessage and display it to the screen.

        Show
        Tyler Johnson added a comment - Steps to reproduce using attached test: 1. Navigate from page 1 to any other page. 2. Try to click the commandbutton but nothing happens. The method should generate a facesMessage and display it to the screen.
        Tyler Johnson made changes -
        Attachment sf-10618.war [ 13740 ]
        Ken Fyten made changes -
        Fix Version/s 2.1 [ 10241 ]
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Assignee Priority P2
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Assignee Priority P2 P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26421 Thu Nov 17 20:40:52 MST 2011 adnan.durrani Fix for ICE-7445(actions not triggered when dataPaginator immediate=true)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #26422 Thu Nov 17 20:42:30 MST 2011 adnan.durrani Fix for ICE-7445(actions not triggered when dataPaginator immediate=true) to icefaces 2
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Adnan Durrani added a comment -

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
        Completed: At revision: 26421

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
        Completed: At revision: 26422

        Show
        Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 26421 Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 26422
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 3.0.RC1 [ 10300 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Tyler Johnson
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: