ICEfaces
  1. ICEfaces
  2. ICE-7424

Avoid keeping in memory byte arrays of files generated by ace:dataExporter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-Beta2
    • Fix Version/s: 3.0.1, EE-3.0.0.GA
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      As described in ICE-7381, the ExportResource class had to be modified to retain the byte arrays of the files generated by ace:dataExporter. Previously, the Resource object only contained a reference to an input stream, which was was request-scoped. So, in cases when the file download failed at the first try, the data wasn't available after subsequent tries, and the downloaded file had no data. To improve this situation, the ExportResource class will have to be modified to re-invoke the generator to produce a new input stream to serve the file, without having to keep the bytes in memory.

        Issue Links

          Activity

          Arturo Zambrano created issue -
          Arturo Zambrano made changes -
          Field Original Value New Value
          Link This issue depends on ICE-7381 [ ICE-7381 ]
          Arturo Zambrano made changes -
          Assignee Arturo Zambrano [ artzambrano ]
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 2.1.1 [ 10282 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28142 Fri Mar 02 17:04:21 MST 2012 art.zambrano ICE-7424 ace:dataExporter, fix to avoid keeping in memory byte arrays of generated files
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/ExporterResource.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dataexporter/dataexporter.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28143 Fri Mar 02 17:09:21 MST 2012 art.zambrano ICE-7424 ace:dataExporter, fix to avoid keeping in memory byte arrays of generated files
          Files Changed
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/resources/icefaces.ace/dataexporter/dataexporter.js
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/ExporterResource.java
          Hide
          Arturo Zambrano added a comment -

          Fixed at revision 28142 in the trunk and at revision 28143 in the maintenance branch.

          Show
          Arturo Zambrano added a comment - Fixed at revision 28142 in the trunk and at revision 28143 in the maintenance branch.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Arturo Zambrano added a comment -

          This fix wouldn't be applicable to ice.dataExporter, since with said component the generated files are first written to disk and then served as resources. They do not stay in memory.

          Show
          Arturo Zambrano added a comment - This fix wouldn't be applicable to ice.dataExporter, since with said component the generated files are first written to disk and then served as resources. They do not stay in memory.
          Ken Fyten made changes -
          Fix Version/s EE-3.0.0.GA [ 10262 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: