ICEfaces
  1. ICEfaces
  2. ICE-7371

Add support for JS onclick to ace:pushButton, linkButton and checkboxButton

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.1-Beta
          • Fix Version/s: 2.1-Beta2, 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            -
          • Assignee Priority:
            P2
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            Add support for the JS onclick to ace:pushButton, linkButton and checkboxButton. It seems as though the attribute is not being passed through.

            Example:

            <ace:pushButton value="Click" onclick="alert('test');"/> renders:

            <button id="form:_t7_span-button" type="button" tabindex="0" style="">Click</button>

              Activity

              Ascending order - Click to sort in descending order
              Tyler Johnson created issue -
              Tyler Johnson made changes -
              Field Original Value New Value
              Salesforce Case [5007000000JLgxh]
              Ken Fyten made changes -
              Fix Version/s 2.1 [ 10241 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.)]
              Assignee Priority P2
              Assignee Arturo Zambrano [ artzambrano ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Fixed at revision 26099.

              Added pass-thru attribute support to the button components.

              Show
              Arturo Zambrano added a comment - Fixed at revision 26099. Added pass-thru attribute support to the button components.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta2 [ 10294 ]
              Ken Fyten made changes -
              Issue Type Bug [ 1 ] Improvement [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26440 Fri Nov 18 10:32:50 MST 2011 ken.fyten ICE-7371 - Added pass-thru attribute support to pushButton, linkButton, and checkboxButton
              ICE-7207 - Add ThemeRoller support to ACE buttons (ace:pushButton, ace:linkButton, ace:checkboxButton)
              ICE-7176 - Buttons now do not depend on yui3 or 2in3 (but rather YUI 2.8)
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/background.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/background-highlight.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/background-active.png
              Commit graph DEL /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButton.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonMeta.java
              Commit graph DEL /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/skins
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.js
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/background-disabled.gif
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/background-focus.png
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26458 Fri Nov 18 12:13:38 MST 2011 ken.fyten ICE-7371 Added pass-thru attribute support to pushButton, linkButton, and checkboxButton
              ICE-7207 Add ThemeRoller support to ACE buttons (ace:pushButton, ace:linkButton, ace:checkboxButton)
              ICE-7176 Buttons now do not depend on yui3 or 2in3 (uses YUI 2.8 instead)
              ICE-6970 Adopted Apache 2.0 license source-code headers for ACE source-code.
              Files Changed
              Commit graph DEL /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/skins
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/background.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/background-active.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/background-focus.png
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/linkbutton.css
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/background-disabled.gif
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/linkbutton.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButton.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/linkbutton/background-highlight.png
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26468 Fri Nov 18 12:47:41 MST 2011 ken.fyten ICE-7371 Added pass-thru attribute support to pushButton, linkButton, and checkboxButton
              ICE-7377 ace:pushButton, moved style and class attributes to the button element
              ICE-7016 Added support to ace:pushButton to contain children
              ICE-7207: Add ThemeRoller support to ACE buttons (ace:pushButton, ace:linkButton, ace:checkboxButton)
              ICE-7176 Buttons now do not depend on yui3 or 2in3, but instead YUI 2.8.
              ICE-6970 Adopted Apache 2.0 license source-code headers for ACE source-code.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButton.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/background-active.png
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.js
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/background-disabled.gif
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java
              Commit graph DEL /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/skins
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/background-focus.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/background.png
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/background-highlight.png
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.css
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Hide
              Permalink
              Florian Hell added a comment -

              is this issue really fixed or is just the tld not extended? For me it is still not working on pushButton.

              Show
              Florian Hell added a comment - is this issue really fixed or is just the tld not extended? For me it is still not working on pushButton.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Tyler Johnson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: