ICEfaces
  1. ICEfaces
  2. ICE-7342

Improve ice:dataExporter memory usage

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P03
    • Fix Version/s: 3.0.RC1, 3.0, EE-1.8.2.GA_P04
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      -
    • Assignee Priority:
      P1

      Description

      A customer has the following dataExporter issues. They have a custom outputTypeHandler defined like so:

      <ice:dataExporter outputTypeHandler="#{table.excelDataTableExporter}" ... />

      The 'table' managed bean creates an instance of the custom class which extends com.icesoft.faces.component.dataexporter.ExcelOutputHandler and helps retrieve cell content/data depending on column. However I don't think this matters but worth mentioning. Here are their issues:

      1: The ExcelOutputHandler accepts a path as an input parameter and creates a blank excel file in it's constructor. If the user does not end up exporting the table, a blank excel file is still created on the server. If an application has 20-30 tables in it, these files will begin to accumulate rapidly. We should ensure that a file is only created when actually exporting the date.

      2: This may be related to 2. The exported files are not removed from memory when they are no longer needed (e.g. navigation) or the user's session is no longer valid. The deleteOnExit flag value appears to be true but the files are not deleted until the JVM terminates, which may not happen for months or years in a production environment.

        Activity

        Tyler Johnson created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Salesforce Case [5007000000JLSR4]
        Tyler Johnson made changes -
        Attachment ExcelDataTableExporter.java [ 13665 ]
        Ken Fyten made changes -
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Adnan Durrani made changes -
        Assignee Adnan Durrani [ adnan.durrani ] Ken Fyten [ ken.fyten ]
        Tyler Johnson made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Tyler Johnson made changes -
        Assignee Ken Fyten [ ken.fyten ] Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Tyler Johnson made changes -
        Attachment ExcelDataTableExporter.java [ 13665 ]
        Tyler Johnson made changes -
        Attachment CustomExcelExporter.java [ 13724 ]
        Ken Fyten made changes -
        Fix Version/s 2.1 [ 10241 ]
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 3.0.RC1 [ 10300 ]
        Tyler Johnson made changes -
        Salesforce Case [5007000000JLSR4] [5007000000JLSR4, 5007000000KEvM9]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Tyler Johnson
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: