ICEfaces
  1. ICEfaces
  2. ICE-7323

Add ability to disable/enable menuItems (and subMenus) via component attribute and JavaScript API.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.1
    • Fix Version/s: 3.1.0.BETA2, 3.1.0.RC1, 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Enhancement to the ace:menus to support both a component "enabled" attribute as well as a new JavaScript API to enable/disable them.
      1. screenshot-1.jpg
        32 kB
      2. screenshot-2.jpg
        40 kB
      3. screenshot-3.jpg
        44 kB

        Issue Links

          Activity

          yip.ng created issue -
          Ken Fyten made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s 2.1 [ 10241 ]
          Ken Fyten made changes -
          Assignee yip.ng [ yip.ng ]
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 2.1.1 [ 10282 ]
          Fix Version/s 2.1 [ 10241 ]
          Ken Fyten made changes -
          Summary Add ability to disable/enable menuItems (and subMenus) via JS API. Add ability to disable/enable menuItems (and subMenus) via component attribute and JavaScript API.
          Salesforce Case []
          Description Enhancement to the ace:menus to support a new JavaScript API to enable/disable them. Enhancement to the ace:menus to support both a component "enabled" attribute as well as a new JavaScript API to enable/disable them.
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 3.1 [ 10312 ]
          Fix Version/s 3.0.1 [ 10282 ]
          Assignee yip.ng [ yip.ng ]
          Arran Mccullough made changes -
          Salesforce Case [5007000000LI7Ff]
          Ken Fyten made changes -
          Affects [Documentation (User Guide, Ref. Guide, etc.)]
          Assignee Priority P2
          Assignee Arturo Zambrano [ artzambrano ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29163 Wed May 23 16:53:59 MDT 2012 art.zambrano ICE-7323 added 'disabled' attribute to ace:menuItem
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menuitem/MenuItemMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29178 Thu May 24 11:20:05 MDT 2012 art.zambrano ICE-7323 added 'disabled' attribute to ace:submenu
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/submenu/SubmenuMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29180 Thu May 24 11:53:34 MDT 2012 art.zambrano ICE-7323 added 'disabled' attribute to ace:multiColumnSubmenu
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/multicolumnsubmenu/MultiColumnSubmenuMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
          Hide
          Arturo Zambrano added a comment -

          Committed new feature at revision 29180. Added 'disabled' attribute to ace:menuItem, ace:submenu, and ace:multiColumnMenu.

          Show
          Arturo Zambrano added a comment - Committed new feature at revision 29180. Added 'disabled' attribute to ace:menuItem, ace:submenu, and ace:multiColumnMenu.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 3.1.0.BETA2 [ 10336 ]
          Affects Version/s 3.0.1 [ 10282 ]
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          Comment [ ace:contextMenu should also support the "disabled" attribute.
          ]
          Ken Fyten made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-7350 [ ICE-7350 ]
          Hide
          Brennan Mckinney added a comment -

          The disabled attribute breaks the styling of an ace:menu when it's changed dynamically, turning it from the actual menu into a standard html list. Changing the value back doesn't do anything to solve the issue, and a reset is required to get the right look back.

          See attached screenshots. Tested using menuDisable.xhtml at http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/menu/

          Show
          Brennan Mckinney added a comment - The disabled attribute breaks the styling of an ace:menu when it's changed dynamically, turning it from the actual menu into a standard html list. Changing the value back doesn't do anything to solve the issue, and a reset is required to get the right look back. See attached screenshots. Tested using menuDisable.xhtml at http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/menu/
          Brennan Mckinney made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Brennan Mckinney added a comment -

          What the ace:menu looks like before any changes

          Show
          Brennan Mckinney added a comment - What the ace:menu looks like before any changes
          Brennan Mckinney made changes -
          Attachment screenshot-1.jpg [ 14552 ]
          Hide
          Brennan Mckinney added a comment -

          After disabling one of the elements in the menu. Styling has gone.

          Show
          Brennan Mckinney added a comment - After disabling one of the elements in the menu. Styling has gone.
          Brennan Mckinney made changes -
          Attachment screenshot-2.jpg [ 14553 ]
          Hide
          Brennan Mckinney added a comment -

          Re-enabled. Submenu works again, but styling is unchanged.

          Show
          Brennan Mckinney added a comment - Re-enabled. Submenu works again, but styling is unchanged.
          Brennan Mckinney made changes -
          Attachment screenshot-3.jpg [ 14554 ]
          Ken Fyten made changes -
          Fix Version/s 3.1.0.RC1 [ 10337 ]
          Assignee Priority P2 P1
          Hide
          Arturo Zambrano added a comment -

          It seems to be a more general problem when making any dynamic updates. The same problem can be seen in the menuDynAttribute.jsf test page: checking the 'rendered' box first and then checking the 'tiered' box displays the menu as a plain HTML list. This is caused by having a client id in the top <ul> element. so that will have to be changed, but it does have some javascript implications. This could potentially also affect other menu components, since they also set a client id to the top <ul> element. Perhaps a new JIRA should be created to track this issue?

          Show
          Arturo Zambrano added a comment - It seems to be a more general problem when making any dynamic updates. The same problem can be seen in the menuDynAttribute.jsf test page: checking the 'rendered' box first and then checking the 'tiered' box displays the menu as a plain HTML list. This is caused by having a client id in the top <ul> element. so that will have to be changed, but it does have some javascript implications. This could potentially also affect other menu components, since they also set a client id to the top <ul> element. Perhaps a new JIRA should be created to track this issue?
          Arturo Zambrano made changes -
          Link This issue depends on ICE-8241 [ ICE-8241 ]
          Hide
          Arturo Zambrano added a comment -

          Committed fix, as part of ICE-8241, that solves this last issue.

          Show
          Arturo Zambrano added a comment - Committed fix, as part of ICE-8241 , that solves this last issue.
          Arturo Zambrano made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              yip.ng
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: