ICEfaces
  1. ICEfaces
  2. ICE-7312

Automatic Ajax broken after navigation

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-2.0.0.GA, 2.0.2
          • Fix Version/s: 2.1-Beta2, 3.0
          • Component/s: None
          • Labels:
            None
          • Environment:
            Mojarra 2.1.2
          • Assignee Priority:
            P2

            Description

            After a JSF navigation, the next request is not an Ajax one. This happens because the JavaScript which captures form submits is missing in the page.

            The problem is org.icefaces.impl.FormSubmit: The "guard against duplicates within the same JSF lifecycle" doesn't work in case of navigation because it relies on a FacesContext attribute. After a navigation the attribute is still there but because the ViewRoot changed the scriptWriter is actually not contained as a children of the form anymore.

              Activity

              Ascending order - Click to sort in descending order
              Adrian Gygax created issue -
              Hide
              Permalink
              Adrian Gygax added a comment -

              Attached a sample project including a patched FormSubmit which fixes the problem (See the "PATCHED" comment).

              To reproduce the problem simply remove the patched class and click twice on the button. The second button click will issue a normal request, not an Ajax one and the <script> tag is missing in the DOM.

              Show
              Adrian Gygax added a comment - Attached a sample project including a patched FormSubmit which fixes the problem (See the "PATCHED" comment). To reproduce the problem simply remove the patched class and click twice on the button. The second button click will issue a normal request, not an Ajax one and the <script> tag is missing in the DOM.
              Adrian Gygax made changes -
              Field Original Value New Value
              Attachment icefacesSupport.war [ 13623 ]
              Tyler Johnson made changes -
              Salesforce Case [5007000000JLCcm]
              Hide
              Permalink
              Ted Goddard added a comment -

              Request scope attribute or View Scope attribute can be used instead of FacesContext attribute (request scope likely preferred).

              Navigation tests need to be checked to see why this passed regression.

              Show
              Ted Goddard added a comment - Request scope attribute or View Scope attribute can be used instead of FacesContext attribute (request scope likely preferred). Navigation tests need to be checked to see why this passed regression.
              Hide
              Permalink
              Ted Goddard added a comment -

              It was also observed that a dummy bean is always added to window scope resulting in extra HTTP requests upon every navigation.

              Show
              Ted Goddard added a comment - It was also observed that a dummy bean is always added to window scope resulting in extra HTTP requests upon every navigation.
              Ken Fyten made changes -
              Fix Version/s 2.1 [ 10241 ]
              Assignee Priority P2
              Affects Version/s 2.0.2 [ 10273 ]
              Assignee Mircea Toma [ mircea.toma ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25924 Fri Oct 14 10:23:56 MDT 2011 mircea.toma ICE-7312 Change duplicate detection logic to check for the existence of the dynamically added component among the children of the current form instead of checking a flag set in the FacesContext's attribute map.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FormSubmit.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Change duplicate detection logic to check for the existence of the dynamically added component among the children of the current form instead of checking a flag set in the FacesContext's attribute map.

              The recommended fix was applied with a slight modification, the flag set in the FacesContext's attribute map to detect duplicates was removed since it became redundant.

              Show
              Mircea Toma added a comment - Change duplicate detection logic to check for the existence of the dynamically added component among the children of the current form instead of checking a flag set in the FacesContext's attribute map. The recommended fix was applied with a slight modification, the flag set in the FacesContext's attribute map to detect duplicates was removed since it became redundant.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              The "view scope retained test" case in 'scopes' application was detecting this issue already, so there is no need for additional tests.

              Show
              Mircea Toma added a comment - The "view scope retained test" case in 'scopes' application was detecting this issue already, so there is no need for additional tests.
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta2 [ 10294 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Adrian Gygax
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: