ICEfaces
  1. ICEfaces
  2. ICE-7299

Generator generates wrong attribute name for "for" attribute.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.1-Beta
          • Fix Version/s: 2.1-Beta2, 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces Advanced Components
          • Assignee Priority:
            P1

            Description

            For the "for" attribute, the generator is generating the variable name (e.g. "forValue") in the meta class as the attribute name for the TLD doc. See ICE-7290 for more details.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. ICE-7104 tabSetProxy "For" attribute should be in lower case

              • Major - Major loss of function.
              • Closed

                Activity

                Hide
                Permalink
                Mark Collette added a comment -

                The code that generates the TLD file and the Tag classes needed to be updated to look for the specified property name, and if none was specified, fallback to the Meta class' field name. But, only when specifying the property name as a string, or when constructing a getter or setter method name, as direct field names still needed to just be the given field name, as the property name could be a reserved Java keyword, like "for", and so can not be used directly, only indirectly.

                Also updated TabSetProxyMeta to specify the name field on the for property's annotation.

                Development branch
                Subversion 25970
                component/src/org/icefaces/ace/component/tab/TabSetProxyMeta.java
                generator/src/org/icefaces/ace/generator/artifacts/TagArtifact.java
                generator/src/org/icefaces/ace/generator/utils/Utility.java
                generator/src/org/icefaces/ace/generator/xmlbuilder/TLDBuilder.java

                Show
                Mark Collette added a comment - The code that generates the TLD file and the Tag classes needed to be updated to look for the specified property name, and if none was specified, fallback to the Meta class' field name. But, only when specifying the property name as a string, or when constructing a getter or setter method name, as direct field names still needed to just be the given field name, as the property name could be a reserved Java keyword, like "for", and so can not be used directly, only indirectly. Also updated TabSetProxyMeta to specify the name field on the for property's annotation. Development branch Subversion 25970 component/src/org/icefaces/ace/component/tab/TabSetProxyMeta.java generator/src/org/icefaces/ace/generator/artifacts/TagArtifact.java generator/src/org/icefaces/ace/generator/utils/Utility.java generator/src/org/icefaces/ace/generator/xmlbuilder/TLDBuilder.java

                  People

                  • Assignee:
                    Mark Collette
                    Reporter:
                    yip.ng
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: