ICEfaces
  1. ICEfaces
  2. ICE-7299

Generator generates wrong attribute name for "for" attribute.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.1-Beta
          • Fix Version/s: 2.1-Beta2, 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces Advanced Components
          • Assignee Priority:
            P1

            Description

            For the "for" attribute, the generator is generating the variable name (e.g. "forValue") in the meta class as the attribute name for the TLD doc. See ICE-7290 for more details.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. ICE-7104 tabSetProxy "For" attribute should be in lower case

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                yip.ng created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Environment * ICEfaces Advanced Components
                Salesforce Case []
                Component/s ACE-Components [ 10050 ]
                Component/s Components [ 10012 ]
                Fix Version/s 2.1 [ 10241 ]
                Assignee Priority P1
                Affects Version/s 2.1-Beta [ 10291 ]
                Assignee Mark Collette [ mark.collette ]
                Ken Fyten made changes -
                Salesforce Case []
                Assignee Priority P1 P2
                Ken Fyten made changes -
                Salesforce Case []
                Assignee Priority P2 P1
                Hide
                Permalink
                Mark Collette added a comment -

                The code that generates the TLD file and the Tag classes needed to be updated to look for the specified property name, and if none was specified, fallback to the Meta class' field name. But, only when specifying the property name as a string, or when constructing a getter or setter method name, as direct field names still needed to just be the given field name, as the property name could be a reserved Java keyword, like "for", and so can not be used directly, only indirectly.

                Also updated TabSetProxyMeta to specify the name field on the for property's annotation.

                Development branch
                Subversion 25970
                component/src/org/icefaces/ace/component/tab/TabSetProxyMeta.java
                generator/src/org/icefaces/ace/generator/artifacts/TagArtifact.java
                generator/src/org/icefaces/ace/generator/utils/Utility.java
                generator/src/org/icefaces/ace/generator/xmlbuilder/TLDBuilder.java

                Show
                Mark Collette added a comment - The code that generates the TLD file and the Tag classes needed to be updated to look for the specified property name, and if none was specified, fallback to the Meta class' field name. But, only when specifying the property name as a string, or when constructing a getter or setter method name, as direct field names still needed to just be the given field name, as the property name could be a reserved Java keyword, like "for", and so can not be used directly, only indirectly. Also updated TabSetProxyMeta to specify the name field on the for property's annotation. Development branch Subversion 25970 component/src/org/icefaces/ace/component/tab/TabSetProxyMeta.java generator/src/org/icefaces/ace/generator/artifacts/TagArtifact.java generator/src/org/icefaces/ace/generator/utils/Utility.java generator/src/org/icefaces/ace/generator/xmlbuilder/TLDBuilder.java
                Mark Collette made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s 2.1-Beta2 [ 10294 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #26436 Fri Nov 18 10:04:23 MST 2011 ken.fyten ICE-6112 added code for generating faces-config.xml entries for behaviors; adjusted ajax and animation tag handlers to these changes
                ICE-6884 : When ACE component in iterative container, setting ace property during render affects all rows
                ICE-6849 : @Field of type List not generating
                ICE-6394 modifications to remove reference to AnimationBehaviour in hardcoded FacesConfigBuilder. It is now part of the faces-confix.xml to be merged
                ICE-6934 modified generator to accept parameters for short name and namespace in the build script
                ICE-7299 : Generator generates wrong attribute name with the for attribute
                ICE-7348 : ACE generator stores null values that JSF state saving can not handle
                ICE-7321 Added checking in setters to see if the component is disconnected from the component tree to store attributes as default values, rather than row values
                ICE-7031 added Meta class for ajax tag handler; added 'behaviorId' attribute to @TagHandler annotation for BehaviorHandler's; adjusted animation tag handler to this change
                ICE-6118 : Enhance build scripts to allow for compiling and building libraries and samples against MyFaces
                ICE-6970 Adopted Apache 2.0 license source-code headers for ACE source-code.
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIComponentMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/utils/PropertyValues.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Facet.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/DefaultValueType.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/utils/Utility.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/TagArtifact.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/build.xml
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/Artifact.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/HtmlInputTextMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/Generator.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/ClientBehaviorHolder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/behavior/ClientBehaviorHolder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Properties.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Component.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/FacesConfigBuilder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UISelectBooleanMeta.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/TagHandlerArtifact.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/ActionSource.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UICommandMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Implementation.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/TagHandlerContext.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/build.properties
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Expression.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/TagHandler.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Facets.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIOutputMeta.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/TagHandlerType.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIDataMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIInputMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Property.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/TLDBuilder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIMessageMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/utils/FileWriter.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/behavior/Behavior.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/GeneratorContext.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIComponentBaseMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UISelectManyMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/FaceletTagLibBuilder.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/ClientEvent.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIMessagesMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Field.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/MetaContext.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UISelectOneMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/ComponentContext.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Required.java
                Commit graph ADD /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/FacesConfigMerge.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/TaglibMerge.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIPanelMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/XMLBuilder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentHandlerArtifact.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIColumnMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/baseMeta/UIFormMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/behavior/ActionSourceBehavior.java
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Mark Collette made changes -
                Link This issue is duplicated by ICE-7104 [ ICE-7104 ]

                  People

                  • Assignee:
                    Mark Collette
                    Reporter:
                    yip.ng
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: