ICEfaces
  1. ICEfaces
  2. ICE-7218

Setting a menuItem to be disabled doesn't render any unique CSS

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: EE-2.0.0.GA, EE-1.8.2.GA_P03
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All
    • Assignee Priority:
      P3
    • Workaround Exists:
      Yes
    • Workaround Description:
      Include your own CSS for the rendered disabled style classes.

      Description

      When setting a menuItem component to be disabled=true, the rendered ICEfaces default CSS (xp and rime) dpesn't render this item any differently than the enabled menuItems. The only difference is that the disabled menuItem doesn't get the hover CSS like the enabled ones do.

      If possible adding some extra CSS to the default ICEfaces style classes will allow a better representation of the disabled menuItem.

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Attachment disabled-menuItem-xp.JPG [ 13515 ]
        Hide
        Arran Mccullough added a comment -

        In the attached screen shot, Item Three is set to be disabled.

        Show
        Arran Mccullough added a comment - In the attached screen shot, Item Three is set to be disabled.
        Hide
        Arran Mccullough added a comment -

        Sample Code:

        <ice:form id="iceForm">
        <ice:outputText value="Welcome to ICEfaces 2"/>
        <ice:menuBar id="testMenu"
        displayOnClick="true">
        <ice:menuItem value="Item One">
        <ice:menuItem value="Item Two"/>
        <ice:menuItem value="Item Three" disabled="true"/>
        <ice:menuItem value="Item Four"/>
        </ice:menuItem>
        </ice:menuBar>
        </ice:form>

        Show
        Arran Mccullough added a comment - Sample Code: <ice:form id="iceForm"> <ice:outputText value="Welcome to ICEfaces 2"/> <ice:menuBar id="testMenu" displayOnClick="true"> <ice:menuItem value="Item One"> <ice:menuItem value="Item Two"/> <ice:menuItem value="Item Three" disabled="true"/> <ice:menuItem value="Item Four"/> </ice:menuItem> </ice:menuBar> </ice:form>
        Arran Mccullough made changes -
        Salesforce Case [5007000000I1yNM]
        Arran Mccullough made changes -
        Priority Major [ 3 ] Trivial [ 5 ]
        Arran Mccullough made changes -
        Description When setting a menuItem component to be disabled=true, the rendered ICEfaces default CSS (xp and rime) dpesn't render this item any differently than the enabled menuItems. The only difference is that the disabled menuItem doesn't get the hover CSS like the enabled ones do. When setting a menuItem component to be disabled=true, the rendered ICEfaces default CSS (xp and rime) dpesn't render this item any differently than the enabled menuItems. The only difference is that the disabled menuItem doesn't get the hover CSS like the enabled ones do.

        If possible adding some extra CSS to the default ICEfaces style classes will allow a better representation of the disabled menuItem.
        Hide
        Ken Fyten added a comment -

        I guess we should make the disabled menu text greyed out (maybe italicized also).

        Show
        Ken Fyten added a comment - I guess we should make the disabled menu text greyed out (maybe italicized also).
        Ken Fyten made changes -
        Fix Version/s 2.1 [ 10241 ]
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Assignee Priority P3
        Assignee Adnan Durrani [ adnan.durrani ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25629 Sun Sep 25 19:40:58 MDT 2011 adnan.durrani Fix for ICE-7218 (Setting a menuItem to be disabled doesn't render any unique CSS)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/woodstock/woodstock.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25630 Sun Sep 25 20:22:40 MDT 2011 adnan.durrani Fix for ICE-7218 (Setting a menuItem to be disabled doesn't render any unique CSS) ICEFaces2
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/rime/rime.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/rime/rime-portlet.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/xp/xp-portlet.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/royale/royale.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/xp/xp.css
        Hide
        Adnan Durrani added a comment -

        ICEFACES:

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime-portlet.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\royale\royale.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\woodstock\woodstock.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\woodstock\woodstock.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime-portlet.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\royale\royale.css
        Completed: At revision: 25629

        ICEFACES:2
        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime-portlet.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\royale\royale.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp-portlet.css
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime-portlet.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp-portlet.css
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\royale\royale.css
        Completed: At revision: 25630

        Show
        Adnan Durrani added a comment - ICEFACES: Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime-portlet.css Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\royale\royale.css Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\woodstock\woodstock.css Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\woodstock\woodstock.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\rime\rime-portlet.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\resources\css\royale\royale.css Completed: At revision: 25629 ICEFACES:2 Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime-portlet.css Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime.css Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\royale\royale.css Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp-portlet.css Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp.css Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime.css Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp.css Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\rime\rime-portlet.css Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\xp\xp-portlet.css Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\resources\css\com\icesoft\faces\resources\css\royale\royale.css Completed: At revision: 25630
        Adnan Durrani made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Adnan Durrani added a comment -

        Fixed for all themes.

        Show
        Adnan Durrani added a comment - Fixed for all themes.
        Adnan Durrani made changes -
        Attachment disabledMenu.jpg [ 13573 ]
        Ken Fyten made changes -
        Fix Version/s 2.1-Beta [ 10291 ]
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: