ICEfaces
  1. ICEfaces
  2. ICE-7186

Browser auto-fill/complete interfering with input validation

          Details

          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            <script type="text/javascript">
            function disableKeyPress(e)
            {
            var key;
            if(window.event)
            key = window.event.keyCode; //IE
            else
            key = e.which; //firefox

            return (key != 13);
            }
            </script>

            <ice:inputText id="name" value="#{bean.value}" required="true"
            onkeypress="return disableKeyPress(event);"/>
            Show
            <script type="text/javascript"> function disableKeyPress(e) { var key; if(window.event) key = window.event.keyCode; //IE else key = e.which; //firefox return (key != 13); } </script> <ice:inputText id="name" value="#{bean.value}" required="true" onkeypress="return disableKeyPress(event);"/>

            Description

            The web browsers auto-complete/auto-fill selection is interfering with input validation in an ice:inputText. The user will enter text, the browser will present a list of auto-complete options, they will then select an item using the keyboard and then press enter. The issue is that since the focus is still in the ice:inputText, the value is submitted. This is due to the ice:inputText using the enter key listener to fire the action event. The recommendation is to extend the ice:inputText component (new attribute) to prevent enter key submission for this scenario.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #27923 Fri Feb 17 11:16:58 MST 2012 ken.fyten ICE-7186 Use 'keyUp' instead of 'keyPress' event on enter key to execute the form submit. This gives a chance to the browser to pick up the selected value from the native auto-complete popup before the submit.
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TextRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/SecretRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #27795 Mon Feb 13 04:23:15 MST 2012 mircea.toma ICE-7186 Use 'keyUp' instead of 'keyPress' event on enter key to execute the form submit. This gives a chance to the browser to pick up the selected value from the native auto-complete popup before the submit.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/SecretRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TextRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #27740 Thu Feb 09 15:08:39 MST 2012 mircea.toma ICE-7186 Use 'keyUp' instead of 'keyPress' event on enter key to execute the form submit. This gives a chance to the browser to pick up the selected value from the native auto-complete popup before the submit.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/SecretRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TextRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Tyler Johnson
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: