ICEfaces
  1. ICEfaces
  2. ICE-7076

Clean-up FacesMessagesPhaseListener

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces

      Description

      FacesMessagesPhaseListener has a bunch of commented out System.outs as well as unused private methods. It'd be nicer if this class gets a nice clean-up.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25083 Fri Jul 22 16:11:25 MDT 2011 jack.van.ooststroom Fixed JIRA ICE-7076 : Clean-up FacesMessagesPhaseListener
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FacesMessagesPhaseListener.java
        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Assignee Jack van Ooststroom [ jack.van.ooststroom ]
        Hide
        Jack Van Ooststroom added a comment -

        Changed Fix Version/s to 2.1

        Show
        Jack Van Ooststroom added a comment - Changed Fix Version/s to 2.1
        Jack Van Ooststroom made changes -
        Salesforce Case []
        Fix Version/s 2.1 [ 10241 ]
        Hide
        Jack Van Ooststroom added a comment -

        Clean-up completed, which included:

        • Removing unused private methods
        • Removed commented out System.outs

        There is still some commented out code left, but I was unsure if I should remove this as well.

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - Clean-up completed, which included: Removing unused private methods Removed commented out System.outs There is still some commented out code left, but I was unsure if I should remove this as well. Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.1-Beta [ 10291 ]
        Ken Fyten made changes -
        Salesforce Case []
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: