ICEfaces
  1. ICEfaces
  2. ICE-7067

PushRenderer.addCurrentView(String) should be allowed to be invoked earlier in the lifecycle

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-2.0.0.GA, 2.0.2
    • Fix Version/s: 2.1-Beta, 3.0, EE-2.0.0.GA_P01
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces

      Description

      Currently when invoking PushRenderer.addCurrentView(String) early in the lifecycle, it results in the invocation of PushContext.addGroupMember with a pushID value of null. For instance with a ICEfaces component, places like in a setter's and the isInView methods of a UIComponentBase component, the pushID can not yet be found. In the encodeAll(...) method it can be found though. It would be nice if this could work earlier within the lifecycle somehow. Maybe even by caching earlier invocations if the addCurrentView(String) method.

        Activity

        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Salesforce Case []
        Component/s Framework [ 10013 ]
        Hide
        Jack Van Ooststroom added a comment -

        Assigning to Mircea for investigation.

        Show
        Jack Van Ooststroom added a comment - Assigning to Mircea for investigation.
        Jack Van Ooststroom made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Mircea Toma made changes -
        Salesforce Case []
        Fix Version/s EE-2.0.0.GA_P01 [ 10271 ]
        Fix Version/s 2.1 [ 10241 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25136 Mon Aug 01 14:15:09 MDT 2011 mircea.toma ICE-7067 Moved the assigning of viewId from the component tree building time to before restore view phase. This way the viewId is available when the PushRenderer.addCurrentView() method is called in a the constructor or the setter of a bean.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25137 Mon Aug 01 14:24:04 MDT 2011 mircea.toma ICE-7067 Moved the assigning of viewId from the component tree building time to before restore view phase. This way the viewId is available when the PushRenderer.addCurrentView() method is called in a the constructor or the setter of a bean.
        Files Changed
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Hide
        Mircea Toma added a comment -

        Moved the assigning of viewId from the component tree building time to before restore view phase. This way the viewId is available when the PushRenderer.addCurrentView() method is called in a the constructor or the setter of a bean.

        Show
        Mircea Toma added a comment - Moved the assigning of viewId from the component tree building time to before restore view phase. This way the viewId is available when the PushRenderer.addCurrentView() method is called in a the constructor or the setter of a bean.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.1-Beta [ 10291 ]
        Fix Version/s 2.1 [ 10241 ]
        Ken Fyten made changes -
        Fix Version/s 3.0 [ 10241 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: