[ICE-7036] icefaces-compat.jar disables default error popup - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0, 2.0.1, EE-2.0.0.GA, 2.0.2
Fix Version/s: 2.1-Beta, 3.0, EE-2.0.0.GA_P01
Component/s: ICE-Components
Labels:
None
Environment:
Mojarra 2.1.2

Assignee Priority:
P2
Workaround Exists:

Yes
Workaround Description:

Hide
If you are unable to use 2.1+, the following patch looks to resolve the issue in 2.0 EE:

/**
* Sets disableDefaultErrorPopups value to the one that was defined in web.xml after each page load.
* The icefaces compat lib is disabling this (see http://jira.icefaces.org/browse/ICE-7036). We need this
* in order to see the session expired popup.
*
* @param {Object} aChildElementIdOfBody an elementid that is a direct child of the body element
*/
applyIceFacesErrorPopupBugWorkaround : function(aChildElementIdOfBody) {
Event.observe(window, 'load', function() {
var container = document.getElementById(aChildElementIdOfBody).parentNode;
container.configuration.disableDefaultErrorPopups = window.ice.disableDefaultErrorPopups;
});
},

Show
If you are unable to use 2.1+, the following patch looks to resolve the issue in 2.0 EE: /** * Sets disableDefaultErrorPopups value to the one that was defined in web.xml after each page load. * The icefaces compat lib is disabling this (see http://jira.icefaces.org/browse/ICE-7036) . We need this * in order to see the session expired popup. * * @param {Object} aChildElementIdOfBody an elementid that is a direct child of the body element */ applyIceFacesErrorPopupBugWorkaround : function(aChildElementIdOfBody) { Event.observe(window, 'load', function() { var container = document.getElementById(aChildElementIdOfBody).parentNode; container.configuration.disableDefaultErrorPopups = window.ice.disableDefaultErrorPopups; }); },

Description

As soon as icefaces-compat.jar is on the classpath the default error popups are disabled. If an exception happens you there's no effect in the browser so one has to check the console output to see that actually something went wrong. Setting org.icefaces.disableDefaultErrorPopups=false in web.xml doesn't have an effect anymore.

icefaces-compat.jar should not modify the default and shouldn't disable org.icefaces.disableDefaultErrorPopups

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
sc10294.war

12/Jul/11 4:29 AM

6.13 MB

Tyler Johnson
META-INF/MANIFEST.MF 0.0 kB

ICEfacesPage1.xhtml 0.7 kB

WEB-INF/classes/.../MyBean.java 0.5 kB

WEB-INF/classes/.../MyBean.class 0.8 kB

WEB-INF/faces-config.xml 0.3 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-ee-compat.jar 2.67 MB

WEB-INF/lib/icefaces-ee.jar 206 kB

WEB-INF/lib/jsf-api-2.1.2.jar 611 kB

WEB-INF/lib/jsf-impl-2.1.2.jar 1.85 MB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/lib/jxl.jar 708 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB

WEB-INF/web.xml 1 kB

index.jsp 0.1 kB

index.xhtml 0.6 kB

resources/prop/fieldset.xhtml 0.6 kB

resources/prop/line.xhtml 0.8 kB

resources/prop/property.xhtml 1 kB

resources/prop/propertyText.xhtml 2 kB

resources/prop/.../propertyTemplate.xhtml 0.5 kB

Download Zip
Show

sc10294.war

12/Jul/11 4:29 AM

6.13 MB

Tyler Johnson
supportErrorPopup.zip

08/Jul/11 9:19 AM

6.13 MB

Adrian Gygax

Activity

Ascending order - Click to sort in descending order

Adrian Gygax created issue - 08/Jul/11 9:16 AM

Hide

Permalink

Adrian Gygax added a comment - 08/Jul/11 9:19 AM

Added example Eclipse project.

Enter some text in the textfield and press the button. In the button's action a RuntimeException is thrown. There's no reaction in the browser but a stacktrace in the console.

Remove icefaces-compat.jar from the lib folder and try again. The error popup appears as expected.

Show

Adrian Gygax added a comment - 08/Jul/11 9:19 AM Added example Eclipse project. Enter some text in the textfield and press the button. In the button's action a RuntimeException is thrown. There's no reaction in the browser but a stacktrace in the console. Remove icefaces-compat.jar from the lib folder and try again. The error popup appears as expected.

Adrian Gygax made changes - 08/Jul/11 9:19 AM

Field	Original Value	New Value
Attachment		supportErrorPopup.zip [ 13348 ]

Tyler Johnson made changes - 12/Jul/11 3:18 AM

Salesforce Case

[5007000000GxgkL]

Tyler Johnson made changes - 12/Jul/11 4:29 AM

Attachment

sc10294.war [ 13351 ]

Hide

Permalink

Tyler Johnson added a comment - 12/Jul/11 4:30 AM

I have also attached a ready to run (Tomcat) war file that reproduces the issue.

Show

Tyler Johnson added a comment - 12/Jul/11 4:30 AM I have also attached a ready to run (Tomcat) war file that reproduces the issue.

Ken Fyten made changes - 14/Jul/11 10:34 AM

Fix Version/s		EE-2.0.0.GA_P01 [ 10271 ]
Fix Version/s		2.1 [ 10241 ]
Assignee Priority		P2
Assignee		Mircea Toma [ mircea.toma ]

Hide

Permalink

Ken Fyten added a comment - 14/Jul/11 10:35 AM

It is expected behaviour that the stock IF 2 error messages are disabled when using compat. However, the compat error dialogs should be appearing (instead), unless the outputConnectionStatus component is used and it is specified to disable the message popups on it, which does not appear to be the case here.

Show

Ken Fyten added a comment - 14/Jul/11 10:35 AM It is expected behaviour that the stock IF 2 error messages are disabled when using compat. However, the compat error dialogs should be appearing (instead), unless the outputConnectionStatus component is used and it is specified to disable the message popups on it, which does not appear to be the case here.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25069	Thu Jul 21 13:48:58 MDT 2011	mircea.toma	~~ICE-7036~~ Replaced no-op indicator with popup indicator for server error responses.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/status.js

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25070	Thu Jul 21 13:53:13 MDT 2011	mircea.toma	~~ICE-7036~~ Replaced the no-op indicator with a popup indicator for server error responses.
				Files Changed
				MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/status.js

Hide

Permalink

Mircea Toma added a comment - 21/Jul/11 3:54 PM

Looks like the for server error indicator in 'compat' was set to a no-op implementation.

Show

Mircea Toma added a comment - 21/Jul/11 3:54 PM Looks like the for server error indicator in 'compat' was set to a no-op implementation.

Hide

Permalink

Mircea Toma added a comment - 21/Jul/11 3:54 PM

Replaced the no-op indicator with a popup indicator for server error responses.

Show

Mircea Toma added a comment - 21/Jul/11 3:54 PM Replaced the no-op indicator with a popup indicator for server error responses.

Mircea Toma made changes - 21/Jul/11 3:54 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 04/Oct/11 3:34 PM

Fix Version/s		2.1-Beta [ 10291 ]
Fix Version/s	2.1 [ 10241 ]

Tyler Johnson made changes - 14/Dec/11 2:14 PM

Workaround Description		If you are unable to use 2.1+, the following patch looks to resolve the issue in 2.0 EE: /** * Sets disableDefaultErrorPopups value to the one that was defined in web.xml after each page load. * The icefaces compat lib is disabling this (see http://jira.icefaces.org/browse/ICE-7036). We need this * in order to see the session expired popup. * * @param {Object} aChildElementIdOfBody an elementid that is a direct child of the body element */ applyIceFacesErrorPopupBugWorkaround : function(aChildElementIdOfBody) { Event.observe(window, 'load', function() { var container = document.getElementById(aChildElementIdOfBody).parentNode; container.configuration.disableDefaultErrorPopups = window.ice.disableDefaultErrorPopups; }); },
Workaround Exists		[Yes]

Ken Fyten made changes - 06/Feb/12 1:32 PM

Fix Version/s

3.0 [ 10241 ]

Ken Fyten made changes - 17/Feb/12 6:16 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Adrian Gygax

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

08/Jul/11 9:16 AM

Updated:

17/Feb/12 6:16 PM

Resolved:

21/Jul/11 3:54 PM