ICEfaces
  1. ICEfaces
  2. ICE-7019

panelTabSet partialSubmit=false does not change tabs in Firefox

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, EE-2.0.0.GA, 2.0.2
    • Fix Version/s: 3.0, EE-2.0.0.GA_P01
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Firefox, ICEfaces 2
    • Assignee Priority:
      P1

      Description

      When using partialSubmit="false" on the panelTabSet this allows the tabs content to execute the required validation. When testing this in Firefox with ICEfaces 2 the tab change does not occur and an error is reported in the Firebug console. Testing in IE this seems to work without any issues.

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Attachment firefox-error.JPG [ 13342 ]
        Attachment Case10282Example.war [ 13343 ]
        Arran Mccullough made changes -
        Salesforce Case [5007000000GxY7z]
        Arran Mccullough made changes -
        Environment Firefox Firefox, ICEfaces 2
        Ken Fyten made changes -
        Fix Version/s EE-2.0.0.GA_P01 [ 10271 ]
        Fix Version/s 2.1 [ 10241 ]
        Assignee Priority P1
        Assignee Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25029 Thu Jul 14 08:01:33 MDT 2011 mircea.toma ICE-7019 Modified event handler code to pass on the event object when invoking 'onclick' handler.
        Files Changed
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25030 Thu Jul 14 08:02:33 MDT 2011 mircea.toma ICE-7019 Modified event handler code to pass on the event object when invoking 'onclick' handler.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Hide
        Mircea Toma added a comment -

        In Firefox the event object is passed in as parameter to the registered event handler while in IE the event object is a global variable. The issue occurs when the event handler registered on the tab element is invoking the 'onclick' handler without any parameters, that works fine in IE but in FF iceSubmit() function is missing the event object since it should have been passed on when the handler was invoked.

        Show
        Mircea Toma added a comment - In Firefox the event object is passed in as parameter to the registered event handler while in IE the event object is a global variable. The issue occurs when the event handler registered on the tab element is invoking the 'onclick' handler without any parameters, that works fine in IE but in FF iceSubmit() function is missing the event object since it should have been passed on when the handler was invoked.
        Hide
        Mircea Toma added a comment -

        Modified event handler code rendered by PanelTabSetRenderer to pass on the event object when invoking 'onclick' handler.

        Show
        Mircea Toma added a comment - Modified event handler code rendered by PanelTabSetRenderer to pass on the event object when invoking 'onclick' handler.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Carmen Cristurean made changes -
        Assignee Mircea Toma [ mircea.toma ] Carmen Cristurean [ ccristurean ]
        Hide
        Carmen Cristurean added a comment -

        Tested successfully on ICEfaces2.1 trunk revision #25049, using Tomcat6 and Firefox 3.6.

        Show
        Carmen Cristurean added a comment - Tested successfully on ICEfaces2.1 trunk revision #25049, using Tomcat6 and Firefox 3.6.
        Carmen Cristurean made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Carmen Cristurean
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: