Details
New Feature
Major
Description
The DOM diff algorithm can benefit from integrated "ancestor pruning" and incorporation of insert and delete features.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Insert/Delete will be conditionally enabled by components once jsf-impl is updated to include fixes for HTML table insertion.
Includes ideas from work by Mark and Greg in ICE-6591 and ICE-6565.
in core:
ant -f test.xml
[junit] Running org.icefaces.domDiff.DomDiffTest
[junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.465 sec
Have we covered the base case, where something near the top of the dom tree causes a diff of the Document? If at the top level an Element causes a return false from compareNodes
, then there's no code to catch that and return the whole Document.
Good point; the top level return value of compareNodes() should not have been ignored. This case is now being logged at severe level: "Diff propagated to root but no ID set". If the top level nodes have IDs, then they will generate the needed ReplaceOperation. If they do not have IDs, then nothing can be done and the condition is logged (proceeding with the other edit operations otherwise obtained). Note that <html> and <body> will typically have IDs due to code in DOMPartialViewContext. In the case of a subtree diff, an ID will typically be present since the component has specified the subtree render by ID (however it is possible that a component bug would produce a case where the ID was missing).
Pruning is now integrated with the DOM diff recursion.
Integrated ancestor pruning can be tested with assertions enabled as a JVM flag or :
-ea:org.icefaces...
export CATALINA_OPTS="-ea:org.icefaces..."