[ICE-6986] Regression: Errors on IE when closing browser after panelTooltip is shown - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-2.0.0.GA, 2.0.2, EE-1.8.2.GA_P03
Fix Version/s: 2.1-Beta, 3.0, EE-1.8.2.GA_P04, EE-2.0.0.GA_P01
Component/s: ICE-Components
Labels:
None
Environment:
IE7/8

Assignee Priority:
P1

Description

An error, Stack overflow in IE7 or Out of Memory in IE8, is shown when the browser window is closed after a panelTooltip that uses hideOn="none" is shown. This doesn't seem to be a JavaScript error and there is no stack trace shown in the server logs. These errors are only seen with the ICEfaces EE 1.8.2 P03 release. Other releases are working fine.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case10256Example.war

28/Jun/11 2:22 PM

6.63 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Item.class 1 kB

WEB-INF/classes/.../example/TestBean.class 1 kB

WEB-INF/faces-config.xml 0.7 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-lang.jar 240 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.75 MB

WEB-INF/lib/icefaces-facelets.jar 596 kB

WEB-INF/lib/icefaces.jar 1.22 MB

WEB-INF/lib/jsf-api-1.2.jar 355 kB

WEB-INF/lib/jsf-impl-1.2.jar 837 kB

WEB-INF/web.xml 4 kB

plainPage.xhtml 2 kB

welcomeICEfaces.xhtml 3 kB

Download Zip
Show

Case10256Example.war

28/Jun/11 2:22 PM

6.63 MB

Arran Mccullough

outofmemoryIE8.JPG

7 kB

28/Jun/11 2:22 PM
stackoverflowIE7.JPG

7 kB

28/Jun/11 2:22 PM

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 28/Jun/11 2:18 PM

Hide

Permalink

Arran Mccullough added a comment - 28/Jun/11 2:22 PM

Attached screen shots of errors and test case. The test case has two pages, plainPage.xhtml will reproduce the error.

Steps to reproduce issue:

Load test case.
Hover over the blue box, a tooltip is shown.
Close browser, error is shown.

It doesn't seem to matter if the tooltip is closed or open, it throws the error after its been shown.

Show

Arran Mccullough added a comment - 28/Jun/11 2:22 PM Attached screen shots of errors and test case. The test case has two pages, plainPage.xhtml will reproduce the error. Steps to reproduce issue: Load test case. Hover over the blue box, a tooltip is shown. Close browser, error is shown. It doesn't seem to matter if the tooltip is closed or open, it throws the error after its been shown.

Arran Mccullough made changes - 28/Jun/11 2:22 PM

Field	Original Value	New Value
Attachment		outofmemoryIE8.JPG [ 13327 ]
Attachment		stackoverflowIE7.JPG [ 13328 ]
Attachment		Case10256Example.war [ 13329 ]

Hide

Permalink

Arran Mccullough added a comment - 28/Jun/11 2:24 PM

Using hideOn="mouseout" seems to work fine.

Show

Arran Mccullough added a comment - 28/Jun/11 2:24 PM Using hideOn="mouseout" seems to work fine.

Arran Mccullough made changes - 28/Jun/11 2:24 PM

Salesforce Case

[5007000000Gx82G]

Ken Fyten made changes - 29/Jun/11 2:47 PM

Summary	Errors on IE when closing browser after panelTooltip is shown	Regression: Errors on IE when closing browser after panelTooltip is shown
Fix Version/s		EE-1.8.2.GA_P04 [ 10280 ]
Assignee Priority		P1
Assignee		Mircea Toma [ mircea.toma ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#24980	Fri Jul 08 07:28:14 MDT 2011	mircea.toma	~~ICE-6986~~ Associate no-op handler when using 'none' tooltip configuration to conform to the type of tests Prototype 1.7 is using in Event.stopObserving function.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/tooltip_panelpopup.js

Hide

Permalink

Mircea Toma added a comment - 08/Jul/11 9:31 AM

The new Prototype 1.7 library seems to be using a simplified test for the existence of the event handlers in Event.stopObserving function:
Prototype 1.6.* -> if (Object.isUndefined(handler)) { ...
Prototype 1.7 -> if (!handler) { ...

When this function is called on page unload to clear the cached handlers (PrototypeJS code) it calls itself recursively when invoked without parameters. The stack overflow occurs when the handler passed in, when Event.observe method is invoked by the tooltip JS code, is the empty string. Event.stopObserving will evaluate it to false and go into an infinite recursive loop.

Show

Mircea Toma added a comment - 08/Jul/11 9:31 AM The new Prototype 1.7 library seems to be using a simplified test for the existence of the event handlers in Event.stopObserving function: Prototype 1.6.* -> if (Object.isUndefined(handler)) { ... Prototype 1.7 -> if (!handler) { ... When this function is called on page unload to clear the cached handlers (PrototypeJS code) it calls itself recursively when invoked without parameters. The stack overflow occurs when the handler passed in, when Event.observe method is invoked by the tooltip JS code, is the empty string. Event.stopObserving will evaluate it to false and go into an infinite recursive loop.

Hide

Permalink

Mircea Toma added a comment - 08/Jul/11 9:34 AM

The fix modifies tooltip JS code to associate a no-op handler instead of '' when using 'none' tooltip configuration to conform to the type of tests Prototype 1.7 is using in Event.stopObserving function.

Show

Mircea Toma added a comment - 08/Jul/11 9:34 AM The fix modifies tooltip JS code to associate a no-op handler instead of '' when using 'none' tooltip configuration to conform to the type of tests Prototype 1.7 is using in Event.stopObserving function.

Mircea Toma made changes - 08/Jul/11 9:34 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Ken Fyten added a comment - 12/Jul/11 4:46 PM

Adding icefaces 2 targets.

Show

Ken Fyten added a comment - 12/Jul/11 4:46 PM Adding icefaces 2 targets.

Ken Fyten made changes - 12/Jul/11 4:46 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Ken Fyten made changes - 12/Jul/11 4:47 PM

Fix Version/s		EE-2.0.0.GA_P01 [ 10271 ]
Fix Version/s		2.1 [ 10241 ]
Affects Version/s		2.0.2 [ 10273 ]
Affects Version/s		EE-2.0.0.GA [ 10263 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25027	Wed Jul 13 15:20:26 MDT 2011	mircea.toma	~~ICE-6986~~ Associate no-op handler when using 'none' tooltip configuration to conform to the type of tests Prototype 1.7 is using in Event.stopObserving function.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25028	Wed Jul 13 15:24:41 MDT 2011	mircea.toma	~~ICE-6986~~ Associate no-op handler when using 'none' tooltip configuration to conform to the type of tests Prototype 1.7 is using in Event.stopObserving function.
				Files Changed
				MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js

Hide

Permalink

Mircea Toma added a comment - 13/Jul/11 5:26 PM

Applied fix to ICEfaces 2 trunk and maintenance branch.

Show

Mircea Toma added a comment - 13/Jul/11 5:26 PM Applied fix to ICEfaces 2 trunk and maintenance branch.

Mircea Toma made changes - 13/Jul/11 5:26 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 04/Oct/11 3:35 PM

Fix Version/s

2.1-Beta [ 10291 ]

Ken Fyten made changes - 17/Feb/12 6:16 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

28/Jun/11 2:18 PM

Updated:

17/Feb/12 6:16 PM

Resolved:

13/Jul/11 5:26 PM