ICEfaces
  1. ICEfaces
  2. ICE-6950

detect custom update processing

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces, 3rd party component with custom update
    • Affects:
      Compatibility/Configuration

      Description

      A variety of components handle the partial response <update> in a specific way, for instance autocomplete has a custom onsuccess handler that decodes JSON from the response (rather than markup as is typical in an <update>).

      It would be possible for such components to flag these requests in a common way, such as by adding a request parameter. DOMPartialViewContext could then detect this parameter and avoid subtree DOM output and diff.

        Activity

        Ted Goddard created issue -
        Ted Goddard made changes -
        Field Original Value New Value
        Assignee Ted Goddard [ ted.goddard ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.1 [ 10241 ]
        Affects Version/s 2.0.2 [ 10273 ]
        Hide
        Ted Goddard added a comment -

        The JavaScript that invokes custom update processing should set a request parameter org.icefaces.customUpdate=true. When this is detected by DOMPartialViewContext, the DOM diff would not run for that subtree.

        Show
        Ted Goddard added a comment - The JavaScript that invokes custom update processing should set a request parameter org.icefaces.customUpdate=true. When this is detected by DOMPartialViewContext, the DOM diff would not run for that subtree.
        Hide
        Ted Goddard added a comment -

        Assigning to Ken to dispatch for grimlock implementation.

        Show
        Ted Goddard added a comment - Assigning to Ken to dispatch for grimlock implementation.
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1
        Assignee Ken Fyten [ ken.fyten ] Jack van Ooststroom [ jack.van.ooststroom ]
        Ken Fyten made changes -
        Salesforce Case []
        Security Private [ 10001 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24885 Thu Jun 23 12:22:53 MDT 2011 jack.van.ooststroom Fixed JIRA ICE-6950
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Hide
        Jack Van Ooststroom added a comment -

        I introduced a new POST request parameter named "ice.customUpdate" which can be used identify a custom update. This is handled by the DOMPartialViewContext. The "org.icefaces.subtreeDiff" context parameter can still be used for application wide configuration. However "ice.customUpdate" can be used on a per component base.

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - I introduced a new POST request parameter named "ice.customUpdate" which can be used identify a custom update. This is handled by the DOMPartialViewContext. The "org.icefaces.subtreeDiff" context parameter can still be used for application wide configuration. However "ice.customUpdate" can be used on a per component base. Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mark Collette made changes -
        Link This issue blocks ICE-7034 [ ICE-7034 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25138 Mon Aug 01 14:59:20 MDT 2011 ted.goddard allowing mixed subtrees for customUpdate responses (ICE-6950)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Hide
        Ted Goddard added a comment -

        Prototype is checked in for non-markup responses (ice.customUpdate) but not tested. Further instructions or a test case are required from the component team.

        Show
        Ted Goddard added a comment - Prototype is checked in for non-markup responses (ice.customUpdate) but not tested. Further instructions or a test case are required from the component team.
        Ted Goddard made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Jack van Ooststroom [ jack.van.ooststroom ] Ken Fyten [ ken.fyten ]
        Hide
        Nils Lundquist added a comment -

        Custom updating for specified clientIds added in revision 24145.

        Show
        Nils Lundquist added a comment - Custom updating for specified clientIds added in revision 24145.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #25211 Mon Aug 08 12:46:38 MDT 2011 ted.goddard sending non-DOM subtree rendering to BasicResponseWriter (ICE-6950)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Hide
        Ted Goddard added a comment -

        DOM updates in customer POC look reasonable.

        Show
        Ted Goddard added a comment - DOM updates in customer POC look reasonable.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Affects [Compatibility/Configuration]
        Assignee Priority P1
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.1-Beta [ 10291 ]
        Ken Fyten made changes -
        Salesforce Case []
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ken Fyten
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: