ICEfaces
  1. ICEfaces
  2. ICE-6890

selectInputText rows=0 should display all in popup list instead of none

    Details

      Description

      According to TLD doc for rows attribute: "If this value is set to zero, all available rows in the underlying data model will be displayed." Seems there is a bug. Zero rows will display nothing.

        Activity

        yip.ng created issue -
        yip.ng made changes -
        Field Original Value New Value
        Assignee yip.ng [ yip.ng ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24632 Fri May 20 09:46:03 MDT 2011 yip.ng ICE-6890: selectInputText rows=0 should display all in popup list instead of none.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24633 Fri May 20 09:50:40 MDT 2011 yip.ng ICE-6890: selectInputText rows=0 should display all in popup list instead of none.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
        Hide
        yip.ng added a comment - - edited

        Done. "while" condition simplified and sped up as well. Also, wrong spelling of variable names corrected.

        Note that when the popup list is dynamically provided by the user, "all rows" means all matched rows provided by the user, not all rows in the original data list.

        Revision: 24632


        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

        Revision: 24633


        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

        Revision: 24642


        Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

        Show
        yip.ng added a comment - - edited Done. "while" condition simplified and sped up as well. Also, wrong spelling of variable names corrected. Note that when the popup list is dynamically provided by the user, "all rows" means all matched rows provided by the user, not all rows in the original data list. Revision: 24632 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Revision: 24633 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Revision: 24642 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24642 Fri May 20 12:55:00 MDT 2011 yip.ng ICE-6890: selectInputText rows=0 should display all in popup list instead of none.
        Files Changed
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s EE-1.8.2.GA_P03 [ 10251 ]
        Fix Version/s EE-2.0.0.GA_P01 [ 10271 ]
        Fix Version/s 2.1 [ 10241 ]
        Ken Fyten made changes -
        Fix Version/s 2.1-Beta [ 10291 ]
        Fix Version/s 2.1 [ 10241 ]
        Ken Fyten made changes -
        Fix Version/s 3.0 [ 10241 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            yip.ng
            Reporter:
            yip.ng
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: