ICEfaces
  1. ICEfaces
  2. ICE-6889

Update Prototype library to 1.7, and Scriptaculous to 1.9 releases (for IE 9 support)

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2-EE-GA_P02
          • Fix Version/s: EE-1.8.2.GA_P03
          • Component/s: Bridge, ICE-Components
          • Labels:
            None
          • Environment:
            ICEfaces EE 1.8.2.GA_P03
          • Affects:
            Compatibility/Configuration

            Description

            In order to resolve issues related to Prototype Drag & Drop functions not working correctly with IE 9, we need to update to the latest version (1.7).

            http://www.prototypejs.org/download

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Environment ICEfaces 2.0.0, IE9 ICEfaces EE 1.8.2.GA_P03
              Salesforce Case []
              Component/s Bridge [ 10011 ]
              Fix Version/s EE-1.8.2.GA_P03 [ 10251 ]
              Fix Version/s 2.0.1 [ 10255 ]
              Assignee Priority P1
              Affects Version/s 1.8.2-EE-GA_P02 [ 10226 ]
              Affects Version/s 2.0.0 [ 10230 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24634 Fri May 20 12:24:11 MDT 2011 mircea.toma ICE-6889 Update prototype code to version 1.7. Collated code found in 'dom', 'lang' and 'ajax' directories it their corresponding master files.
              Files Changed
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/form.js
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/deprecated.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/selector.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/array.js
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/dom.js
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/prototype.js
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/build.xml
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/base.js
              Commit graph ADD /icefaces/trunk/icefaces/bridge/lib/prototype/lang.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/enumerable.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/hash.js
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/ajax.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/event.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/string.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/range.js
              Commit graph DEL /icefaces/trunk/icefaces/bridge/lib/prototype/number.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Updated prototype code to version 1.7. Collated code found in 'dom', 'lang' and 'ajax' directories in their corresponding master files.

              Show
              Mircea Toma added a comment - Updated prototype code to version 1.7. Collated code found in 'dom', 'lang' and 'ajax' directories in their corresponding master files.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              It seems that this change may be responsible for a set of regressions:

              New regression test failures detected on icefaces1.8 trunk revision# 24679
              Server: tomcat6
              Browser: FF3.6, IE8 & GoogleChrome10:

              1. ICE-3290 - modal popup screen expanding problem (all browsers)
              2. ICE-2722 on IE: the panel popup auto positions itself after drag n drop.

              Last tested/known working revision was #24605 / May 17th.

              Show
              Ken Fyten added a comment - It seems that this change may be responsible for a set of regressions: New regression test failures detected on icefaces1.8 trunk revision# 24679 Server: tomcat6 Browser: FF3.6, IE8 & GoogleChrome10: 1. ICE-3290 - modal popup screen expanding problem (all browsers) 2. ICE-2722 on IE: the panel popup auto positions itself after drag n drop. Last tested/known working revision was #24605 / May 17th.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Prototype 1.7 upgrade causing regression failures with the Draggable Tree Table EE Composite Comp.

              Show
              Ken Fyten added a comment - Prototype 1.7 upgrade causing regression failures with the Draggable Tree Table EE Composite Comp.
              Ken Fyten made changes -
              Link This issue blocks ICE-6907 [ ICE-6907 ]
              Ken Fyten made changes -
              Link This issue blocks ICE-6908 [ ICE-6908 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24717 Fri May 27 09:12:49 MDT 2011 mircea.toma ICE-6889 Re-apply viewport calculation fixes introduced for ICE-3308.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/dom.js
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Re-applied viewport calculation changes introduced for ICE-3308. This fixes ICE-2722 regression.

              Show
              Mircea Toma added a comment - - edited Re-applied viewport calculation changes introduced for ICE-3308 . This fixes ICE-2722 regression.
              Hide
              Permalink
              Mircea Toma added a comment -

              Updated Scriptaculous code to version 1.9 to resolve the incompatibilities between 1.8.* version and the new Prototype 1.7 code.

              Show
              Mircea Toma added a comment - Updated Scriptaculous code to version 1.9 to resolve the incompatibilities between 1.8.* version and the new Prototype 1.7 code.
              Ken Fyten made changes -
              Summary Update Prototype library to 1.7 release (for IE 9 support) Update Prototype library to 1.7, and Scriptaculous to 1.9 releases (for IE 9 support)
              Salesforce Case []
              Ken Fyten made changes -
              Issue Type Task [ 3 ] Improvement [ 4 ]
              Salesforce Case []
              Hide
              Permalink
              Ken Fyten added a comment -

              Note that QA reports that 1. ICE-3290 - modal popup screen expanding problem (all browsers) is still failing with Scriptaculous 1.9. The issue is that the background blocking div grows incrementally, and the panelPopup moves around slightly (autocentred?) as a result.

              Show
              Ken Fyten added a comment - Note that QA reports that 1. ICE-3290 - modal popup screen expanding problem (all browsers) is still failing with Scriptaculous 1.9. The issue is that the background blocking div grows incrementally, and the panelPopup moves around slightly (autocentred?) as a result.
              Hide
              Permalink
              Mandeep Hayher added a comment -

              ICE-3290 test case and test script are available at '\svn\repo\qa\trunk\Regression\Nightly\ICE-3290'.

              Show
              Mandeep Hayher added a comment - ICE-3290 test case and test script are available at '\svn\repo\qa\trunk\Regression\Nightly\ ICE-3290 '.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24726 Mon May 30 13:35:22 MDT 2011 mircea.toma ICE-6889 Stop overriding Element.viewportOffset function even if the browser supports getBoundingClientRect() function.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/dom.js
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              In IE and FF Prototype overrides the default implementation of the Element.viewportOffset function to use the native HTMLElement.getBoundingClientRect(), most probably for increase performance. Unfortunately the overriding function doesn't give the same results as the default implementation.

              The fix for ICE-3290 regression removed the overriding of the Element.viewportOffset function even in browsers that do support the getBoundingClientRect() function.

              Show
              Mircea Toma added a comment - - edited In IE and FF Prototype overrides the default implementation of the Element.viewportOffset function to use the native HTMLElement.getBoundingClientRect(), most probably for increase performance. Unfortunately the overriding function doesn't give the same results as the default implementation. The fix for ICE-3290 regression removed the overriding of the Element.viewportOffset function even in browsers that do support the getBoundingClientRect() function.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: