Should investigate if the new isDisconnected() code could replace the phase specific checks.

ICE-7321 inspired an idea that we could take what we added there, for detecting that a new MenuItem was having its properties set in bean code and know to set them in the section that applies to every row, and use that solely for .xhtml view construction, instead of using the phase heuristics.

To test this, I added an ACE checkboxButton to a dataTable, and modified the CheckboxButtonRenderer so that when the value was true, it would could setStyle() on the component, during rendering. I was able to duplicate the error, where the CheckboxButtonBase.setStyle() code would set the new style value into the place for every row instead of just for the current row, because of the simplicity of the check for being in RenderView phase, as the heuristic for component tree construction. I then debugged what the value of isDisconnected() was, and found that in view construction for both RestoreView and RenderView, it was true, but was false when simply rendering and hitting my set of the style. Perfect. So, after removing the phase code, and fully relying on isDisconnected(), I verified that my test set of the style only went to the row specific part, and my updates after clicking the checkboxButton were now localised to just that one row, since it was no longer modifying the value for all rows.

Development branch
Subversion 26338
icefaces2/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java

For testing, had this in ComponentArtifact, where it sets a property:

writer.append("\n\t\t\tPhaseId pi = getFacesContext().getCurrentPhaseId();");
writer.append("\n\t\t\tStateHelper sh = getStateHelper(); ");
writer.append("\n\t\t\tif (isDisconnected(this)) {");
writer.append("\nSystem.out.println(\"comp: \" + getClientId() + \" setter: "field.getName()" value: \" + "field.getName()" + \" phase: \" + pi + \" disconnected: \" + isDisconnected(this));");

Had this in CheckBoxRenderer.encodeBegin():
Object val = checkbox.getValue();
if (val != null && (val instanceof Boolean) && ((Boolean)val).booleanValue())

Had this in comp-suite:

src/main/webapp/resources/examples/compat/dataTable/dataTable.xhtml
<ice:column>
<f:facet name="header">
ACE Button
</f:facet>
<ace:checkboxButton id="mark_cb" label="Mark CB" value="#

" singleSubmit="true"/>
</ice:column>

src/main/java/org/icefaces/samples/showcase/example/compat/dataTable/Car.java
protected boolean markBoolean;
public boolean isMarkBoolean()

public void setMarkBoolean(boolean mb)