Details
Bug
Description
MyFaces calls #cloneWithWriter using its StateWriter, which goes through some acrobatics, the upshot of which is that DOMResponseWriter#startElement is called sometime after DOMResponseWriter#endDocument. #startElement appropriately creates a new Document if its document reference is null, then calls #appendToCursor which, finding that the cursor instance variable is null, assigns that to document.getDocumentElement(). Unfortunately the Document, having just been instantiated, has no document element. What seems like the obvious way to address this issue is to re-check the cursor, i.e.:
if (cursor == null) {
cursor = document.getDocumentElement();
+ if (cursor == null) {
+ cursor = document;
+ }
}
This may be naively missing something; WDYT?
if (cursor == null) {
cursor = document.getDocumentElement();
+ if (cursor == null) {
+ cursor = document;
+ }
}
This may be naively missing something; WDYT?
Issue Links
- depends on
-
ICE-5868
MyFaces 2 compatibility
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | icefacesNPE.tar.gz [ 13223 ] |
Also, I should mention that the bug doesn't trigger right away. I came across it when I went to the index.jsf page of the app, then clicked the "Press Me" button multiple times without doing anything else.
Show
Matt Benson
added a comment - Also, I should mention that the bug doesn't trigger right away. I came across it when I went to the index.jsf page of the app, then clicked the "Press Me" button multiple times without doing anything else.
| Assignee | Deryk Sinotte [ deryk.sinotte ] |
| Salesforce Case | [] | |
| Component/s | Framework [ 10013 ] | |
| Fix Version/s | 2.1 [ 10241 ] | |
| Affects Version/s | 2.0.1 [ 10255 ] |
| Salesforce Case | [] | |
| Assignee Priority | P3 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #25118 | Wed Jul 27 14:27:34 MDT 2011 | deryk.sinotte | |
| Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
|
I did see this issue a couple of times but wasn't able to produce it reliably. I've added the additional null check as precaution.
Show
Deryk Sinotte
added a comment - I did see this issue a couple of times but wasn't able to produce it reliably. I've added the additional null check as precaution.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 2.1-Beta [ 10291 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
The attached archive contains a Maven-based project that wherein the described NPE is exhibited. Note that I have the Apache snapshot repo enabled in my local Maven settings:
<profile>
<id>apache-snapshots</id>
<repositories>
<repository>
<id>apache-snapshots</id>
<name>Apache Snapshot Repository</name>
<url>https://repository.apache.org/content/groups/snapshots-group/</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
</repositories>
</profile>
</profiles>
<activeProfiles>
<activeProfile>apache-snapshots</activeProfile>
</activeProfiles>
Thanks!