ICEfaces
  1. ICEfaces
  2. ICE-6860

Refactor node lookup in animation Javascript code

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0, 2.0.1, EE-2.0.0.GA
          • Fix Version/s: 2.1-Beta, 3.0, EE-2.0.0.GA_P01
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            any

            Description

            Motivated by portlets support, the default Y.one() function was overridden to escape ':'s in the IDs passed to it. This didn't completely work in some cases, and it could cause problems if IDs are escaped again at different points in the code. A better approach would be to get the DOM elements via document.getElementById() and pass the element to Y.one() to avoid problems with IDs that contain ':'s. This practice needs to be consistent throughout the animation code to make the code less confusing and less error-prone.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24581 Mon May 16 12:09:03 MDT 2011 art.zambrano ICE-6860 Refactor node lookup in animation Javascript code (2.0 trunk)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.util/component.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.animation/animation.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24574 Fri May 13 17:06:42 MDT 2011 art.zambrano ICE-6860 Refactor node lookup in animation Javascript code
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/resources/org.icefaces.component.util/component.js
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/resources/org.icefaces.component.animation/animation.js

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: