ICEfaces
  1. ICEfaces
  2. ICE-6845

Modify ICEpushResourceHandler to use extension mechanism to load the MainServlet

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.1, EE-2.0.0.GA
          • Fix Version/s: 2.1-Beta, 3.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            JSF

            Description

            Modify ICEpushResourceHandler to use the extension mechanism (ExtensionRegistry) to load the MainServlet either from ICEpush or MOBI depending on what is available in the classpath.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24478 Thu May 05 06:28:36 MDT 2011 mircea.toma ICE-6845 Use ExtensionRegistry to load the correct MainServlet. Delay MAinServlet instantiation to allow for the extensions to register during context startup. Lookup PushContext on each PortableRenderer.push call to avoid NPEs during startup. Updated ICepush library to revision 24319.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/samples/compat/component-showcase/src/main/webapp/WEB-INF/web.xml
              Commit graph MODIFY /icefaces2/trunk/icefaces/lib/icepush.jar
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java
              Mircea Toma created issue -
              Hide
              Permalink
              Mircea Toma added a comment -

              Used ExtensionRegistry to load the correct MainServlet. Delayed MAinServlet instantiation to allow for the extensions to register during context startup. Lookup PushContext on each PortableRenderer.push call to avoid NPEs during startup. Updated ICepush library to revision 24319.

              Show
              Mircea Toma added a comment - Used ExtensionRegistry to load the correct MainServlet. Delayed MAinServlet instantiation to allow for the extensions to register during context startup. Lookup PushContext on each PortableRenderer.push call to avoid NPEs during startup. Updated ICepush library to revision 24319.
              Mircea Toma made changes -
              Field Original Value New Value
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 2.1 [ 10241 ]
              Resolution Fixed [ 1 ]
              Mircea Toma made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Mircea Toma made changes -
              Link This issue blocks MOBI-17 [ MOBI-17 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24522 Tue May 10 02:03:09 MDT 2011 mircea.toma ICE-6845 Changed MainServlet initialization to be performed before 'restore view' phase instead of before 'render view' phase to avoid NPEs during application startup.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
              Hide
              Permalink
              Mircea Toma added a comment -

              NPE is triggered during application startup because ICEpushResourceHandler tries to access the PushContext during 'restore view' phase but PushContext is initialized only before 'render view' phase.

              The fix changes MainServlet initialization to be performed before 'restore view' phase instead of before 'render view' phase.

              Show
              Mircea Toma added a comment - NPE is triggered during application startup because ICEpushResourceHandler tries to access the PushContext during 'restore view' phase but PushContext is initialized only before 'render view' phase. The fix changes MainServlet initialization to be performed before 'restore view' phase instead of before 'render view' phase.
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta [ 10291 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: