[ICE-6835] 2.0 compat selectInputText will not work when nested comps have JS events - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.1, EE-2.0.0.GA
Fix Version/s: 2.1-Beta, 3.0, EE-2.0.0.GA_P01
Component/s: ICE-Components
Labels:
None
Environment:
-

Assignee Priority:
P1

Description

If you add a javascript event to a nested component (ex. outputText), the selectInputText will not render it´s drop down list and the attached malformed XML exception will be thrown. Here is an example:

<ice:selectInputText>
<f:facet name="selectInputText">
<ice:panelGrid columns="1">
<ice:outputText onclick="alert('test');" id="AutoCmpSt" value="#{city.state}" />
</ice:panelGrid>
</f:facet>
</ice:selectInputText>

This is not an issue in 1.8.2 P02.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
sc10064.war

02/May/11 3:42 PM

8.95 MB

Tyler Johnson
META-INF/MANIFEST.MF 0.0 kB

.DS_Store 6 kB

WEB-INF/classes/BaseBean.java 4 kB

WEB-INF/classes/City.java 3 kB

WEB-INF/classes/CityDictionary.java 8 kB

WEB-INF/classes/MessageBundleLoader.java 3 kB

WEB-INF/.../SelectInputTextController.java 6 kB

WEB-INF/classes/.DS_Store 6 kB

WEB-INF/classes/BaseBean.class 3 kB

WEB-INF/classes/City.class 2 kB

WEB-INF/classes/CityDictionary$1.class 0.8 kB

WEB-INF/classes/CityDictionary.class 4 kB

WEB-INF/.../MessageBundleLoader.class 2 kB

WEB-INF/.../SelectInputTextController.class 4 kB

WEB-INF/classes/messages_en.properties 48 kB

WEB-INF/faces-config.xml 0.6 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-ee-composite.jar 357 kB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/lib/jxl.jar 708 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB

WEB-INF/lib/jsf-api.jar 593 kB

WEB-INF/lib/jsf-impl.jar 1.78 MB

WEB-INF/lib/icefaces-ee-ext.jar 56 kB

WEB-INF/lib/icefaces-ee.jar 206 kB

WEB-INF/lib/icefaces-ee-compat.jar 2.67 MB

WEB-INF/lib/icefaces-ee-ace.jar 2.39 MB

Showing 30 of 65 items Download Zip
Show

sc10064.war

02/May/11 3:42 PM

8.95 MB

Tyler Johnson

Firebug_console_2.0.jpg

209 kB

02/May/11 3:39 PM
screenshot-02.png

213 kB

30/May/11 12:12 PM
screenshot-03.png

224 kB

30/May/11 2:17 PM

Activity

Ascending order - Click to sort in descending order

Tyler Johnson created issue - 02/May/11 3:38 PM

Tyler Johnson made changes - 02/May/11 3:39 PM

Field	Original Value	New Value
Attachment		Firebug_console_2.0.jpg [ 13178 ]

Hide

Permalink

Tyler Johnson added a comment - 02/May/11 3:42 PM

Test case attached. Intended for deployment on Tomcat 6.

Show

Tyler Johnson added a comment - 02/May/11 3:42 PM Test case attached. Intended for deployment on Tomcat 6.

Tyler Johnson made changes - 02/May/11 3:42 PM

Attachment

sc10064.war [ 13179 ]

Ken Fyten made changes - 04/May/11 10:22 AM

Salesforce Case		[]
Fix Version/s		2.0.2 [ 10273 ]
Fix Version/s		EE-2.0.0.GA_P01 [ 10271 ]

Ken Fyten made changes - 05/May/11 1:02 PM

Salesforce Case		[]
Fix Version/s		2.1 [ 10241 ]
Fix Version/s	2.0.2 [ 10273 ]
Affects Version/s		2.0.1 [ 10255 ]

Hide

Permalink

Maxim Zaritsky added a comment - 23/May/11 2:25 PM

Do we have any estimate on fixing this Bug?

Show

Maxim Zaritsky added a comment - 23/May/11 2:25 PM Do we have any estimate on fixing this Bug?

Ken Fyten made changes - 25/May/11 4:12 PM

Salesforce Case		[]
Assignee Priority		P1
Assignee		yip.ng [ yip.ng ]

yip.ng made changes - 30/May/11 12:12 PM

Attachment

screenshot-02.png [ 13271 ]

Hide

Permalink

yip.ng added a comment - 30/May/11 12:13 PM - edited

Tried displaying the response body in the browser and there was no error. See screenshot 2. So the malformed XML error must be caused by something else?

Show

yip.ng added a comment - 30/May/11 12:13 PM - edited Tried displaying the response body in the browser and there was no error. See screenshot 2. So the malformed XML error must be caused by something else?

yip.ng made changes - 30/May/11 2:17 PM

Attachment

screenshot-03.png [ 13272 ]

Hide

Permalink

yip.ng added a comment - 30/May/11 2:22 PM - edited

onclick attribute is rendered by PassThruAttributeWriter. PassThruAttributeWriter is exactly the same in ICEfaces 1.8 and ICEfaces 2. Yet the single quote in the onclick attribute value is escaped in 1.8 but not in 2. Why?

Show

yip.ng added a comment - 30/May/11 2:22 PM - edited onclick attribute is rendered by PassThruAttributeWriter. PassThruAttributeWriter is exactly the same in ICEfaces 1.8 and ICEfaces 2. Yet the single quote in the onclick attribute value is escaped in 1.8 but not in 2. Why?

Hide

Permalink

yip.ng added a comment - 30/May/11 4:45 PM

This is caused by changes in ~~ICE-5551~~. org.icefaces.impl.util.DOMUtils#escapeAttribute was added to replace org.icefaces.impl.util.DOMUtils#escapeAnsi. In escapeAttribute() the single quote character was purposely removed from the list of characters to be escaped. Put it back in? Would it cause problems for other calls (many indirectly) to the function?

Show

yip.ng added a comment - 30/May/11 4:45 PM This is caused by changes in ICE-5551 . org.icefaces.impl.util.DOMUtils#escapeAttribute was added to replace org.icefaces.impl.util.DOMUtils#escapeAnsi. In escapeAttribute() the single quote character was purposely removed from the list of characters to be escaped. Put it back in? Would it cause problems for other calls (many indirectly) to the function?

Tyler Johnson made changes - 08/Jun/11 8:40 AM

Salesforce Case

[5007000000GtwPh]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#24823	Mon Jun 13 13:05:07 MDT 2011	yip.ng	~~ICE-6835~~: 2.0 compat selectInputText will not work when nested comps have JS events.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#24824	Mon Jun 13 13:07:19 MDT 2011	yip.ng	~~ICE-6835~~: 2.0 compat selectInputText will not work when nested comps have JS events.
				Files Changed
				MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Hide

Permalink

yip.ng added a comment - 13/Jun/11 3:23 PM

Single quote escaping doesn't warrant changing utility methods. Private method created just to escape single quote in SelectInputTextRenderer.

Revision: 24823

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Revision: 24824

Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Show

yip.ng added a comment - 13/Jun/11 3:23 PM Single quote escaping doesn't warrant changing utility methods. Private method created just to escape single quote in SelectInputTextRenderer. Revision: 24823 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Revision: 24824 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

yip.ng made changes - 13/Jun/11 3:23 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 04/Oct/11 3:34 PM

Fix Version/s		2.1-Beta [ 10291 ]
Fix Version/s	2.1 [ 10241 ]

Ken Fyten made changes - 06/Feb/12 1:39 PM

Fix Version/s

3.0 [ 10241 ]

Ken Fyten made changes - 17/Feb/12 6:16 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

yip.ng

Reporter:

Tyler Johnson

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

02/May/11 3:38 PM

Updated:

17/Feb/12 6:16 PM

Resolved:

13/Jun/11 3:23 PM