[ICE-6812] panelPopup autoCenter mispositions menuPopup within a panelTooltip - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.2-EE-GA_P02, EE-1.8.2.GA_P07
Fix Version/s: EE-3.3.0.GA_P03, EE-1.8.2.GA_P08
Component/s: ICE-Components
Labels:
None
Environment:
-

Assignee Priority:
P3
Salesforce Case Reference:

Description

Specifying autoCenter on the panelPopup causes the nested menuPopup within the panelToolTip to appear in the bottom right hand side of the screen.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case12351Example.war

13/Dec/13 9:32 AM

6.61 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Item.class 1 kB

WEB-INF/classes/.../example/TestBean.class 2 kB

WEB-INF/faces-config.xml 0.8 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-lang.jar 240 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.98 MB

WEB-INF/lib/icefaces-facelets.jar 596 kB

WEB-INF/lib/icefaces.jar 1.24 MB

WEB-INF/lib/jsf-api-1.2.jar 355 kB

WEB-INF/lib/jsf-impl-1.2.jar 837 kB

WEB-INF/web.xml 4 kB

welcomeICEfaces.xhtml 4 kB

Download Zip
Show

Case12351Example.war

13/Dec/13 9:32 AM

6.61 MB

Arran Mccullough
Hide
Case12351Example.zip

13/Dec/13 9:32 AM

21 kB

Arran Mccullough
Case12351Example/build.xml 3 kB

Case12351Example/.../ant-deploy.xml 3 kB

Case12351Example/.../build-impl.xml 77 kB

Case12351Example/.../faces-config.NavData 0.2 kB

Case12351Example/.../genfiles.properties 0.5 kB

Case12351Example/.../private.properties 0.6 kB

Case12351Example/nbproject/.../private.xml 0.2 kB

Case12351Example/.../project.properties 3 kB

Case12351Example/nbproject/project.xml 0.9 kB

Case12351Example/src/conf/MANIFEST.MF 0.0 kB

Case12351Example/src/.../example/Item.java 0.9 kB

Case12351Example/src/.../TestBean.java 0.9 kB

Case12351Example/web/.../context.xml 0.1 kB

Case12351Example/web/.../faces-config.xml 0.8 kB

Case12351Example/web/WEB-INF/web.xml 4 kB

Case12351Example/.../welcomeICEfaces.xhtml 4 kB

Download Zip
Show

Case12351Example.zip

13/Dec/13 9:32 AM

21 kB

Arran Mccullough
Hide
sc9851.war

20/Apr/11 2:50 PM

7.81 MB

Tyler Johnson
META-INF/MANIFEST.MF 0.0 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/faces-config.xml 0.4 kB

WEB-INF/lib/icefaces-comps.jar 3.16 MB

ICEfacesPage1.xhtml 2 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/jsf-impl.jar 837 kB

index.jsp 0.1 kB

WEB-INF/lib/jxl.jar 708 kB

WEB-INF/lib/jsf-api.jar 355 kB

WEB-INF/lib/icefaces.jar 1.21 MB

WEB-INF/web.xml 4 kB

WEB-INF/lib/icefaces-facelets.jar 596 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

Download Zip
Show

sc9851.war

20/Apr/11 2:50 PM

7.81 MB

Tyler Johnson

screenshot-1.jpg

21 kB

20/Apr/11 2:48 PM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tyler Johnson added a comment - 20/Apr/11 2:52 PM

Test case is intended for deployment on tomcat 6. To activate the tooltip, right click on the inputText components.

Show

Tyler Johnson added a comment - 20/Apr/11 2:52 PM Test case is intended for deployment on tomcat 6. To activate the tooltip, right click on the inputText components.

Hide

Permalink

Arran Mccullough added a comment - 09/Oct/13 10:00 AM

I can reproduce similar issue with just a panelPopup and a menuPopup. Test case code can be provided if needed.

Show

Arran Mccullough added a comment - 09/Oct/13 10:00 AM I can reproduce similar issue with just a panelPopup and a menuPopup. Test case code can be provided if needed.

Hide

Permalink

Arran Mccullough added a comment - 07/Nov/13 8:28 AM

Attached my current test case.

Steps:

Load welcomeICEfaces.iface
Click on the Open button
Right click the text on the panelPopup, menuPopup is displayed away from where the right click event takes place.

Show

Arran Mccullough added a comment - 07/Nov/13 8:28 AM Attached my current test case. Steps: Load welcomeICEfaces.iface Click on the Open button Right click the text on the panelPopup, menuPopup is displayed away from where the right click event takes place.

Hide

Permalink

Arturo Zambrano added a comment - 07/Nov/13 2:08 PM

Committed fix at revision 38748.

I could only reproduce the issue on the Case12351Example test case, attached by Arran. It seems like the issue only occurred with modal popups, it had nothing to do with the 'autoCentre' attribute.

All the coordinates were being set correctly, the only problem was that under certain scenarios, those coordinates would be relative to the container element, so this was fixed by adding 'position:fixed' to the context menu container style attribute.

Show

Arturo Zambrano added a comment - 07/Nov/13 2:08 PM Committed fix at revision 38748. I could only reproduce the issue on the Case12351Example test case, attached by Arran. It seems like the issue only occurred with modal popups, it had nothing to do with the 'autoCentre' attribute. All the coordinates were being set correctly, the only problem was that under certain scenarios, those coordinates would be relative to the container element, so this was fixed by adding 'position:fixed' to the context menu container style attribute.

Hide

Permalink

Arturo Zambrano added a comment - 12/Nov/13 11:56 AM

Committed fix to 3.3 EE maintenance branch at revision 38773.

Show

Arturo Zambrano added a comment - 12/Nov/13 11:56 AM Committed fix to 3.3 EE maintenance branch at revision 38773.

Hide

Permalink

Arran Mccullough added a comment - 13/Dec/13 9:19 AM

This fix looks to have caused a regression when displaying the menuPopup in a scrollable browser window. If the window is scrolled at the top, the menuPopup displays in the correct position. If the browser window is scrolled down, the menu gets displayed in an incorrect position. This is seen outside of the panelPopup. I'll attach a modified test case that reproduces the issue.

Show

Arran Mccullough added a comment - 13/Dec/13 9:19 AM This fix looks to have caused a regression when displaying the menuPopup in a scrollable browser window. If the window is scrolled at the top, the menuPopup displays in the correct position. If the browser window is scrolled down, the menu gets displayed in an incorrect position. This is seen outside of the panelPopup. I'll attach a modified test case that reproduces the issue.

Hide

Permalink

Arran Mccullough added a comment - 13/Dec/13 9:32 AM

Attached test case that shows regression.

Steps:

Load welcomeICEfaces.iface
Resize the browser so a vertical scrollbar is shown.
Right click on the Column Two cells, menuPopup is positioned fine.
Re-do the above step with the browser scrolled down, position is off.

Show

Arran Mccullough added a comment - 13/Dec/13 9:32 AM Attached test case that shows regression. Steps: Load welcomeICEfaces.iface Resize the browser so a vertical scrollbar is shown. Right click on the Column Two cells, menuPopup is positioned fine. Re-do the above step with the browser scrolled down, position is off.

Hide

Permalink

Arturo Zambrano added a comment - 12/Feb/14 11:16 AM - edited

Committed fix to 1.8 trunk at revision 39993 and to 3.3 EE maintenance branch at revision 40001. Since, the menu has been now fixed-positioned, we needed to take into account the vertical scroll when positioning it. So, we now subtract the vertical scroll value from the absolute vertical position on the page, so the menu can be correctly positioned whether the vertical scroll is at the top, at the bottom or in between.

Show

Arturo Zambrano added a comment - 12/Feb/14 11:16 AM - edited Committed fix to 1.8 trunk at revision 39993 and to 3.3 EE maintenance branch at revision 40001. Since, the menu has been now fixed-positioned, we needed to take into account the vertical scroll when positioning it. So, we now subtract the vertical scroll value from the absolute vertical position on the page, so the menu can be correctly positioned whether the vertical scroll is at the top, at the bottom or in between.

Hide

Permalink

Liana Munroe added a comment - 16/Jun/14 11:18 AM - edited

Icefaces1.8 trunk revision# 41326
Tomcat6, IE7 and 8 only
Component-showcase, Component-showcase[facelets-enh] and [facelets]
Menu popup - Error seen when interacting (right clicking) with demo.
Message: Invalid argument.
Line: 38
Char: 3658
Code: 0
URI: http://localhost:8080/ICE-3856/xmlhttp/1402676167843/ice-extras.js
Server error seen:
SEVERE: java.lang.NullPointerException
at org.icefaces.application.showcase.view.bean.examples.component.menuPopup.MenuPopupBean.executeMenuEffect(MenuPopupBean.java:85)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.el.parser.AstValue.invoke(AstValue.java:191)
at org.apache.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:276)
at com.sun.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:68)
at javax.faces.event.MethodExpressionActionListener.processAction(MethodExpressionActionListener.java:99)
at com.icesoft.faces.component.ContextActionEvent.processListener(ContextActionEvent.java:63)
at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:774)......

Show

Liana Munroe added a comment - 16/Jun/14 11:18 AM - edited Icefaces1.8 trunk revision# 41326 Tomcat6, IE7 and 8 only Component-showcase, Component-showcase [facelets-enh] and [facelets] Menu popup - Error seen when interacting (right clicking) with demo. Message: Invalid argument. Line: 38 Char: 3658 Code: 0 URI: http://localhost:8080/ICE-3856/xmlhttp/1402676167843/ice-extras.js Server error seen: SEVERE: java.lang.NullPointerException at org.icefaces.application.showcase.view.bean.examples.component.menuPopup.MenuPopupBean.executeMenuEffect(MenuPopupBean.java:85) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.el.parser.AstValue.invoke(AstValue.java:191) at org.apache.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:276) at com.sun.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:68) at javax.faces.event.MethodExpressionActionListener.processAction(MethodExpressionActionListener.java:99) at com.icesoft.faces.component.ContextActionEvent.processListener(ContextActionEvent.java:63) at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:774)......

Hide

Permalink

Arturo Zambrano added a comment - 16/Apr/15 2:14 PM

Couldn't reproduce the last issue above (1.8 trunk, latest revision). Please verify.

Show

Arturo Zambrano added a comment - 16/Apr/15 2:14 PM Couldn't reproduce the last issue above (1.8 trunk, latest revision). Please verify.

Hide

Permalink

Liana Munroe added a comment - 16/Apr/15 4:25 PM

Tested with ICEfaces 1.8 r44499. Still able to reproduce last issue using IE 7 and 8.

Show

Liana Munroe added a comment - 16/Apr/15 4:25 PM Tested with ICEfaces 1.8 r44499. Still able to reproduce last issue using IE 7 and 8.

Hide

Permalink

Arturo Zambrano added a comment - 08/May/15 4:31 PM

r44666: added alternatives for window.pageYOffset, which doesn't exist on IE8.

Show

Arturo Zambrano added a comment - 08/May/15 4:31 PM r44666: added alternatives for window.pageYOffset, which doesn't exist on IE8.

Hide

Permalink

Liana Munroe added a comment - 14/May/15 3:57 PM

Verified component-showcase issue with IE7 and IE8 resolved, ICEfaces 1.8 r44697, Tomcat 6.

Show

Liana Munroe added a comment - 14/May/15 3:57 PM Verified component-showcase issue with IE7 and IE8 resolved, ICEfaces 1.8 r44697, Tomcat 6.

Hide

Permalink

Arturo Zambrano added a comment - 26/May/15 10:29 AM

r44771: committed fix to position submenus at the right height when the page has been scrolled down to the 1.8 trunk (it didn't affect the 3.3 codebase).

An issue I found when working on this was that on 1.8 the submenus were positioned higher when there was scrolling in the viewport. This fix includes the vertical scrolling offset when calculating the position of submenus.

Show

Arturo Zambrano added a comment - 26/May/15 10:29 AM r44771: committed fix to position submenus at the right height when the page has been scrolled down to the 1.8 trunk (it didn't affect the 3.3 codebase). An issue I found when working on this was that on 1.8 the submenus were positioned higher when there was scrolling in the viewport. This fix includes the vertical scrolling offset when calculating the position of submenus.

Hide

Permalink

Liana Munroe added a comment - 26/May/15 1:00 PM

Verified ICEfaces EE-3.3.0.GA_P03 tag r42000 and ICEfaces 1.8 trunk r44773. No issues found.

Show

Liana Munroe added a comment - 26/May/15 1:00 PM Verified ICEfaces EE-3.3.0.GA_P03 tag r42000 and ICEfaces 1.8 trunk r44773. No issues found.

People

Assignee:

Arturo Zambrano

Reporter:

Tyler Johnson

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

20/Apr/11 2:45 PM

Updated:

13/Mar/17 1:32 PM

Resolved:

26/May/15 10:29 AM