Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: EE-2.0.0.GA, 3.0
-
Fix Version/s: EE-2.0.0.GA, 2.0.2
-
Component/s: Framework
-
Labels:None
-
Environment:Liferay 6.0.6 + Tomcat 6.0.29 + PortletFaces Bridge 2.0.0-SNAPSHOT (April 7th, 2011)
Description
Here's the patch:
Index: core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
===================================================================
--- core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java (revision 24358)
+++ core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java (working copy)
@@ -51,7 +51,7 @@
public void handleNavigation(FacesContext context, String fromAction, String outcome) {
NavigationCase navigationCase = getNavigationCase(context, fromAction, outcome);
- if (navigationCase.isRedirect()) {
+ if ((navigationCase != null) && (navigationCase.isRedirect())) {
handler.handleNavigation(context, fromAction, outcome);
} else {
UIViewRoot viewRoot = context.getViewRoot();
@@ -63,7 +63,13 @@
viewAttributes.put(DeltaSubmitPhaseListener.PreviousParameters, idToPreviousParametersMapping);
}
for (UIForm form: forms) {
- idToPreviousParametersMapping.put(form.getId(), new HashMap((Map) form.getAttributes().get(DeltaSubmitPhaseListener.PreviousParameters)));
+ Map<String, Object> formAttributes = form.getAttributes();
+ if (formAttributes != null) {
+ Map previousParametersMap = (Map) formAttributes.get(DeltaSubmitPhaseListener.PreviousParameters);
+ if (previousParametersMap != null) {
+ idToPreviousParametersMapping.put(form.getId(), new HashMap(previousParametersMap));
+ }
+ }
}
handler.handleNavigation(context, fromAction, outcome);
//propagate previously calculated submit parameters
Index: core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
===================================================================
--- core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java (revision 24358)
+++ core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java (working copy)
@@ -51,7 +51,7 @@
public void handleNavigation(FacesContext context, String fromAction, String outcome) {
NavigationCase navigationCase = getNavigationCase(context, fromAction, outcome);
- if (navigationCase.isRedirect()) {
+ if ((navigationCase != null) && (navigationCase.isRedirect())) {
handler.handleNavigation(context, fromAction, outcome);
} else {
UIViewRoot viewRoot = context.getViewRoot();
@@ -63,7 +63,13 @@
viewAttributes.put(DeltaSubmitPhaseListener.PreviousParameters, idToPreviousParametersMapping);
}
for (UIForm form: forms) {
- idToPreviousParametersMapping.put(form.getId(), new HashMap((Map) form.getAttributes().get(DeltaSubmitPhaseListener.PreviousParameters)));
+ Map<String, Object> formAttributes = form.getAttributes();
+ if (formAttributes != null) {
+ Map previousParametersMap = (Map) formAttributes.get(DeltaSubmitPhaseListener.PreviousParameters);
+ if (previousParametersMap != null) {
+ idToPreviousParametersMapping.put(form.getId(), new HashMap(previousParametersMap));
+ }
+ }
}
handler.handleNavigation(context, fromAction, outcome);
//propagate previously calculated submit parameters
Activity
Neil Griffin
created issue -
Deryk Sinotte
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [] | |
Component/s | Framework [ 10013 ] | |
Fix Version/s | EE-2.0.0.GA [ 10263 ] | |
Fix Version/s | 2.1 [ 10241 ] | |
Assignee Priority | P1 | |
Assignee | Mircea Toma [ mircea.toma ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #24363 | Thu Apr 07 17:17:06 MDT 2011 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #24364 | Thu Apr 07 17:24:14 MDT 2011 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
|
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 2.0.2 [ 10273 ] | |
Fix Version/s | 2.1 [ 10241 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P1 |
Mircea,
Please review Neil's patch and provide feedback/adjustments/etc. I've applied the patch locally and run some tests on our ACE components in Liferay 5 and this clears up a bunch of NullPointerExceptions we were seeing when running the ACE Showcase Portlets demo.