ICEfaces
  1. ICEfaces
  2. ICE-6732

Ace build use YUI compressor and no-compress flag like compat

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: EE-2.0.0.GA, 2.0.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE

      Description

      Following the lead of our compat javascript build process, we should minify our ACE javascript as well.

        Issue Links

          Activity

          Mark Collette created issue -
          Ken Fyten made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s EE-2.0.0.GA [ 10263 ]
          Fix Version/s 2.1 [ 10241 ]
          Assignee Priority P1
          Assignee Arturo Zambrano [ artzambrano ]
          Ken Fyten made changes -
          Fix Version/s EE-2.0.0.GA [ 10263 ]
          Mark Collette made changes -
          Link This issue blocks ICE-6597 [ ICE-6597 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #24393 Thu Apr 14 20:29:12 MDT 2011 mark.collette ICE-6732 : Ace build use YUI compressor and no-compress flag like compat
          Files Changed
          Commit graph MODIFY /icefaces2/scratchpads/ICE-6698/icefaces-2.0.x-maintenance/icefaces/ace/component/build.properties
          Commit graph MODIFY /icefaces2/scratchpads/ICE-6698/icefaces-2.0.x-maintenance/icefaces/ace/component/build.xml
          Mark Collette made changes -
          Salesforce Case []
          Fix Version/s EE-2.0.0.GA [ 10263 ]
          Assignee Arturo Zambrano [ artzambrano ] Mark Collette [ mark.collette ]
          Hide
          Mark Collette added a comment -

          Building on ICE-6194's combining of the javascript files, this compresses that combined file.

          scratchpads/ICE-6698
          Subversion 24393

          Show
          Mark Collette added a comment - Building on ICE-6194 's combining of the javascript files, this compresses that combined file. scratchpads/ICE-6698 Subversion 24393
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #24416 Mon Apr 18 15:21:12 MDT 2011 mark.collette ICE-6732 : Ace build use YUI compressor and no-compress flag like compat
          Files Changed
          Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/build.xml
          Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/build.properties
          Hide
          Mark Collette added a comment - - edited

          /ossrepo/icefaces2/branches/icefaces-2.0.x-maintenance/
          Subversion 24416

          trunk
          Subversion 24446

          Show
          Mark Collette added a comment - - edited /ossrepo/icefaces2/branches/icefaces-2.0.x-maintenance/ Subversion 24416 trunk Subversion 24446
          Hide
          Mark Collette added a comment -

          Tried compressing the CSS, but that lead to the resumption of the IE7 aborted exception from ICE-6702.

          Show
          Mark Collette added a comment - Tried compressing the CSS, but that lead to the resumption of the IE7 aborted exception from ICE-6702.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #24446 Thu Apr 21 12:39:25 MDT 2011 mark.collette ICE-6732 : Ace build use YUI compressor and no-compress flag like compat
          Files Changed
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.properties
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
          Hide
          Mark Collette added a comment -

          In the future, if we do fix ICE-6702, and then want to compress the ACE CSS, we could modify ace/component/build.xml like this:

          51a52,53
          > <property name="combined.css" location="$

          {resources}/org.icefaces.component.util/combined.css"/>
          > <property name="combined.css.tmp" location="${combined.css}.tmp.css"/>
          138c140
          < <target name="compile" depends="prepare, generator-dist, compile-meta, generate, compile-base, compile-manual, compile-support, res-js-compress, res-js-no-compress, res-css-combine, res-copy"

          > <target name="compile" depends="prepare, generator-dist, compile-meta, generate, compile-base, compile-manual, compile-support, res-compress, res-no-compress, res-copy"
          160,161c162,163
          < <target name="res-js-compress" depends="res-js-combine" unless="no-compress">
          < <echo message="Compressing combined javascript code"/>

          > <target name="res-compress" depends="res-js-combine, res-css-combine" unless="no-compress">
          > <echo message="Compressing combined javascript and css"/>
          167a170,175
          > <java jar="${lib.dir}/yui-compressor.jar" fork="yes">
          > <arg line="--preserve-semi"/>
          > <arg value="-o"/>
          > <arg value="${combined.css}"/>
          > <arg value="${combined.css.tmp}"/>
          > </java>
          170,171c178,179
          < <target name="res-js-no-compress" depends="res-js-combine" if="no-compress">
          < <echo message="Not compressing combined javascript code"/>

          > <target name="res-no-compress" depends="res-js-combine, res-css-combine" if="no-compress">
          > <echo message="Not compressing combined javascript and css"/>
          177a186,190
          > <move file="${combined.css.tmp}" tofile="${combined.css}" overwrite="yes">
          > <filterchain>
          > <ignoreblank/>
          > </filterchain>
          > </move>
          181,182c194,195
          < <delete file="${resources}

          /org.icefaces.component.util/combined.css" verbose="true"/>
          < <concat destfile="$

          {resources}

          /org.icefaces.component.util/combined.css" force="true" fixlastline="true">

          > <delete file="$

          {combined.css.tmp}" verbose="true"/>
          > <concat destfile="${combined.css.tmp}

          " force="true" fixlastline="true">

          Show
          Mark Collette added a comment - In the future, if we do fix ICE-6702, and then want to compress the ACE CSS, we could modify ace/component/build.xml like this: 51a52,53 > <property name="combined.css" location="$ {resources}/org.icefaces.component.util/combined.css"/> > <property name="combined.css.tmp" location="${combined.css}.tmp.css"/> 138c140 < <target name="compile" depends="prepare, generator-dist, compile-meta, generate, compile-base, compile-manual, compile-support, res-js-compress, res-js-no-compress, res-css-combine, res-copy" — > <target name="compile" depends="prepare, generator-dist, compile-meta, generate, compile-base, compile-manual, compile-support, res-compress, res-no-compress, res-copy" 160,161c162,163 < <target name="res-js-compress" depends="res-js-combine" unless="no-compress"> < <echo message="Compressing combined javascript code"/> — > <target name="res-compress" depends="res-js-combine, res-css-combine" unless="no-compress"> > <echo message="Compressing combined javascript and css"/> 167a170,175 > <java jar="${lib.dir}/yui-compressor.jar" fork="yes"> > <arg line="--preserve-semi"/> > <arg value="-o"/> > <arg value="${combined.css}"/> > <arg value="${combined.css.tmp}"/> > </java> 170,171c178,179 < <target name="res-js-no-compress" depends="res-js-combine" if="no-compress"> < <echo message="Not compressing combined javascript code"/> — > <target name="res-no-compress" depends="res-js-combine, res-css-combine" if="no-compress"> > <echo message="Not compressing combined javascript and css"/> 177a186,190 > <move file="${combined.css.tmp}" tofile="${combined.css}" overwrite="yes"> > <filterchain> > <ignoreblank/> > </filterchain> > </move> 181,182c194,195 < <delete file="${resources} /org.icefaces.component.util/combined.css" verbose="true"/> < <concat destfile="$ {resources} /org.icefaces.component.util/combined.css" force="true" fixlastline="true"> — > <delete file="$ {combined.css.tmp}" verbose="true"/> > <concat destfile="${combined.css.tmp} " force="true" fixlastline="true">
          Mark Collette made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 2.0.2 [ 10273 ]
          Fix Version/s 2.1 [ 10241 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P1

            People

            • Assignee:
              Mark Collette
              Reporter:
              Mark Collette
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: