ICEfaces
  1. ICEfaces
  2. ICE-6717

<f:ajax disabled="true"> does not work correctly

          Details

            Description

            <h:commandButton ...>
              <f:ajax disabled="true">
            </h:commandButton>

            works as long as no input field has had the focus or no ajax-enabled button is clicked.

            See the attached example:
            'h:commandButton without Ajax' works in the beginning but not anymore after a click in one of the input fields or '...with Ajax' buttons.

            This happens with the nightly builds from March 29th as well as the one from March 22th

              Activity

              Ascending order - Click to sort in descending order
              Stefan Niederhauser created issue -
              Hide
              Permalink
              Stefan Niederhauser added a comment -

              Example app to demonstrate the issue

              Show
              Stefan Niederhauser added a comment - Example app to demonstrate the issue
              Stefan Niederhauser made changes -
              Field Original Value New Value
              Attachment jsf20-web-0.0.1-SNAPSHOT.war [ 13031 ]
              Hide
              Permalink
              Adrian Gygax added a comment -

              I just verifed this bug and it happens also with ICEfaces 2.0.1 final.

              One scenario to reproduce the bug (Tested with Firefox 4):
              1. Open in browser: http://localhost:8080/jsf20-web-0.0.1-SNAPSHOT/pages/iceWithoutAjax.xhtml
              2. Click "h:commandButton without Ajax" once. This is a normal POST as expected
              3. Click "h:commandButton without Ajax" a second time. Now, this is an Ajax POST which is not what we want as we specified <f:ajax disabled="true"/>

              Show
              Adrian Gygax added a comment - I just verifed this bug and it happens also with ICEfaces 2.0.1 final. One scenario to reproduce the bug (Tested with Firefox 4): 1. Open in browser: http://localhost:8080/jsf20-web-0.0.1-SNAPSHOT/pages/iceWithoutAjax.xhtml 2. Click "h:commandButton without Ajax" once. This is a normal POST as expected 3. Click "h:commandButton without Ajax" a second time. Now, this is an Ajax POST which is not what we want as we specified <f:ajax disabled="true"/>
              Hide
              Permalink
              Ted Goddard added a comment -

              Is this a regression? (Have you observed it working prior to March 22?)

              Show
              Ted Goddard added a comment - Is this a regression? (Have you observed it working prior to March 22?)
              Hide
              Permalink
              Stefan Niederhauser added a comment -

              I did not try it with earlier versions because there were other problems

              Show
              Stefan Niederhauser added a comment - I did not try it with earlier versions because there were other problems
              Hide
              Permalink
              Stefan Niederhauser added a comment -

              just tried it... it happens also with 2.0.0

              Show
              Stefan Niederhauser added a comment - just tried it... it happens also with 2.0.0
              Hide
              Permalink
              Ted Goddard added a comment -

              This should likely be targeted for the next EE release.

              Show
              Ted Goddard added a comment - This should likely be targeted for the next EE release.
              Ted Goddard made changes -
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s EE-2.0.0.GA [ 10263 ]
              Assignee Priority P2
              Assignee Ken Fyten [ ken.fyten ] Ted Goddard [ ted.goddard ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 2.1 [ 10241 ]
              Hide
              Permalink
              Ted Goddard added a comment -

              This is partially a regression from ICE-6674 from the code change for ICE-6327. The basic problem is that IE and Firefox handle calling the "native submit" of a form differently from WebKit browsers. IE and Firefox are not including the submitting element.

              Show
              Ted Goddard added a comment - This is partially a regression from ICE-6674 from the code change for ICE-6327 . The basic problem is that IE and Firefox handle calling the "native submit" of a form differently from WebKit browsers. IE and Firefox are not including the submitting element.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24369 Mon Apr 11 10:56:00 MDT 2011 ted.goddard checking for ajaxDisabled during PostAddToView and adding hidden field for IE and Firefox during submit (ICE-6717)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/javascript/application.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/MainEventListener.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/javascript/submit.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/AjaxDisabledList.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24370 Mon Apr 11 11:22:30 MDT 2011 ted.goddard checking for ajaxDisabled during PostAddToView and adding hidden field for IE and Firefox during submit (ICE-6717)
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/event/AjaxDisabledList.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/javascript/submit.js
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/javascript/application.js
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/event/MainEventListener.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/resources/META-INF/faces-config.xml
              Hide
              Permalink
              Ted Goddard added a comment -

              Any component that can submit a form is a candidate for <f:ajax disabled="true">. In other words, complete testing would require component-showcase or a set of component regression tests to be modified so that each input component included <f:ajax disabled="true/false">.

              Show
              Ted Goddard added a comment - Any component that can submit a form is a candidate for <f:ajax disabled="true">. In other words, complete testing would require component-showcase or a set of component regression tests to be modified so that each input component included <f:ajax disabled="true/false">.
              Ken Fyten made changes -
              Assignee Ted Goddard [ ted.goddard ] Mandeep Hayher [ mandeep.hayher ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Resolved pending confirmation by QA.

              Show
              Ken Fyten added a comment - Resolved pending confirmation by QA.
              Ken Fyten made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Priority P2 P1
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24413 Mon Apr 18 12:39:00 MDT 2011 ted.goddard form support for ajax disabled (ICE-6717)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/AjaxDisabledList.java
              Hide
              Permalink
              Ted Goddard added a comment -

              Enhancement added so that if <h:form> is marked <f:ajax disabled="true"> the ice.captureSubmit() feature will be disabled as well. This prevents Ajax from being enabled on components that themselves do not directly support <f:ajax>.

              Show
              Ted Goddard added a comment - Enhancement added so that if <h:form> is marked <f:ajax disabled="true"> the ice.captureSubmit() feature will be disabled as well. This prevents Ajax from being enabled on components that themselves do not directly support <f:ajax>.
              Hide
              Permalink
              Ted Goddard added a comment -

              Test case for <f:ajax> and <ui:include> problem here:

              http://java.net/jira/browse/JAVASERVERFACES-2041

              This problem is unique to ui:include.

              Show
              Ted Goddard added a comment - Test case for <f:ajax> and <ui:include> problem here: http://java.net/jira/browse/JAVASERVERFACES-2041 This problem is unique to ui:include.
              Ken Fyten made changes -
              Fix Version/s 2.0.2 [ 10273 ]
              Fix Version/s 2.1 [ 10241 ]
              Mark Collette made changes -
              Link This issue blocks ICE-6899 [ ICE-6899 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Mandeep Hayher
                  Reporter:
                  Stefan Niederhauser
                • Votes:
                  2 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: