component is using CKEditor.

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Adding: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor.zip application/octet-stream
Adding: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Deleting: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\fckeditor.js
Deleting: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\fckeditor.zip
Deleting: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\fckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor.zip
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Completed: At revision: 24310

Known issues:

• Save icon doesn't have an image with any browser.
  -IE doesn't work on first navigation, works on page refresh (I tried to put javascript in head and this problem gets fixed, so if we can put javascript in head that should fixed)
• Changing toolbar dynamically doesn't work under IE, works with FF.

Rendering of Null value fixed

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Completed: At revision: 24336

On icefaces2/trunk, inputRichText is failing with the following JS error (tested Chrome 10 and FF 4, svn rev. # 24367):

"Uncaught TypeError: Cannot read property 'options' of undefined"

Save icon fixed.
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Completed: At revision: 24433

duplicate instances issue fixed on update.

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Completed: At revision: 24451

lang support added
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Completed: At revision: 24666

Skin support added.

The new skin names are:

• v2 (default)
  -office2003
  -kama

For backwards compatibility the "default" and "silver" mapped to "v2"

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Completed: At revision: 24671

height and width support added:

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Completed: At revision: 24672

saveOnSubmit support added

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java
Completed: At revision: 24675

Custom toolbar support added:

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\ckeditor_ext.js
Completed: At revision: 24676

Changes applied to icefaces-2.0.x-maintenance. At revision: 24707

height fixed.

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Completed: At revision: 24709

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Completed: At revision: 24711

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichText.java
Completed: At revision: 24712

Skin mapped with Theme
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\samples\compat\component-showcase\src\main\java\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\samples\compat\component-showcase\src\main\java\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Completed: At revision: 24723

Skin mapped with theme [trunk]
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\inputRichText.jspx
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\inputRichText.jspx
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Completed: At revision: 24724

Skin mapped with theme [icefaces 2.0 maintenance]
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\java\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\java\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\samples\compat\component-showcase\src\main\webapp\WEB-INF\includes\examples\custom\inputRichText.xhtml
Completed: At revision: 24725

This component should obey mandatoryResourceComponent parameter so that the JavaScript is not always added if not required.

The JS error occurs when the CKEditor.editor.destroy() function is called and the iframe created by CKeditor is missing. In component-showcase when going to "Description" tab and back the renderEditor() function is invoked which in turn tries to remove the editor instance created previously. Unfortunately the iframe is erased by the DOM update that renders the "Description" tab content, hence the JS error.

Pass 'true' as parameter to the CKEditor.editor.destroy() function so the CKEditor code will remove the editor instance without trying to restore the element that the iframe replaced when the editor was created.

TLD Docs added to trunk
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Completed: At revision: 24785

TLD docs added to icefaces-2.0.x-maintenance

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Completed: At revision: 24786

TLD docs added to icefaces-2 trunk
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_cust_properties\cust-inputRichText-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\component-metadata\src\main\resources\conf\custom\inputRichText-renderer.xml
Completed: At revision: 24787

Reopening this one as the inputRichText is not Serializable

When Session replication is attempted, the following is shown in the logs:

java.io.NotSerializableException: com.icesoft.faces.component.inputrichtext.InputRichTextSetup$2$1

Refactored the anonymous inner class, now implementing Serializable. JarResource and InputRichTextSetup implement Serializable now as well. Marking this one as FIXED.

Assigning back to Adnan. Please review my changes.