ICEfaces
  1. ICEfaces
  2. ICE-6711

ICE-2620 fails with deltaSubmit=true

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: EE-2.0.0.GA, 2.0.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      Server: Tomcat6
      Browsers: FF3.6, IE7 & GoogleChrome10
      Icefaces2 revision# 24206

      Description

      ICE-2620 all browsers: The second click on any row of the datatable does not result in navigation to another page. This works fine on regular icefaces2 trunk.
      Test application is available at 'svn\repo\qa\trunk\Regression-Icefaces2\Nightly\ICE-2620'

        Activity

        Mandeep Hayher created issue -
        Mandeep Hayher made changes -
        Field Original Value New Value
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.0-EE-GA [ 10263 ]
        Assignee Priority P2
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24357 Wed Apr 06 17:01:04 MDT 2011 mircea.toma ICE-6711 Introduced custom navigation handler that propagates the previously calculated parameters into the destination view.
         Modified DeltaSubmitPhaseLister to lookup previous parameters into the view map in case they were propagated during navigation.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/DeltaSubmitPhaseListener.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24358 Wed Apr 06 17:06:35 MDT 2011 mircea.toma ICE-6711 Introduced custom navigation handler that propagates the previously calculated parameters into the destination view.
         Modified DeltaSubmitPhaseLister to lookup previous parameters into the view map in case they were propagated during navigation.
        Files Changed
        Commit graph ADD /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/application/DeltaSubmitParametersPropagation.java
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/event/DeltaSubmitPhaseListener.java
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Hide
        Mircea Toma added a comment -

        This issue occurs also with icefaces2/trunk fro me.

        Show
        Mircea Toma added a comment - This issue occurs also with icefaces2/trunk fro me.
        Hide
        Mircea Toma added a comment -

        It seems that the forward navigations in the test application confuse the delta submit calculation on the server side. For the client nothing indicates that the JSF view has changed (due to the non-redirecting navigation) thus the previous parameters are preserved and used normally just like during any DOM update. On the server-side though the view is completely swapped with a new one, since the previous parameters are saved as attributes on the form components they are lost during the navigation. Because of this the client and server delta submit data is out of sync.

        Show
        Mircea Toma added a comment - It seems that the forward navigations in the test application confuse the delta submit calculation on the server side. For the client nothing indicates that the JSF view has changed (due to the non-redirecting navigation) thus the previous parameters are preserved and used normally just like during any DOM update. On the server-side though the view is completely swapped with a new one, since the previous parameters are saved as attributes on the form components they are lost during the navigation. Because of this the client and server delta submit data is out of sync.
        Hide
        Mircea Toma added a comment -

        Introduced custom navigation handler responsible to propagate the previously calculated parameters from the source view into the destination view.
        Modified DeltaSubmitPhaseLister to check for the propagated parameters in case a non-redirecting navigation rule was executed, thus making sure that the delta calculation remains in sync with the one executed in the client.

        Show
        Mircea Toma added a comment - Introduced custom navigation handler responsible to propagate the previously calculated parameters from the source view into the destination view. Modified DeltaSubmitPhaseLister to check for the propagated parameters in case a non-redirecting navigation rule was executed, thus making sure that the delta calculation remains in sync with the one executed in the client.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.1 [ 10241 ]
        Resolution Fixed [ 1 ]
        Hide
        Mandeep Hayher added a comment -

        Tested successfully on Icefaces-ee2 trunk revision# 27178
        Server: Tomcat6
        Browser: FF3.6, IE7 & GoogleChrome8

        Show
        Mandeep Hayher added a comment - Tested successfully on Icefaces-ee2 trunk revision# 27178 Server: Tomcat6 Browser: FF3.6, IE7 & GoogleChrome8
        Mandeep Hayher made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Priority P2
        Assignee Mircea Toma [ mircea.toma ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.2 [ 10273 ]
        Fix Version/s 2.1 [ 10241 ]
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Salesforce Case []
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mandeep Hayher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: