ICEfaces
  1. ICEfaces
  2. ICE-6621

Message(s) rendering not overridable by application

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0
          • Fix Version/s: 2.0.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2. Details specific to Mojarra

            Description

            We've implemented our own Message Renderer and Messages Renderer, so that the output will always be wrapped in a div, to better work with our dom differencing. As part of the MyFaces 2 integration in ICE-5868 we switched from using the faces-context.xml to override the renderers to doing it programmatically, since our renderers override the Mojarra ones, and we can't use them with MyFaces. This has the side-effect of thwarting applications from overriding the renderers themselves.

            The quickest fix would be to change the renderkit code that checks to see if we should override the renderers to do an exact class name check for the Mojarra renderers, so that we don't stomp on 3rd party renderers.
            1. Java Source File
              CustomMessagesRenderer.java
              11 kB
              yip.ng
            1. screenshot-01.png
              107 kB
            2. screenshot-02.png
              116 kB
            3. screenshot-03.png
              104 kB

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24087 Thu Mar 03 11:44:26 MST 2011 arran.mccullough ICE-6621: Message(s) rendering not overridable by application
              Files Changed
              Commit graph MODIFY /icefaces2/scratchpads/patches/SF9769/icefaces/core/src/main/java/org/icefaces/impl/renderkit/DOMRenderKit.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24086 Thu Mar 03 11:41:27 MST 2011 arran.mccullough ICE-6621: Message(s) rendering not overridable by application
              Files Changed
              Commit graph MODIFY /icefaces2/scratchpads/patches/SF9769/icefaces/core/src/main/java/org/icefaces/impl/renderkit/DOMRenderKit.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24085 Thu Mar 03 11:39:36 MST 2011 arran.mccullough ICE-6621: Message(s) rendering not overridable by application
              Files Changed
              Commit graph MODIFY /icefaces2/scratchpads/patches/SF9769/icefaces/core/src/main/java/org/icefaces/impl/renderkit/DOMRenderKit.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24081 Wed Mar 02 16:05:00 MST 2011 yip.ng ICE-6621: Message(s) rendering not overridable by application.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/DOMRenderKit.java

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: