ICEfaces
  1. ICEfaces
  2. ICE-6608

ACE improvements for 2.0.1

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0
          • Fix Version/s: 2.0.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEFaces 2.0 Ace components

            Description

            Keep track of individual changes for 2.0.1 components.

              Activity

              Ascending order - Click to sort in descending order
              Greg Dick created issue -
              Greg Dick made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0.1 [ 10255 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24048 Mon Feb 28 23:20:23 MST 2011 greg.dick ICE-6608 Eliminate the use of String.replace as it's expensive
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/JSONBuilder.java
              Hide
              Permalink
              Greg Dick added a comment -

              I committed a change to the JSONBuilder to stop using String.replace to do escaping of Strings. Very expensive to call this method, even if the target String doesn't contain any characters to be replaced.

              I had to remove the generator code that was using attributesThatAreSet. Using the TabPane like this:
              <ice:tabPane label="Second Pane of components" >
              Here is some text in the second pane
              </ice:tabPane>

              Results in a tab with "null" as a label. It looks like the label field isn't being included in the set of attributes that are set in this case.

              Still working on the renderers.

              Show
              Greg Dick added a comment - I committed a change to the JSONBuilder to stop using String.replace to do escaping of Strings. Very expensive to call this method, even if the target String doesn't contain any characters to be replaced. I had to remove the generator code that was using attributesThatAreSet. Using the TabPane like this: <ice:tabPane label="Second Pane of components" > Here is some text in the second pane </ice:tabPane> Results in a tab with "null" as a label. It looks like the label field isn't being included in the set of attributes that are set in this case. Still working on the renderers.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24193 Thu Mar 17 17:42:00 MDT 2011 greg.dick ICE-6608 fetch the disabled flag only once.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/LinkButtonRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24194 Thu Mar 17 17:53:54 MDT 2011 greg.dick ICE-6608 removed multiple fetches of value
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java
              Hide
              Permalink
              Greg Dick added a comment -

              I've checked in some changes to LinkButtonRenderer and SliderRenderer to remove duplicate calls to property getters in the same scope and manually verified that none of the other renderers do this with any other property. We could possibly remove some constructions like "String" + "String2" + String3" and replace them with StringBuilder.append("String").append("String2").append("String3"), but from some decompilation I've seen the compiler does this anyway.

              Show
              Greg Dick added a comment - I've checked in some changes to LinkButtonRenderer and SliderRenderer to remove duplicate calls to property getters in the same scope and manually verified that none of the other renderers do this with any other property. We could possibly remove some constructions like "String" + "String2" + String3" and replace them with StringBuilder.append("String").append("String2").append("String3"), but from some decompilation I've seen the compiler does this anyway.
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: