Seems the event is queued only once per click. Yet the event listener is called multiple times.

From Mark:

Try investigating MenuItems.setParentsRecursive(UIComponent, List,ActionListener[], MethodBinding, MethodBinding). It could be that the code which tries to remove the previous action/actionListener might not be doing the job anymore, so that then the add code would be adding redundant ActionListener references, which would each fire from the one ActionEvent. This might be due JSF 2 doing state saving on the ActionListener references, so that a direct reference comparison is now incorrect.

removeActionListener() ultimately calls java.util.List#remove, which uses java.lang.Object#equals to locate the listener to delete.

It seems that the MenuItems component object and its attached listener change reference every time, as if they were re-created every time. Thus MenuItem.removeActionListener() can't locate any listener to delete and does nothing. And addActionListener() keeps adding multiple references to the same listener.

So, do we then have to override javax.faces.event.MethodExpressionActionListener with a different equals() method?

From Mark:

How about we call ActionListener[] getActionListeners(), and if there's anything at all in the array, then don't add the ActionListener, otherwise add it. This should keep us from duplicating our adding, and also keep the MenuItems from stomping over any ActionListener that the MenuItem children may have had added to them by the bean code that created them.

Revision: 24004

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItems.java