ICEfaces
  1. ICEfaces
  2. ICE-6538

Modal Popup Launched from ace:tabSet Not Covering Separate Div with ice:menuBar

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1, EE-1.8.2.GA_P03
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      JSF 2.0.3 ICEfaces 2

      Description

      I have the following layout in my template. The 'menu' insert contains an h:form with an ice:menuBar nested inside. When I launch a modal popup from the 'tabset' insert, which contains an ace:tabSet component, the modal pane is only covering the winDiv h:panelGroup, not the menu insert.

      When the modal popup is activated and you interact with the ice:menuBar that is not covered, none of the actions are fired. Looks like this is just a matter of the modal pane covering that region as well.

          <h:body styleClass="ice-skin-sam">

              <!-- MENU -->
              <ui:insert name="menu"/>

              <h:panelGroup id="winDiv" layout="block">
                  <!-- TABSET -->
                  <ui:insert name="tabset"/>
              </h:panelGroup>

          <h:outputStylesheet library="org.icefaces.component.skins" name="sam.css" />
          </h:body>

        Activity

        Brad Kroeger created issue -
        Brad Kroeger made changes -
        Field Original Value New Value
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.1 [ 10255 ]
        Assignee Priority P1
        Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
        Hide
        yip.ng added a comment -

        Do you have a sample test app. for this?

        Show
        yip.ng added a comment - Do you have a sample test app. for this?
        Hide
        Brad Kroeger added a comment -

        You can test on the application I previously sent you the link to on repo that I think you've already got running. From the menu, launch the tab for 'Screen 1', hit the 'Retrieve' button, select a row and hit the 'details' button to launch the modal popup.

        Show
        Brad Kroeger added a comment - You can test on the application I previously sent you the link to on repo that I think you've already got running. From the menu, launch the tab for 'Screen 1', hit the 'Retrieve' button, select a row and hit the 'details' button to launch the modal popup.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23919 Tue Feb 08 13:40:03 MST 2011 yip.ng ICE-6538: Modal Popup Launched from ace:tabSet Not Covering Separate Div with ice:menuBar.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Hide
        Brad Kroeger added a comment -

        When the modal popup is launched, also seeing vertical and horizontal scrollbars added to the browser suggesting the modal overlay is talking up a very large space.

        Show
        Brad Kroeger added a comment - When the modal popup is launched, also seeing vertical and horizontal scrollbars added to the browser suggesting the modal overlay is talking up a very large space.
        yip.ng made changes -
        Attachment screenshot-01.png [ 12850 ]
        Hide
        yip.ng added a comment - - edited

        Same mistake we often made in assuming positions are always relative to the document, forgetting or unaware of possible intervening positioning contexts and layers. In this case the YUI tabset has a relative position, introducing an extra positioning context.

        Fixed. See screenshot 1.

        Revision: 23919


        Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

        Show
        yip.ng added a comment - - edited Same mistake we often made in assuming positions are always relative to the document, forgetting or unaware of possible intervening positioning contexts and layers. In this case the YUI tabset has a relative position, introducing an extra positioning context. Fixed. See screenshot 1. Revision: 23919 Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Please check for the same issue on icefaces/trunk.

        Show
        Ken Fyten added a comment - Please check for the same issue on icefaces/trunk.
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8.2-EE-GA_P03 [ 10251 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23923 Tue Feb 08 16:41:01 MST 2011 yip.ng ICE-6538: Modal Popup Launched from ace:tabSet Not Covering Separate Div with ice:menuBar.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Hide
        yip.ng added a comment -

        Revision: 23923


        Modified : /icefaces/trunk/icefaces/bridge/lib/extras/style.js

        Show
        yip.ng added a comment - Revision: 23923 Modified : /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            yip.ng
            Reporter:
            Brad Kroeger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: