Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.0
-
Fix Version/s: 2.1-Beta, 3.0, EE-2.0.0.GA_P01
-
Component/s: ACE-Components
-
Labels:None
-
Environment:JSF 2.0.3 ICEfaces 2
-
Assignee Priority:P1
Description
I think this is undesirable under normal circumstances as a situation where the user has many tabs with say ice:dataTables holding many items could result in very sluggish performance when adding a new tab.
<ace:tabSet id="tabSet"
clientSide="true"
orientation="bottom"
selectedIndex="#{tabset.visibleTab}"
rendered="#{not empty tabset.tabs}" >
<c:forEach items="#{tabset.tabs}" var="tab">
<ace:tabPane label="#{tab.label}" >
<ui:include src="#{tab.include}" />
</ace:tabPane>
</c:forEach>
</ace:tabSet>
Issue Links
- depends on
-
ICE-6728
Add client-side cache support for ace:tabPane within a 'clientSide=false'
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Ken Fyten [ ken.fyten ] |
| Salesforce Case | [] | |
| Fix Version/s | 2.0.1 [ 10255 ] | |
| Assignee Priority | P1 | |
| Assignee | Ken Fyten [ ken.fyten ] | Mark Collette [ mark.collette ] |
| Salesforce Case | [] | |
| Assignee | Mark Collette [ mark.collette ] | Judy Guglielmin [ judy.guglielmin ] |
This also applies to removing an ace:tabPane
| Summary | Dynamically adding ace:tabPane Results in ace:tabset Retrieving Entire Tabset Content | Dynamically adding/removing ace:tabPane Results in ace:tabset Retrieving Entire Tabset Content |
| Salesforce Case | [] |
| Assignee | Judy Guglielmin [ judy.guglielmin ] | Ken Fyten [ ken.fyten ] |
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
| Salesforce Case | [] | |
| Fix Version/s | 2.1 [ 10241 ] | |
| Fix Version/s | 2.0.1 [ 10255 ] |
This was solved by ICE-6728.
Care has to be taken to limit dom changes, so we don't want generated ids that can shift when tabs are added and removed.
<ice:tabSet id="tbset">
<c:forEach id="cForEachId" items="#
" var="tab">
<ice:tabPane label="#
" id="tab_#
{tab.id}"><f:subview id="sub_#{tab.id}
">
<h:panelGroup id="pnlGrp">
<h3>something on the pane</h3>
<h:outputText id="spn" value="#
"/>
</h:panelGroup>
<iframe src="http://www.intel.com/"/>
</f:subview>
</ice:tabPane>
</c:forEach>
</ice:tabSet>
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | EE-2.0.0.GA_P01 [ 10271 ] | |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 2.1-Beta [ 10291 ] | |
| Fix Version/s | 2.1 [ 10241 ] |
| Fix Version/s | 3.0 [ 10241 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Since we don't currently have dom insert capabilty, but rather dom replace, the trick is to already have rendered a place-holder for future content. For ace:tabSet, we could render some tuned number of future place-holder tabPane root divs, each styled to be hidden. Then, when a tab is added, the first place-holder will be swapped out for an actual tabPane, styled to no longer be hidden. The key is that as tabs are added and removed, they are taken from and returned to the pool of place-holders, so that the dom element child count does not vary, which would cause then all to be dom updated.