ICEfaces
  1. ICEfaces
  2. ICE-6522

TouchSessionFilter should never create a session if one does not already exist.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2a, 1.8.2-EE-GA_P02
    • Fix Version/s: 1.8.3, EE-1.8.2.GA_P03
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces

      Description

      The TouchSessionFilter is designed to "touch" the session in a way such that the ICEfaces session monitoring code is notified that activity is taking place. The code in question:

      ...
              try {
                  HttpServletRequest request = (HttpServletRequest) servletRequest;
                  HttpSession session = request.getSession();
                  if (session != null) {
      ...

       currently creates a session if one doesn't already exist which can lead to confusion in the framework because the the new session will contain a new ice.session value which does not match the existing ice.session value that comes in with the request.

      The mismatch will be logged as an error and the ICEfaces framework will assume that the session has expired.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23868 Tue Feb 01 10:34:26 MST 2011 deryk.sinotte ICE-6522: ensure that filter does not create a new session if one does not already exist for the current request
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/TouchSessionFilter.java

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: