ICEfaces
  1. ICEfaces
  2. ICE-6481

DOM update for entire document does not evaluate JS code referenced in <head> on IE browsers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces EE 2, IE browsers
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      When a DOM update for entire document is received by the JSF bridge the code referenced in the 'head' element of the updated is ignored.
      This JIRA is a spin-off of ICE-6008.

      This issue is a result of a deficiency in Mojarra JSF up to and including JSF 2.1.

      This JIRA is to capture work done in ICEfaces EE to provide a solution to this issue that is additive to the ICEfaces 2 open-source library (will be delivered via a new icefaces-ee.jar).

        Activity

        Hide
        Mircea Toma added a comment -

        Implemented http://java.net/jira/browse/JAVASERVERFACES-1790 fix in ICEfaces EE by using callbacks offered by the ICEfaces bridge. The implementation evaluates referenced or inlined only if it was not evaluated before.

        Show
        Mircea Toma added a comment - Implemented http://java.net/jira/browse/JAVASERVERFACES-1790 fix in ICEfaces EE by using callbacks offered by the ICEfaces bridge. The implementation evaluates referenced or inlined only if it was not evaluated before.
        Hide
        Mircea Toma added a comment -

        Added test application for verifying the fix in IE. Usage is described in the application pages.

        Show
        Mircea Toma added a comment - Added test application for verifying the fix in IE. Usage is described in the application pages.
        Hide
        Mircea Toma added a comment -

        The fix is effective only when the document found in the DOM update is not valid XML, commenting it out for now.

        Show
        Mircea Toma added a comment - The fix is effective only when the document found in the DOM update is not valid XML, commenting it out for now.
        Hide
        Mircea Toma added a comment -

        Inserted new component resource in the 'head' to run JS code that tests when 'head' update is applied as expected. The test is used after a javax.faces.ViewRoot update to determine if the JSF+IE fix needs to be executed.
        The test case was enhanced to render invalid XML markup so that the JSF bug is triggered, thus exercising the current fix.

        Show
        Mircea Toma added a comment - Inserted new component resource in the 'head' to run JS code that tests when 'head' update is applied as expected. The test is used after a javax.faces.ViewRoot update to determine if the JSF+IE fix needs to be executed. The test case was enhanced to render invalid XML markup so that the JSF bug is triggered, thus exercising the current fix.
        Hide
        Deryk Sinotte added a comment -

        Looks like a the common.xml build file was checked in inadvertently instead of the test case. Perhaps when Mircea gets back he can take a look but it's low priority. I've reverted the common.xml file to correct the issue reported for ICE-6513.

        Show
        Deryk Sinotte added a comment - Looks like a the common.xml build file was checked in inadvertently instead of the test case. Perhaps when Mircea gets back he can take a look but it's low priority. I've reverted the common.xml file to correct the issue reported for ICE-6513.
        Hide
        Mandeep Hayher added a comment -

        icefaces-ee2 trunk revision# 26189
        server: tomcat6
        Browser: FF3.6 , IE6,7,8 & Chrome8

        page B — updated by script contained in the "head" title is not displayed after navigating to PageB.
        The problem can be reproduced on all browsers

        Show
        Mandeep Hayher added a comment - icefaces-ee2 trunk revision# 26189 server: tomcat6 Browser: FF3.6 , IE6,7,8 & Chrome8 page B — updated by script contained in the "head" title is not displayed after navigating to PageB. The problem can be reproduced on all browsers
        Hide
        Mircea Toma added a comment -

        Fixed test case build to include icefaces-ee.jar and icefaces.jar in the resulting WAR file.
        icefaces-ee/icefaces-ee/core and icefaces-ee/icefaces/core need to be build before generating the WAR file.

        Show
        Mircea Toma added a comment - Fixed test case build to include icefaces-ee.jar and icefaces.jar in the resulting WAR file. icefaces-ee/icefaces-ee/core and icefaces-ee/icefaces/core need to be build before generating the WAR file.
        Hide
        Mircea Toma added a comment -

        There's still a JS error in all the browsers with the exception of IE.

        Show
        Mircea Toma added a comment - There's still a JS error in all the browsers with the exception of IE.
        Hide
        Mircea Toma added a comment -

        It seems that even non-IE browsers are not evaluating the head if the HTML markup is XML invalid, so the original fix is enabled for all browsers. Added also a fix for non-IE browsers to avoid having the bridge configuration lost during 'body' element update.

        Show
        Mircea Toma added a comment - It seems that even non-IE browsers are not evaluating the head if the HTML markup is XML invalid, so the original fix is enabled for all browsers. Added also a fix for non-IE browsers to avoid having the bridge configuration lost during 'body' element update.
        Hide
        Mandeep Hayher added a comment -

        icefaces-ee2 trunk revision# 26273
        server: tomcat6
        Browser: FF3.6 , IE6,7,8 & Chrome8

        Problem still exists.

        Show
        Mandeep Hayher added a comment - icefaces-ee2 trunk revision# 26273 server: tomcat6 Browser: FF3.6 , IE6,7,8 & Chrome8 Problem still exists.
        Hide
        Mircea Toma added a comment -

        I re-verified but cannot see any problems. The title of the document is changed after the navigation is executed. Tested with IE and FF.

        Show
        Mircea Toma added a comment - I re-verified but cannot see any problems. The title of the document is changed after the navigation is executed. Tested with IE and FF.
        Hide
        Mandeep Hayher added a comment -

        icefaces-ee2 trunk revision# 26294
        server: tomcat6
        Browser: FF3.6 , IE6,7,8 & Chrome8

        Tested successfully.

        Show
        Mandeep Hayher added a comment - icefaces-ee2 trunk revision# 26294 server: tomcat6 Browser: FF3.6 , IE6,7,8 & Chrome8 Tested successfully.
        Hide
        Mircea Toma added a comment -

        Moved JSF fix from icefaces-ee to icefaces2 since the fix addresses all the browsers. The fix resides in a separate file that's merged by the build into the final bridge code.

        Show
        Mircea Toma added a comment - Moved JSF fix from icefaces-ee to icefaces2 since the fix addresses all the browsers. The fix resides in a separate file that's merged by the build into the final bridge code.
        Hide
        Mircea Toma added a comment -

        Moved also viewRootUpdate test application into ICEfaces 2 samples/core/test directory.

        Show
        Mircea Toma added a comment - Moved also viewRootUpdate test application into ICEfaces 2 samples/core/test directory.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: