[ICE-6474] CLONE -Can't send in an array of objects as the values for a selectOneMenu component - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0
Fix Version/s: 2.0.1
Component/s: ICE-Components
Labels:
None
Environment:
jsf2.0, ICEfaces-2.0

ICEsoft Forum Reference:
http://www.icefaces.org/JForum/posts/list/17691.page
Affects:

Documentation (User Guide, Ref. Guide, etc.)
Workaround Exists:

Yes
Workaround Description:

Hide
Use a list/array that consists of SelectItem objects.

For Example:
        cityList = new ArrayList<SelectItem>();
        cityList.add(new SelectItem("TORONTO", "TORONTO"));
        cityList.add(new SelectItem("CALGARY", "CALGARY"));

Show
Use a list/array that consists of SelectItem objects. For Example:         cityList = new ArrayList<SelectItem>();         cityList.add(new SelectItem("TORONTO", "TORONTO"));         cityList.add(new SelectItem("CALGARY", "CALGARY"));

Description

With the JSF <h:selectOneMenu> component, you can use an array of objects for the selectOneMenu options. Using the same set of objects for an <ice:selectOneMenu> does not show the options. For example:

JSF Component Code:
<h:selectOneMenu value="#{backingBean.city}" >
<f:selectItems value="#{backingBean.cities}"/>
</h:selectOneMenu>

Backing Bean Code:
public City[] getCities() {
return City.values();
}

Testing with ICEfaces 1.8.x and JSF 1.2 showed that the array of objects does not work for both the JSF and ICEfaces components. It looks like something was changed on the JSF component and this has not been changed with the ICEfaces components.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
ICE-6474.war

27/Jan/11 7:52 AM

6.31 MB

Wilson Bogado
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/ice6474/City.class 1 kB

WEB-INF/classes/ice6474/TestBean.class 1 kB

WEB-INF/lib/commons-beanutils.jar 223 kB

WEB-INF/lib/commons-collections.jar 554 kB

WEB-INF/lib/commons-digester.jar 137 kB

WEB-INF/lib/commons-logging.jar 30 kB

WEB-INF/lib/icefaces-compat.jar 2.59 MB

WEB-INF/lib/icefaces.jar 183 kB

WEB-INF/lib/jsf-api.jar 580 kB

WEB-INF/lib/jsf-impl.jar 1.74 MB

WEB-INF/lib/jxl.jar 689 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 148 kB

WEB-INF/web.xml 2 kB

index.xhtml 2 kB

Download Zip
Show

ICE-6474.war

27/Jan/11 7:52 AM

6.31 MB

Wilson Bogado
Hide
ICE-6474.zip

27/Jan/11 7:52 AM

17 kB

Wilson Bogado
ICE-6474/build.xml 3 kB

ICE-6474/nbproject/ant-deploy.xml 2 kB

ICE-6474/nbproject/build-impl.xml 53 kB

ICE-6474/nbproject/genfiles.properties 0.5 kB

ICE-6474/nbproject/.../private.properties 0.4 kB

ICE-6474/nbproject/project.properties 3 kB

ICE-6474/nbproject/project.xml 1 kB

ICE-6474/src/conf/MANIFEST.MF 0.0 kB

ICE-6474/src/java/ice6474/City.java 0.7 kB

ICE-6474/src/java/ice6474/TestBean.java 0.7 kB

ICE-6474/web/index.xhtml 2 kB

ICE-6474/web/META-INF/context.xml 0.1 kB

ICE-6474/web/WEB-INF/web.xml 2 kB

Download Zip
Show

ICE-6474.zip

27/Jan/11 7:52 AM

17 kB

Wilson Bogado

Issue Links

depends on

ICE-6107 Can't send in an array of objects as the values for a selectOneMenu component

Closed

Activity

Ascending order - Click to sort in descending order

Wilson Bogado created issue - 14/Jan/11 6:22 AM

Hide

Permalink

Wilson Bogado added a comment - 14/Jan/11 6:37 AM

The following example still does not work:

<ice:selectOneMenu value="#

{testBean.itemCode}

">
<f:selectItems value="#

{testBean.itemList}

" var="item" itemValue="#

{item.code}

" itemLabel="#

{item.name}

"/>
</ice:selectOneMenu>

Where:
itemCode is an Integer
itemList is a List<Item>
item.code is an Integer
item.nam is a String

When running this example, ICEFaces seems to try to assign item.toString() to itemCode which results in a conversion error.
h:selectOneMenu works as expected.

Show

Wilson Bogado added a comment - 14/Jan/11 6:37 AM The following example still does not work: <ice:selectOneMenu value="# {testBean.itemCode} "> <f:selectItems value="# {testBean.itemList} " var="item" itemValue="# {item.code} " itemLabel="# {item.name} "/> </ice:selectOneMenu> Where: itemCode is an Integer itemList is a List<Item> item.code is an Integer item.nam is a String When running this example, ICEFaces seems to try to assign item.toString() to itemCode which results in a conversion error. h:selectOneMenu works as expected.

Hide

Permalink

Wilson Bogado added a comment - 14/Jan/11 6:40 AM

Issue ~~ICE-6107~~ does not seem to be resolved.

Show

Wilson Bogado added a comment - 14/Jan/11 6:40 AM Issue ICE-6107 does not seem to be resolved.

Wilson Bogado made changes - 14/Jan/11 6:40 AM

Field	Original Value	New Value
Link		This issue depends on ~~ICE-6107~~ [ ~~ICE-6107~~ ]

Ken Fyten made changes - 14/Jan/11 11:59 AM

Fix Version/s		2.0.1 [ 10255 ]
Fix Version/s	2.0.0 [ 10230 ]
Affects Version/s		2.0.0 [ 10230 ]
Affects Version/s	2.0-Beta1 [ 10231 ]
Affects Version/s	2.0-Beta2 [ 10242 ]

Ken Fyten made changes - 14/Jan/11 4:40 PM

Assignee Priority

Ken Fyten made changes - 19/Jan/11 4:21 PM

Assignee Priority

Adnan Durrani made changes - 25/Jan/11 11:50 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Hide

Permalink

Adnan Durrani added a comment - 26/Jan/11 10:52 PM

I have tested ~~ICE-6107~~ with enum and its working fine.

<ice:selectOneMenu partialSubmit="true" value="#

{selectionTags.city}">
<f:selectItems
value="#{selectionTags.cities}"/>
</ice:selectOneMenu>

<h:outputText value="Selected City : #{selectionTags.city}

" />

--------------

Bean
private City city;

public City getCity()

{ return city; }

public void setCity(City city)

{ this.city = city; }

public City[] getCities()

{ return City.values(); }

public enum City

{ TORONTO, CALGARY; }

Show

Adnan Durrani added a comment - 26/Jan/11 10:52 PM I have tested ICE-6107 with enum and its working fine. <ice:selectOneMenu partialSubmit="true" value="# {selectionTags.city}"> <f:selectItems value="#{selectionTags.cities}"/> </ice:selectOneMenu> <h:outputText value="Selected City : #{selectionTags.city} " /> -------------- Bean private City city; public City getCity() { return city; } public void setCity(City city) { this.city = city; } public City[] getCities() { return City.values(); } public enum City { TORONTO, CALGARY; }

Hide

Permalink

Adnan Durrani added a comment - 26/Jan/11 10:54 PM

Can you please attach a working .war including source code?

Show

Adnan Durrani added a comment - 26/Jan/11 10:54 PM Can you please attach a working .war including source code?

Hide

Permalink

Wilson Bogado added a comment - 27/Jan/11 7:52 AM

I just realized that the ICEfaces selectOneMenu behaves differently when the items are in a List than when they are in an array. In the attached example I try to demonstrate what I have found out. I hope this helps you figure out the problem.

Show

Wilson Bogado added a comment - 27/Jan/11 7:52 AM I just realized that the ICEfaces selectOneMenu behaves differently when the items are in a List than when they are in an array. In the attached example I try to demonstrate what I have found out. I hope this helps you figure out the problem.

Wilson Bogado made changes - 27/Jan/11 7:52 AM

Attachment		ICE-6474.zip [ 12827 ]
Attachment		ICE-6474.war [ 12828 ]

Hide

Permalink

Adnan Durrani added a comment - 27/Jan/11 11:23 PM

Thanks Wilson. This test app helped a lot. I am close to fix this bug.

Show

Adnan Durrani added a comment - 27/Jan/11 11:23 PM Thanks Wilson. This test app helped a lot. I am close to fix this bug.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23852	Sun Jan 30 12:34:28 MST 2011	adnan.durrani	Fix for ~~ICE-6474~~ (CLONE -Can't send in an array of objects as the values for a selectOneMenu component)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java

Hide

Permalink

Adnan Durrani added a comment - 30/Jan/11 1:35 PM

Fixed.

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\MenuRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\MenuRenderer.java
Completed: At revision: 23852

Show

Adnan Durrani added a comment - 30/Jan/11 1:35 PM Fixed. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\MenuRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\MenuRenderer.java Completed: At revision: 23852

Adnan Durrani made changes - 30/Jan/11 1:35 PM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Mircea Toma added a comment - 01/Feb/11 3:58 PM

The fix for this issue has created the regression recorded in ICE-6514. The explanation for the fix is found here: http://jira.icefaces.org/browse/ICE-6514?focusedCommentId=32808&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_32808

Show

Mircea Toma added a comment - 01/Feb/11 3:58 PM The fix for this issue has created the regression recorded in ICE-6514. The explanation for the fix is found here: http://jira.icefaces.org/browse/ICE-6514?focusedCommentId=32808&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_32808

Ken Fyten made changes - 18/Mar/11 6:08 PM

Issue Type

Bug [ 1 ]

Improvement [ 4 ]

Ken Fyten made changes - 18/Mar/11 6:28 PM

Assignee Priority

Ken Fyten made changes - 28/Mar/12 6:17 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Adnan Durrani

Reporter:

Wilson Bogado

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

14/Jan/11 6:22 AM

Updated:

28/Mar/12 6:17 PM

Resolved:

30/Jan/11 1:35 PM