ICEfaces
  1. ICEfaces
  2. ICE-6413

REGRESSION: Modal panelPopup not removing modality when "rendered=false" is set.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA_P02, 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: Bridge, ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces2/trunk, ICEfaces/trunk
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)
    • Workaround Exists:
      Yes
    • Workaround Description:
      Hide
      The workaround is to just use the visible tag and not the rendered tag for the ice:panelPopup component. So your code would be:

       <ice:panelPopup visible="#{BusinessInfoBean.showBusinessFinder}" autoCentre="true" modal="true">
      Show
      The workaround is to just use the visible tag and not the rendered tag for the ice:panelPopup component. So your code would be:  <ice:panelPopup visible="#{BusinessInfoBean.showBusinessFinder}" autoCentre="true" modal="true">

      Description

      This seems to be a regression from changes made in ICE-5652. Previously, if an application had a modal panelPopup displayed and set "rendered=false", it would remove the modality layer and the popup. Now, the modality layer is not cleared.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        ICEsoft Forum Reference http://www.icefaces.org/JForum/posts/list/18289.page
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Fix Version/s 1.8.2-EE-GA_P03 [ 10251 ]
        Assignee Priority P1
        Assignee Mircea Toma [ mircea.toma ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.1 [ 10255 ]
        Fix Version/s 2.0.0 [ 10230 ]
        Fix Version/s 1.8.2-EE-GA_P03 [ 10251 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23715 Thu Dec 23 14:49:50 MST 2010 mircea.toma ICE-6413 Introduced mechanism for notifying about DOM element removal. Use mechanism in panel popup renderer to execute modal cleanup code when the popup stops being rendered.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/javascript/application.js
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23716 Thu Dec 23 15:02:14 MST 2010 mircea.toma ICE-6413 Introduced mechanism for notifying about DOM element removal. Use mechanism in panel popup renderer to execute modal cleanup code when the popup stops being rendered.
        Files Changed
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/javascript/application.js
        Hide
        Mircea Toma added a comment -

        Introduced callback registration mechanism for notifying about DOM element removal. ice.onElementRemoval(id, callback) function allows registering a callback that will be eventually executed when the element with the specified ID is removed from the DOM document.

        Used this new mechanism in panel popup renderer to setup a callback for running the modal cleanup code when the popup stops being rendered.

        Show
        Mircea Toma added a comment - Introduced callback registration mechanism for notifying about DOM element removal. ice.onElementRemoval(id, callback) function allows registering a callback that will be eventually executed when the element with the specified ID is removed from the DOM document. Used this new mechanism in panel popup renderer to setup a callback for running the modal cleanup code when the popup stops being rendered.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: