Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Invalid
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: None
-
Component/s: Framework
-
Labels:None
-
Environment:Found with Liferay 6.0 + PortletFaces-Bridge 2.0.0-BETA3 but it's not portlet related.
Description
<my-comp:dataPaginator for=":myData" />
<ice:dataTable id="myData">
</ice:dataTable>
The colon in front of :myData indicates that the search should start from the root of the tree. Sadly, CoreComponentUtils.findComponent(UIComponent, String) is bailing out too early, not recursing through the component tree enough to find a matching clientId.
Here's a patch to fix:
===================================================================
--- /icefaces-src/2.0-trunk/icefaces/compat/core/src/main/java/com/icesoft/util/CoreComponentUtils.java (revision 23550)
+++ /icefaces-src/2.0-trunk/icefaces/compat/core/src/main/java/com/icesoft/util/CoreComponentUtils.java (working copy)
@@ -162,6 +162,12 @@
component = child;
break;
}
+ if (component == null) {
+ component = findComponent(child, componentId);
+ if (component != null) {
+ break;
+ }
+ }
}
return component;
}
Issue Links
- depends on
-
ICE-6659
ice:inputText required validation not happening properly inside portlet
-
- Closed
-
-
ICE-6667
Portlets: CoreComponentUtils findComponent not absolutely finding components
-
- Closed
-
- duplicates
-
ICE-6226
Unable to use ice:dataPaginator compat component as a JSF 2.0 composite component
-
- Closed
-
Activity
Yes they are inside an h:form – I didn't set the prependId value, so the default would be true according to the VDLDocs: http://javaserverfaces.java.net/nonav/docs/2.0/pdldocs/facelets/h/form.html
I would like to have prependId=true so that the child elements are namespaced well, in case I have multiple forms.
So what you'd have is:
<h:form id="something">
<my-comp:dataPaginator for=":myData" />
<ice:dataTable id="myData">
The appropriate for values would either be:
:something:myData
or
myData
| Field | Original Value | New Value |
|---|---|---|
| Comment | [ Can you please provide the whole .xhtml page, so we can see the parents of these components, to see what the NamingContainers in the parentage are. ] |
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<ui:composition xmlns:c="http://java.sun.com/jsp/jstl/core" xmlns:f="http://java.sun.com/jsf/core" xmlns:h="http://java.sun.com/jsf/html"
xmlns:aui="http://portletfaces.org/alloyfaces/aui" xmlns:aui-cc="http://portletfaces.org/alloyfaces/aui-cc"
xmlns:liferay-ui="http://portletfaces.org/liferayfaces/liferay-ui" xmlns:ice="http://www.icesoft.com/icefaces/component"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:icecore="http://www.icefaces.org/icefaces/core">
<icecore:config render="true" />
<ice:form id="f2" styleClass="aui-form dlp">
<aui-cc:messages globalOnly="true" layout="table" />
<ice:panelGroup rendered="#
">
<aui:layout>
<aui:button-row>
<aui-cc:button type="submit">
<f:actionListener for="click" binding="#
" />
</aui-cc:button>
<aui-cc:button immediate="true" type="cancel">
<f:actionListener for="click" binding="#
" />
</aui-cc:button>
</aui:button-row>
<hr />
</aui:layout>
</ice:panelGroup>
<ice:panelGroup rendered="#
">
<aui:layout>
<aui:column styleClass="aui-w100">
<aui:fieldset>
<aui-cc:select inlineMessage="true" label="#
" required="true" value="#
{usersModelBean.searchCriteria.active}">
<f:selectItem itemLabel="#
" itemValue="true" />
<f:selectItem itemLabel="#
" itemValue="false" />
</aui-cc:select>
<aui:button-row>
<aui-cc:button type="submit" label="#
">
<f:actionListener for="click" binding="#
" />
</aui-cc:button>
</aui:button-row>
</aui:fieldset>
<liferay-ui:ice-page-iterator for=":users" />
<ice:dataTable id="users" rows="2" value="#
" var="user">
<ice:column>
<liferay-ui:icon image="edit" listItemStyle="list-style-type: none;">
<f:param name="userId" value="#
" />
<f:actionListener for="click" binding="#
" />
</liferay-ui:icon>
</ice:column>
<ice:column>
<f:facet name="header">
<h:outputText value="#
" />
</f:facet>
<h:outputText value="#
" />
</ice:column>
<ice:column>
<f:facet name="header">
<h:outputText value="#
" />
</f:facet>
<h:outputText value="#
" />
</ice:column>
<ice:column>
<f:facet name="header">
<h:outputText value="#
" />
</f:facet>
<h:outputText value="#
" />
</ice:column>
</ice:dataTable>
<liferay-ui:info message="there-are-no-results" rendered="#
" />
</aui:column>
</aui:layout>
</ice:panelGroup>
</ice:form>
</ui:composition>
Note that I have ":users" as the value of the "for" attribute. I never used to have to put the colon with JSF 1.2 and Facelets. But now with JSF 2.0 Facelets, the liferay-ui:ice-page-iterator composite component is actually a NamingContainer. So I think one problem here is that CoreComponentUtils tries to recurse up until it hits a NamingContainer and doesn't expect it – it bumps into the UIComponent (the component represented by "cc") which is actually a NamingContainer, and it stops. The other problem (described in the title of this issue) is that if you start at the root, by putting a colon character as the first character in the "for" attribute, then it doesn't recurse all the way down through all the children.
Forgot to mention that there is an ice:dataPaginator inside the liferay-ui:ice-page-iterator composite component. The datapaginator can't find the component associated with the clientId in the "for" attribute now with JSF 2.0 Facelets.
| Salesforce Case | [] | |
| Fix Version/s | 2.0.1 [ 10255 ] | |
| Assignee | Mark Collette [ mark.collette ] |
Using the colon I was able to get it to work. So you need to give the proper DOM hierarchy and it works. But would be good if it works as suggested by Neil.
| Salesforce Case | [5007000000FZuRM] |
| Link | This issue depends on ICE-5721 [ ICE-5721 ] |
| Fix Version/s | 2.1 [ 10241 ] | |
| Fix Version/s | 2.0.1 [ 10255 ] |
It's likely that the rationale and fix provided for ICE-6659 will fix this problem as well but we'll need the original reporter to test and verify.
Assigning to Neil for verification.
| Assignee | Mark Collette [ mark.collette ] | Neil Griffin [ ngriffin7a ] |
I did test against an inputText nested in a panelSeries in a portlet and, with the id provided by the PortletFaces UIViewRoot implementation, the findComponent algorithm did work and the "required" validation operated as expected.
The main research and documenation on the fix for this issue is in ICE-6659 so I'm linking to that case.
I tested the pf-directory-portlet (uses LiferayFaces, which in turn tests this bug) and the ICEfaces trunk revision 24185 (today). Unfortunately it still doesn't work. Assigning back to Deryk.
| Assignee | Neil Griffin [ ngriffin7a ] | Deryk Sinotte [ deryk.sinotte ] |
| Assignee | Deryk Sinotte [ deryk.sinotte ] | Ken Fyten [ ken.fyten ] |
Investigate whether a bean method can plug in an alternate findComponent strategy:
<ice:label for="#
{bean.find('comp27')}" />
or perhaps a custom EL resolver.
| Fix Version/s | 3.1 [ 10312 ] | |
| Fix Version/s | 3.0 [ 10241 ] |
| Fix Version/s | 3.2 [ 10338 ] | |
| Fix Version/s | 3.1 [ 10312 ] |
| Fix Version/s | 3.3 [ 10370 ] | |
| Fix Version/s | 3.2 [ 10338 ] |
| Fix Version/s | 3.3 [ 10370 ] |
| Assignee | Ken Fyten [ ken.fyten ] |
Marking as Closed / Invalid as part of legacy ICEfaces 1.x, 2.x JIRA cleanup.
Note: This issue may be resolved in a newer ICEfaces release, available here: http://www.icesoft.org/java/downloads/icefaces-downloads.jsf
If the issue persists with the current ICEfaces release, please create a new JIRA for it.
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Invalid [ 6 ] |
Are those components within a form? Does the form have prependId=false?