[ICE-6393] Compat components incorrectly escaping certain unicode characters - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0-Beta2
Fix Version/s: 2.0.0
Component/s: ICE-Components
Labels:
None
Environment:
ICEfaces

ICEsoft Forum Reference:
http://www.icefaces.org/JForum/posts/list/18290.page#66455
Workaround Exists:

Yes
Workaround Description:
embed an ice:outputText within the ice:commandLink

Description

The following xhtml source results in the ice:commandLink value displaying Nächster

        <ice:outputText value="Nächster" /><br/>
        <ice:commandLink value="Nächster" /><br/>
        <ice:commandLink ><ice:outputText value="Nächster" /></ice:commandLink><br/>
        <h:commandLink value="Nächster" /><br/>

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

screenshot-01.png

175 kB

20/Dec/10 12:26 PM
screenshot-02.png

70 kB

20/Dec/10 2:04 PM
screenshot-03.png

69 kB

20/Dec/10 2:07 PM
screenshot-04.png

225 kB

20/Dec/10 2:29 PM
screenshot-05.png

264 kB

20/Dec/10 3:12 PM
screenshot-06.png

261 kB

20/Dec/10 3:33 PM
screenshot-07.png

214 kB

20/Dec/10 3:36 PM
screenshot-08.png

214 kB

20/Dec/10 3:38 PM

Issue Links

blocks

ICE-6287 iso-8859-1 chars become UTF-8 in IE

Closed

Activity

Ascending order - Click to sort in descending order

Ted Goddard created issue - 16/Dec/10 1:08 PM

Ted Goddard made changes - 16/Dec/10 1:09 PM

Field	Original Value	New Value
Workaround Description		embed an ice:outputText within the ice:commandLink
Workaround Exists		[Yes]
Salesforce Case		[]

Hide

Permalink

Ted Goddard added a comment - 16/Dec/10 1:11 PM

Likely instigated by the fix for ~~ICE-5854~~. We must be careful not to introduce a cross site scripting vulnerability when adjusting this fix.

Show

Ted Goddard added a comment - 16/Dec/10 1:11 PM Likely instigated by the fix for ICE-5854 . We must be careful not to introduce a cross site scripting vulnerability when adjusting this fix.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23577	Thu Dec 16 13:52:07 MST 2010	ted.goddard	commandLink value is escaped via DOMUtils.createTextNode and does not require additional escaping (~~ICE-6393~~)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java

Ted Goddard made changes - 16/Dec/10 2:52 PM

Assignee

Ted Goddard [ ted.goddard ]

Hide

Permalink

Ted Goddard added a comment - 16/Dec/10 2:53 PM

DOMUtils.createTextNode is performing escaping, so this does not need to be done by CommandLinkRenderer itself.

Show

Ted Goddard added a comment - 16/Dec/10 2:53 PM DOMUtils.createTextNode is performing escaping, so this does not need to be done by CommandLinkRenderer itself.

Ted Goddard made changes - 16/Dec/10 2:53 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		2.0.0 [ 10230 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Ken Fyten added a comment - 20/Dec/10 10:50 AM

It looks like more compat components need to be modified to remove their specific escaping calls, since this will result in double escaping:

SelectIntputTextRenderer.java
MenuItemRenderer.java
PanelTabSetRenderer.java
OutputProgress.java
OutputChart.java
OutputConnectionStatusRenderer.java

Show

Ken Fyten added a comment - 20/Dec/10 10:50 AM It looks like more compat components need to be modified to remove their specific escaping calls, since this will result in double escaping: SelectIntputTextRenderer.java MenuItemRenderer.java PanelTabSetRenderer.java OutputProgress.java OutputChart.java OutputConnectionStatusRenderer.java

Ken Fyten made changes - 20/Dec/10 10:50 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]
Assignee Priority		P1
Assignee	Ted Goddard [ ted.goddard ]	Ken Fyten [ ken.fyten ]

Ken Fyten made changes - 20/Dec/10 10:50 AM

Summary	ice:commandLink incorrectly escapes certain unicode characters	Compat components incorrectly escapes certain unicode characters
Salesforce Case		[]

Ken Fyten made changes - 20/Dec/10 10:51 AM

Summary	Compat components incorrectly escapes certain unicode characters	Compat components incorrectly escaping certain unicode characters
Salesforce Case		[]

Ken Fyten made changes - 20/Dec/10 11:15 AM

Salesforce Case		[]
Assignee	Ken Fyten [ ken.fyten ]	Yip Ng [ yip.ng ]

Ken Fyten made changes - 20/Dec/10 11:22 AM

ICEsoft Forum Reference	http://www.icefaces.org/JForum/posts/list/0/18271.page	http://www.icefaces.org/JForum/posts/list/18290.page#66455
Salesforce Case		[]

yip.ng made changes - 20/Dec/10 12:26 PM

Attachment

screenshot-01.png [ 12778 ]

yip.ng made changes - 20/Dec/10 2:04 PM

Attachment

screenshot-02.png [ 12779 ]

yip.ng made changes - 20/Dec/10 2:07 PM

Attachment

screenshot-03.png [ 12780 ]

yip.ng made changes - 20/Dec/10 2:29 PM

Attachment

screenshot-04.png [ 12781 ]

Hide

Permalink

yip.ng added a comment - 20/Dec/10 2:43 PM - edited

No double escaping in OutputProgress. See screenshots 7 and 8.

Show

yip.ng added a comment - 20/Dec/10 2:43 PM - edited No double escaping in OutputProgress. See screenshots 7 and 8.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23652	Mon Dec 20 15:05:16 MST 2010	yip.ng	~~ICE-6393~~: Compat components incorrectly escaping certain unicode characters.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

yip.ng made changes - 20/Dec/10 3:12 PM

Attachment

screenshot-05.png [ 12782 ]

yip.ng made changes - 20/Dec/10 3:33 PM

Attachment

screenshot-06.png [ 12784 ]

yip.ng made changes - 20/Dec/10 3:36 PM

Attachment

screenshot-07.png [ 12785 ]

yip.ng made changes - 20/Dec/10 3:38 PM

Attachment

screenshot-08.png [ 12786 ]

Hide

Permalink

Ted Goddard added a comment - 20/Dec/10 3:48 PM

If the text editor supports unicode, the test can be created as in the description with unicode text directly in the component values.

Show

Ted Goddard added a comment - 20/Dec/10 3:48 PM If the text editor supports unicode, the test can be created as in the description with unicode text directly in the component values.

Hide

Permalink

yip.ng added a comment - 20/Dec/10 3:57 PM

No double escaping in OutputChart. See screenshot 6.

Show

yip.ng added a comment - 20/Dec/10 3:57 PM No double escaping in OutputChart. See screenshot 6.

Hide

Permalink

yip.ng added a comment - 20/Dec/10 4:12 PM

MenuItemRenderer, OutputConnectionStatusRenderer and PanelTabSetRenderer done. See screenshots 3, 4, 5.

Two occurrences of escapeAnsi() in SelectInputTextRenderer. One was removed. (It was nested within createTextNode().) The other still not sure. Not easy to test SelectInputText. Need to figure out how dictionary is generated and how to modify item labels first.

Revision: 23652

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Show

yip.ng added a comment - 20/Dec/10 4:12 PM MenuItemRenderer, OutputConnectionStatusRenderer and PanelTabSetRenderer done. See screenshots 3, 4, 5. Two occurrences of escapeAnsi() in SelectInputTextRenderer. One was removed. (It was nested within createTextNode().) The other still not sure. Not easy to test SelectInputText. Need to figure out how dictionary is generated and how to modify item labels first. Revision: 23652 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Hide

Permalink

yip.ng added a comment - 20/Dec/10 5:16 PM

No more changes required for SelectInputTextRenderer. See video at http://screencast.com/t/2Ogi9W4HSEWf.

Show

yip.ng added a comment - 20/Dec/10 5:16 PM No more changes required for SelectInputTextRenderer. See video at http://screencast.com/t/2Ogi9W4HSEWf .

Ken Fyten made changes - 20/Dec/10 5:23 PM

Link

This issue blocks ~~ICE-6287~~ [ ~~ICE-6287~~ ]

yip.ng made changes - 20/Dec/10 5:26 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 03/Jan/11 4:19 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P1

People

Assignee:

yip.ng

Reporter:

Ted Goddard

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

16/Dec/10 1:08 PM

Updated:

03/Jan/11 4:19 PM

Resolved:

20/Dec/10 5:26 PM