ICEfaces
  1. ICEfaces
  2. ICE-6350

ACE: Remove "labelPosition" attribute from the ace:checkboxButton component

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 2 Advanced Comps.
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      In order to present the desired public API for the checkboxButton, we want to remove the JSF component "labelPosition" attribute from the component, and instead hard-code it internally to the "on" setting. This will force the renderer to use the YUI comp. label rendering in all cases, which is desired.

      The second step is to modify the Rime skin for the checkboxButton to use images that work well with the centre rendered label, but with Rime-esque coloring, etc.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
        Assignee Priority P2
        Assignee Yip Ng [ yip.ng ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2 P1
        Assignee Yip Ng [ yip.ng ] Judy Guglielmin [ judy.guglielmin ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23431 Thu Dec 09 16:02:55 MST 2010 judy.guglielmin ICE-6350 but the org.icefaces.component-checkboxbutton.rime still needs to have the 5 background images for this new theme Will put comment on jira
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonMeta.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/checkboxbutton/skins/rime/checkboxButton.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
        Hide
        Judy Guglielmin added a comment -

        rev 23431 now has no labelPosition attribute for checkboxButton component. But....the org.icefaces.component.checkbox.skins.rime folder still requires the following images that are referenced in it's css file
        background-active.gif
        backgorund-disabled.gif
        background-focus.gif
        background-highlight.png (this is the one that shows when the button is selected or checked is true).
        background.png

        Show
        Judy Guglielmin added a comment - rev 23431 now has no labelPosition attribute for checkboxButton component. But....the org.icefaces.component.checkbox.skins.rime folder still requires the following images that are referenced in it's css file background-active.gif backgorund-disabled.gif background-focus.gif background-highlight.png (this is the one that shows when the button is selected or checked is true). background.png
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: