ICEfaces
  1. ICEfaces
  2. ICE-6345

ACE: tabSet w/ animation keyboard navigation issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 2.0.0
    • Fix Version/s: 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF 2, Adv. Comps tabSet component, FF 3.6, Chrome 8, etc.

      Description

      Testing of keyboard navigation with the ace-showcase app., tabSet demos shows the following issues with the Animation demo:

      - Once focus is on a tab, pressing "enter" on focussed tab selects that tab, but only half of the expected animation executes (the tab pane text fades out, but the new tab is not made visible). Once this happens the first time, the tab selection state is corrupted and multiple tabs can appear selected a the same time, but the tab pane doesn't reflect the selected tab, etc.

      Seems to work as expected when the mouse click is used to select the tab, but breaks when the "enter" key is used to select the tab. Looks like it might be related to the default "submit on enter" feature of the IF2 bridge. Perhaps the enter key should be processed by the tabSet component and not allowed to bubble up the dom.


        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Description Testing of keyboard navigation with the ace-showcase app., tabSet demos shows the following issues with the Tab Set (Server Side) demo that demonstrates use of the label facet:

        Tab Set (Server-Side):
        - Once focus is on a tab, arrow keys do not work to switch between tabs.
        - Pressing "space" or "enter" on focussed tab does not select that tab.
        - Pressing "space" or "enter" on focussed "Close" button in label facet does not close the tab.

        The expected behaviour is consistent with Tab Set (Client-Side):
        - Once focus is on a tab, arrow keys do switch between tabs (correct).
        - Pressing "space" or "enter" on focussed tab does select that tab (correct).


        Testing of keyboard navigation with the ace-showcase app., tabSet demos shows the following issues with the Animation demo:

        - Once focus is on a tab, pressing "enter" on focussed tab selects that tab, but only half of the expected animation executes (the tab pane text fades out, but the new tab is not made visible). Once this happens the first time, the tab selection state is corrupted and multiple tabs can appear selected a the same time, but the tab pane doesn't reflect the selected tab, etc.

        Seems to work as expected when the mouse click is used to select the tab, but breaks when the "enter" key is used to select the tab. Looks like it might be related to the default "submit on enter" feature of the IF2 bridge. Perhaps the enter key should be processed by the tabSet component and not allowed to bubble up the dom.


        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2 P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23488 Sun Dec 12 17:31:43 MST 2010 adnan.durrani Fix for ICE-6345 (ACE: tabSet w/ animation keyboard navigation issues)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.tab/tabset.js
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.animation/animation.js
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Adnan Durrani added a comment -

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.animation\animation.js
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.animation\animation.js
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
        Completed: At revision: 23488

        Show
        Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.animation\animation.js Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.animation\animation.js Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Completed: At revision: 23488
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Now there is a regression issue with the tabSet in general. Anytime a new tab is selected, the focus is lost from the select tab. The keyboard focus should remain on the selected tab.

        Show
        Ken Fyten added a comment - Now there is a regression issue with the tabSet in general. Anytime a new tab is selected, the focus is lost from the select tab. The keyboard focus should remain on the selected tab.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23638 Sun Dec 19 22:25:50 MST 2010 adnan.durrani Fix towards ICE-6343, ICE-6345
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/TabSetRenderer.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.tab/tabset.js
        Hide
        Adnan Durrani added a comment -

        Command: Commit
        Modified: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
        Modified: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
        Sending content: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
        Sending content: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
        Completed: At revision: 23638

        Show
        Adnan Durrani added a comment - Command: Commit Modified: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Modified: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Completed: At revision: 23638
        Adnan Durrani made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mandeep Hayher added a comment -

        Icefaces2 revision# 23643
        On FF3.6
        Anytime a new tab is selected, the focus is lost from the select tab and set on the first tab of the tabset.

        Chrome8.
        Anytime a new tab is selected, the focus is lost from the select tab and set on component tree on the left.

        Show
        Mandeep Hayher added a comment - Icefaces2 revision# 23643 On FF3.6 Anytime a new tab is selected, the focus is lost from the select tab and set on the first tab of the tabset. Chrome8. Anytime a new tab is selected, the focus is lost from the select tab and set on component tree on the left.
        Mandeep Hayher made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.1 [ 10255 ]
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1
        Priority Major [ 3 ] Minor [ 4 ]
        Ken Fyten made changes -
        Fix Version/s 2.1 [ 10241 ]
        Fix Version/s 2.0.1 [ 10255 ]
        Hide
        Ken Fyten added a comment -

        Since we have adopted JQuery effects for the IF 2.1 animation component, this JIRA is no longer considered relevant.

        Show
        Ken Fyten added a comment - Since we have adopted JQuery effects for the IF 2.1 animation component, this JIRA is no longer considered relevant.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Invalid [ 6 ]

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: