ICEfaces
  1. ICEfaces
  2. ICE-6343

ACE: tabSet w/ label facet keyboard navigation issues

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            IF 2, Adv. Comps tabSet component, FF 3.6, Chrome 8, etc.
          • Assignee Priority:
            P1

            Description

            Testing of keyboard navigation with the ace-showcase app., tabSet demos shows the following issues with the Tab Set (Server Side) demo that demonstrates use of the label facet:

            Tab Set (Server-Side):
            - Once focus is on a tab, arrow keys do not work to switch between tabs.
            - Pressing "space" or "enter" on focussed tab does not select that tab.
            - Pressing "space" or "enter" on focussed "Close" button in label facet does not close the tab.

            The expected behaviour is consistent with Tab Set (Client-Side):
            - Once focus is on a tab, arrow keys do switch between tabs (correct).
            - Pressing "space" or "enter" on focussed tab does select that tab (correct).


              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0.0 [ 10230 ]
              Assignee Priority P2
              Assignee Adnan Durrani [ adnan.durrani ]
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Priority P2 P1
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23487 Sun Dec 12 16:45:11 MST 2010 adnan.durrani Fix for ICE-6343 (ACE: tabSet w/ label facet keyboard navigation issues)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/TabSetRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.tab/tabset.js
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
              Completed: At revision: 23487

              Show
              Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Completed: At revision: 23487
              Adnan Durrani made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              You can now use arrows to switch tabs as expected, and tab focus onto the close buttons, etc. However, after a new tab is selected, the focus is being lost or moved to the incorrect element (server-side tabs only). The focus should remain on the tab that has been selected.

              To reproduce, view the Server-side tab demo in ace-showcase. Click on the leftmost tab (tab1). Use the right arrow to move focus to tab 2. Use the space bar or enter key to select tab2, tab 2 is selected, but focus is moved off tab 2 incorrectly.

              Show
              Ken Fyten added a comment - You can now use arrows to switch tabs as expected, and tab focus onto the close buttons, etc. However, after a new tab is selected, the focus is being lost or moved to the incorrect element (server-side tabs only). The focus should remain on the tab that has been selected. To reproduce, view the Server-side tab demo in ace-showcase. Click on the leftmost tab (tab1). Use the right arrow to move focus to tab 2. Use the space bar or enter key to select tab2, tab 2 is selected, but focus is moved off tab 2 incorrectly.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23638 Sun Dec 19 22:25:50 MST 2010 adnan.durrani Fix towards ICE-6343, ICE-6345
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/TabSetRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.tab/tabset.js
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
              Modified: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Sending content: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Sending content: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js
              Completed: At revision: 23638

              Show
              Adnan Durrani added a comment - Command: Commit Modified: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Modified: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: C:\development\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: C:\development\icefaces\ace\component\resources\org.icefaces.component.tab\tabset.js Completed: At revision: 23638
              Adnan Durrani made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Tested successfully on Icefaces2 revision# 23643, using FF3.6 & Chrome8.

              Show
              Mandeep Hayher added a comment - Tested successfully on Icefaces2 revision# 23643, using FF3.6 & Chrome8.
              Mandeep Hayher made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: