ICEfaces
  1. ICEfaces
  2. ICE-6329

ACE: sliderEntry focus behaviour issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF 2, Adv. Comps, ace-showcase sample, FF 3.6 or Chrome/Safari.
    • Affects:
      Sample App./Tutorial

      Description

      When testing the sliderEntry demo in the ace-showcase app, some strange focus-mgmt issues are apparent:

      1. Try tabbing into the horiz. slider entry, then using the arrow keys to increase/decrease the slider value. SingleSubmit occurs, focus stays on slider, all good. Now tab onto the "Submit" button at bottom of demo, then Shift-Tab back up to the horiz. slider, use arrows to change value. Single-submit occurs, and focus is moved back to the Submit button! This will keep happening unless you focus on the inputText field above the horiz. slider, then back to the slider, then it's fine again. Is there something about the focus in the slider that makes it 2nd class element vs. the inputText and Submit button? It seems like the bridge's focus-retention feature is somehow sticking on the submit button once it's been focussed, until another native widget like the inputText is focussed.

      2. Use the mouse to click on the horiz. slider bar (not the arrow itself, the bar beside it), slider moves to new position and gets focus, now keyboard arrows will adjust slider position. All good. Then click on vertical slider bar (not arrow). Focus is not set on vertical slider after clicking on bar for some reason. Not good.

      Happens the same way on Safari 5, Chrome, and FF 3.6 ( all I tested).




        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Affects [Sample App./Tutorial]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Summary ACE: sliderEntry comp. loses focus when "singleSubmit=true" ACE: sliderEntry focus behaviour issues
        Environment IF 2, Adv. Comps IF 2, Adv. Comps, ace-showcase sample, FF 3.6 or Chrome/Safari.
        Salesforce Case []
        Description When using the keyboard to move the sliderEntry arrow in ace-showcase (singleSubmit=true demo), the focus is lost after the submit occurs, making it difficult to keep using the keyboard for further changes. Not sure if this is a comp. issue or a bridge focus retention issue, but I think it might be the component as you can see the focus being set after the submit finishes, and then lost again.
        When testing the sliderEntry demo in the ace-showcase app, some strange focus-mgmt issues are apparent:

        1. Try tabbing into the horiz. slider entry, then using the arrow keys to increase/decrease the slider value. SingleSubmit occurs, focus stays on slider, all good. Now tab onto the "Submit" button at bottom of demo, then Shift-Tab back up to the horiz. slider, use arrows to change value. Single-submit occurs, and focus is moved back to the Submit button! This will keep happening unless you focus on the inputText field above the horiz. slider, then back to the slider, then it's fine again. Is there something about the focus in the slider that makes it 2nd class element vs. the inputText and Submit button? It seems like the bridge's focus-retention feature is somehow sticking on the submit button once it's been focussed, until another native widget like the inputText is focussed.

        2. Use the mouse to click on the horiz. slider bar (not the arrow itself, the bar beside it), slider moves to new position and gets focus, now keyboard arrows will adjust slider position. All good. Then click on vertical slider bar (not arrow). Focus is not set on vertical slider after clicking on bar for some reason. Not good.

        Happens the same way on Safari 5, Chrome, and FF 3.6 ( all I tested).




        Hide
        Ken Fyten added a comment -

        Here's a video link that demonstrates some of the issues:

        http://screencast.com/t/x1nxb9N3

        Show
        Ken Fyten added a comment - Here's a video link that demonstrates some of the issues: http://screencast.com/t/x1nxb9N3
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2 P1
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Adnan Durrani [ adnan.durrani ] Mircea Toma [ mircea.toma ]
        Hide
        Ken Fyten added a comment -

        Please investigate, this seems to happen consistently on all browsers, makes me think it is a component issue.

        Show
        Ken Fyten added a comment - Please investigate, this seems to happen consistently on all browsers, makes me think it is a component issue.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Mircea Toma [ mircea.toma ] Adnan Durrani [ adnan.durrani ]
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23300 Sun Dec 05 18:17:21 MST 2010 adnan.durrani Fix for ICE-6329 (ACE: sliderEntry focus behaviour issues)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
        Hide
        Adnan Durrani added a comment -

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
        Completed: At revision: 23300

        Show
        Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Completed: At revision: 23300
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mandeep Hayher added a comment - - edited

        icefaces2 revision# 23411
        server Tomcat6

        Chrome8 & safari5, FF3.6
        Issue1 fixed

        Issue2 clicking on the slider bar does not get focus on the slider component.

        Show
        Mandeep Hayher added a comment - - edited icefaces2 revision# 23411 server Tomcat6 Chrome8 & safari5, FF3.6 Issue1 fixed Issue2 clicking on the slider bar does not get focus on the slider component.
        Mandeep Hayher made changes -
        Assignee Adnan Durrani [ adnan.durrani ] Ken Fyten [ ken.fyten ]
        Mandeep Hayher made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ken Fyten added a comment -

        Need to look at: "Issue2 clicking on the slider bar does not get focus on the slider component. " Basically, if the slider doesn't have focus, and you click on the bar, it jumps to the clicked bar value, but doesn't also assign focus to the slider, which it should. Currently, you have to click on the arrow image for the focus to be set, but clicking on the bar should also work.

        Show
        Ken Fyten added a comment - Need to look at: "Issue2 clicking on the slider bar does not get focus on the slider component. " Basically, if the slider doesn't have focus, and you click on the bar, it jumps to the clicked bar value, but doesn't also assign focus to the slider, which it should. Currently, you have to click on the arrow image for the focus to be set, but clicking on the bar should also work.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1 P2
        Assignee Ken Fyten [ ken.fyten ] Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.1 [ 10241 ]
        Fix Version/s 2.0.0 [ 10230 ]
        Assignee Priority P2
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.1 [ 10255 ]
        Fix Version/s 2.1 [ 10241 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ] Yip Ng [ yip.ng ]
        Hide
        yip.ng added a comment - - edited

        Clicking too close to the bar doesn't get focus. (This is true even for the horizontal slider, not just the vertical slider as implied in the description.) But if you click a little further away from the bar (on the bottom for horizontal slider and on the right for vertical slider), you will get focus.

        Show
        yip.ng added a comment - - edited Clicking too close to the bar doesn't get focus. (This is true even for the horizontal slider, not just the vertical slider as implied in the description.) But if you click a little further away from the bar (on the bottom for horizontal slider and on the right for vertical slider), you will get focus.
        Hide
        yip.ng added a comment - - edited

        In YUI 3 examples, clicking anywhere won't get us focus at all. Therefore, focusing may have been done by us, not YUI.

        Show
        yip.ng added a comment - - edited In YUI 3 examples, clicking anywhere won't get us focus at all. Therefore, focusing may have been done by us, not YUI.
        Hide
        yip.ng added a comment - - edited

        There is already code (by us, not YUI) to do the focusing on the click event, but somehow this only works when you click not too close to the bar.

        Show
        yip.ng added a comment - - edited There is already code (by us, not YUI) to do the focusing on the click event, but somehow this only works when you click not too close to the bar.
        Hide
        yip.ng added a comment -

        Tried other means of listening to click event. No luck. Need to look deeper into YUI source code.

        Show
        yip.ng added a comment - Tried other means of listening to click event. No luck. Need to look deeper into YUI source code.
        Ken Fyten made changes -
        Salesforce Case []
        Priority Major [ 3 ] Minor [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23825 Thu Jan 20 09:57:43 MST 2011 yip.ng ICE-6329: sliderEntry focus behaviour issues.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
        Hide
        yip.ng added a comment -

        Fixed.

        Revision: 23825


        Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js

        Show
        yip.ng added a comment - Fixed. Revision: 23825 Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            yip.ng
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: