Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: 2.0.0
-
Component/s: ACE-Components, Framework
-
Labels:None
-
Environment:ICEfaces 2
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration
Description
In the case of the ace components, placing inside a <icecore:singleSubmit> region on the page should have the effect of setting all the ace components "singleSubmit" attributes to "true". This approach will ensure that the ace component behaviour inside a singleSubmit region will be identical to that when their "singleSubmit" attribute is set to true.
This will require:
1. A mechanism for the ace component renderers to know if they are inside a singleSubmit region, so they can set their singleSubmit attributes accordingly (if not already defined by the application).
2. A way to ensure that the ace component events do not trigger the default "icecore:singleSubmit" tag submit behaviour based on event bubbling.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The mechanism is provided, however new JIRAs should be created to enhance for subtree rendering. Individual component JIRAs will be necessary to implement singleSubmit detection.
Need adapt the technique used by the compat components in the gettor for partialSubmit property where they check to see if the partialSubmit is being specified in the form and use that as the default value for the partialSubmit attribute. Note that any user-specified value for singleSubmit attribute on the component must override this default value.
Implementing this will require overriding the generator-created gettor for singleSubmit attribute with a concrete impl. in the component base class.
Overriding generated getter will produce code as shown in screenshot 1. Not good. Too many lines copied from super class. (It's almost like inserting withinSingleSubmit() as the last line of the generated getter.) This has to be done for every component. And what if the generated code started to change?
Something similar to the following might allow the component to incorporate this into a utility method:
public boolean superValueIfSet(UIComponent component, String attName, boolean superValue, boolean defaultValue) {
ValueExpression ve = component.getValueExpression(attName);
if (ve != null)
......
return defaultValue
}
public boolean isSingleSubmit()
{ return Util.superValueIfSet(this, PropertyKeys.singleSubmit.name(), super.isSingleSubmit(), Util.withinSingleSubmit(this)); }Need to pass state helper in as well because getStateHelper() is protected.
Revision: 23447
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/checkboxbutton/CheckboxButton.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntry.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/LinkButton.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/pushbutton/PushButton.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntry.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/TabSet.java
Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/Utils.java
Method added to org.icefaces.impl.util.Util:
public static boolean withinSingleSubmit(UIComponent component)
Individual components need to call this at render time to determine their singleSubmit state.
Note that the current implementation does not support subtree rendering because the SingleSubmitRenderer adds an attribute to the parent component and uses the detection of that attribute to return the boolean value. This must be implemented at the TagHandler level, likely with a mechanism similar to the mojarra AjaxHandler, to support subtree rendering.